From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: kernel-janitors@vger.kernel.org,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 02/20] net/mlx5e: drop useless LIST_HEAD
Date: Sun, 23 Dec 2018 09:56:57 +0100 [thread overview]
Message-ID: <1545555435-24576-3-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr>
Drop LIST_HEAD where the variable it declares is never used.
These became useless in 244cd96adb5f ("net_sched: remove list_head
from tc_action")
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
// </smpl>
Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Successfully 0-day tested on 151 configurations.
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 4d6c9757afad..cae6c6d48984 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2183,7 +2183,6 @@ static bool modify_header_match_supported(struct mlx5_flow_spec *spec,
{
const struct tc_action *a;
bool modify_ip_header;
- LIST_HEAD(actions);
u8 htype, ip_proto;
void *headers_v;
u16 ethertype;
@@ -2272,7 +2271,6 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
{
struct mlx5_nic_flow_attr *attr = flow->nic_attr;
const struct tc_action *a;
- LIST_HEAD(actions);
u32 action = 0;
int err, i;
@@ -2511,7 +2509,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
struct mlx5e_rep_priv *rpriv = priv->ppriv;
struct ip_tunnel_info *info = NULL;
const struct tc_action *a;
- LIST_HEAD(actions);
bool encap = false;
u32 action = 0;
int err, i;
next prev parent reply other threads:[~2018-12-23 9:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:56 ` [PATCH 01/20] nfsd: " Julia Lawall
2018-12-23 21:26 ` J. Bruce Fields
2018-12-23 8:56 ` Julia Lawall [this message]
2018-12-23 9:40 ` [PATCH 02/20] net/mlx5e: " Leon Romanovsky
2018-12-23 8:56 ` [PATCH 03/20] scsi: lpfc: lpfc_nvme: " Julia Lawall
2018-12-23 8:56 ` [PATCH 04/20] scsi: lpfc: lpfc_scsi: " Julia Lawall
2018-12-23 8:57 ` [PATCH 05/20] scsi: lpfc: lpfc_sli: " Julia Lawall
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
2018-12-23 9:41 ` Leon Romanovsky
2019-01-02 22:48 ` Jason Gunthorpe
2018-12-23 8:57 ` [PATCH 07/20] dmaengine: at_hdmac: " Julia Lawall
2018-12-24 9:36 ` Ludovic Desroches
2019-01-02 6:04 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 08/20] xfs: xfs_buf: " Julia Lawall
2018-12-23 22:51 ` Darrick J. Wong
2018-12-24 6:32 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 09/20] xfs: xfs_fsops: " Julia Lawall
2018-12-23 22:51 ` Darrick J. Wong
2018-12-23 8:57 ` [PATCH 10/20] scsi: qla2xxx: " Julia Lawall
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2019-01-02 16:40 ` David Sterba
2018-12-23 8:57 ` [PATCH 12/20] dmaengine: dw: " Julia Lawall
2019-01-02 6:03 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 13/20] xenbus: " Julia Lawall
2019-01-08 6:58 ` Juergen Gross
2018-12-23 8:57 ` [PATCH 14/20] dmaengine: st_fdma: " Julia Lawall
2019-01-02 6:03 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 15/20] NFS: " Julia Lawall
2019-02-21 22:40 ` Trond Myklebust
2018-12-23 8:57 ` [PATCH 16/20] mlxsw: spectrum: " Julia Lawall
2018-12-23 8:57 ` [PATCH 17/20] dmaengine: pl330: " Julia Lawall
2019-01-02 6:04 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 18/20] dmaengine: sa11x0: " Julia Lawall
2019-01-02 6:04 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
2018-12-23 8:57 ` [PATCH 20/20] cw1200: " Julia Lawall
2019-01-08 16:30 ` Kalle Valo
2019-01-08 16:44 ` Julia Lawall
2019-01-10 11:36 ` Kalle Valo
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545555435-24576-3-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).