linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Doug Ledford <dledford@redhat.com>
Cc: kernel-janitors@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD
Date: Sun, 23 Dec 2018 09:57:01 +0100	[thread overview]
Message-ID: <1545555435-24576-7-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr>

Drop LIST_HEAD where the variable it declares is never used.

Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
when reaping AHs") removed the uses, but not the declaration.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
  ... when != x
// </smpl>

Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping AHs")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
Successfully 0-day tested on 151 configurations.

 drivers/infiniband/ulp/ipoib/ipoib_ib.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index 6d35570092d6..78fa777c87b1 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -669,7 +669,6 @@ static void __ipoib_reap_ah(struct net_device *dev)
 {
 	struct ipoib_dev_priv *priv = ipoib_priv(dev);
 	struct ipoib_ah *ah, *tah;
-	LIST_HEAD(remove_list);
 	unsigned long flags;
 
 	netif_tx_lock_bh(dev);


  parent reply	other threads:[~2018-12-23  9:35 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23  8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23  8:56 ` [PATCH 01/20] nfsd: " Julia Lawall
2018-12-23 21:26   ` J. Bruce Fields
2018-12-23  8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
2018-12-23  9:40   ` Leon Romanovsky
2018-12-23  8:56 ` [PATCH 03/20] scsi: lpfc: lpfc_nvme: " Julia Lawall
2018-12-23  8:56 ` [PATCH 04/20] scsi: lpfc: lpfc_scsi: " Julia Lawall
2018-12-23  8:57 ` [PATCH 05/20] scsi: lpfc: lpfc_sli: " Julia Lawall
2018-12-23  8:57 ` Julia Lawall [this message]
2018-12-23  9:41   ` [PATCH 06/20] IB/ipoib: " Leon Romanovsky
2019-01-02 22:48   ` Jason Gunthorpe
2018-12-23  8:57 ` [PATCH 07/20] dmaengine: at_hdmac: " Julia Lawall
2018-12-24  9:36   ` Ludovic Desroches
2019-01-02  6:04   ` Vinod Koul
2018-12-23  8:57 ` [PATCH 08/20] xfs: xfs_buf: " Julia Lawall
2018-12-23 22:51   ` Darrick J. Wong
2018-12-24  6:32     ` Julia Lawall
2018-12-23  8:57 ` [PATCH 09/20] xfs: xfs_fsops: " Julia Lawall
2018-12-23 22:51   ` Darrick J. Wong
2018-12-23  8:57 ` [PATCH 10/20] scsi: qla2xxx: " Julia Lawall
2018-12-23  8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2019-01-02 16:40   ` David Sterba
2018-12-23  8:57 ` [PATCH 12/20] dmaengine: dw: " Julia Lawall
2019-01-02  6:03   ` Vinod Koul
2018-12-23  8:57 ` [PATCH 13/20] xenbus: " Julia Lawall
2019-01-08  6:58   ` Juergen Gross
2018-12-23  8:57 ` [PATCH 14/20] dmaengine: st_fdma: " Julia Lawall
2019-01-02  6:03   ` Vinod Koul
2018-12-23  8:57 ` [PATCH 15/20] NFS: " Julia Lawall
2019-02-21 22:40   ` Trond Myklebust
2018-12-23  8:57 ` [PATCH 16/20] mlxsw: spectrum: " Julia Lawall
2018-12-23  8:57 ` [PATCH 17/20] dmaengine: pl330: " Julia Lawall
2019-01-02  6:04   ` Vinod Koul
2018-12-23  8:57 ` [PATCH 18/20] dmaengine: sa11x0: " Julia Lawall
2019-01-02  6:04   ` Vinod Koul
2018-12-23  8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
2018-12-23  8:57 ` [PATCH 20/20] cw1200: " Julia Lawall
2019-01-08 16:30   ` Kalle Valo
2019-01-08 16:44     ` Julia Lawall
2019-01-10 11:36   ` Kalle Valo
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
2018-12-23 22:06   ` Julia Lawall
2018-12-25 22:12     ` Tom Psyborg
2018-12-27 13:40       ` Dan Carpenter
2018-12-29  5:25         ` Darrick J. Wong
2018-12-29  6:19           ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545555435-24576-7-git-send-email-Julia.Lawall@lip6.fr \
    --to=julia.lawall@lip6.fr \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).