From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/20] xfs: xfs_fsops: drop useless LIST_HEAD
Date: Sun, 23 Dec 2018 14:51:28 -0800 [thread overview]
Message-ID: <20181223225128.GI27208@magnolia> (raw)
In-Reply-To: <1545555435-24576-10-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Dec 23, 2018 at 09:57:04AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> Commit 0410c3bb2b88 ("xfs: factor ag btree root block
> initialisation") stopped using buffer_list and started using a
> buffer list in an aghdr_init_data structure, but the declaration
> of buffer_list was not removed.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 0410c3bb2b88 ("xfs: factor ag btree root block initialisation")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> ---
> Successfully 0-day tested on 151 configurations.
>
> fs/xfs/xfs_fsops.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
> index ec2e63a7963b..f3ef70c542e1 100644
> --- a/fs/xfs/xfs_fsops.c
> +++ b/fs/xfs/xfs_fsops.c
> @@ -40,7 +40,6 @@ xfs_growfs_data_private(
> xfs_rfsblock_t new;
> xfs_agnumber_t oagcount;
> xfs_trans_t *tp;
> - LIST_HEAD (buffer_list);
> struct aghdr_init_data id = {};
>
> nb = in->newblocks;
>
next prev parent reply other threads:[~2018-12-23 22:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:56 ` [PATCH 01/20] nfsd: " Julia Lawall
2018-12-23 21:26 ` J. Bruce Fields
2018-12-23 8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
2018-12-23 9:40 ` Leon Romanovsky
2018-12-23 8:56 ` [PATCH 03/20] scsi: lpfc: lpfc_nvme: " Julia Lawall
2018-12-23 8:56 ` [PATCH 04/20] scsi: lpfc: lpfc_scsi: " Julia Lawall
2018-12-23 8:57 ` [PATCH 05/20] scsi: lpfc: lpfc_sli: " Julia Lawall
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
2018-12-23 9:41 ` Leon Romanovsky
2019-01-02 22:48 ` Jason Gunthorpe
2018-12-23 8:57 ` [PATCH 07/20] dmaengine: at_hdmac: " Julia Lawall
2018-12-24 9:36 ` Ludovic Desroches
2019-01-02 6:04 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 08/20] xfs: xfs_buf: " Julia Lawall
2018-12-23 22:51 ` Darrick J. Wong
2018-12-24 6:32 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 09/20] xfs: xfs_fsops: " Julia Lawall
2018-12-23 22:51 ` Darrick J. Wong [this message]
2018-12-23 8:57 ` [PATCH 10/20] scsi: qla2xxx: " Julia Lawall
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2019-01-02 16:40 ` David Sterba
2018-12-23 8:57 ` [PATCH 12/20] dmaengine: dw: " Julia Lawall
2019-01-02 6:03 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 13/20] xenbus: " Julia Lawall
2019-01-08 6:58 ` Juergen Gross
2018-12-23 8:57 ` [PATCH 14/20] dmaengine: st_fdma: " Julia Lawall
2019-01-02 6:03 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 15/20] NFS: " Julia Lawall
2019-02-21 22:40 ` Trond Myklebust
2018-12-23 8:57 ` [PATCH 16/20] mlxsw: spectrum: " Julia Lawall
2018-12-23 8:57 ` [PATCH 17/20] dmaengine: pl330: " Julia Lawall
2019-01-02 6:04 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 18/20] dmaengine: sa11x0: " Julia Lawall
2019-01-02 6:04 ` Vinod Koul
2018-12-23 8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
2018-12-23 8:57 ` [PATCH 20/20] cw1200: " Julia Lawall
2019-01-08 16:30 ` Kalle Valo
2019-01-08 16:44 ` Julia Lawall
2019-01-10 11:36 ` Kalle Valo
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223225128.GI27208@magnolia \
--to=darrick.wong@oracle.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).