From: Pawel Laszczak <pawell@cadence.com>
To: <devicetree@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <mark.rutland@arm.com>,
<linux-usb@vger.kernel.org>, <hdegoede@redhat.com>,
<heikki.krogerus@linux.intel.com>, <andy.shevchenko@gmail.com>,
<robh+dt@kernel.org>, <rogerq@ti.com>,
<linux-kernel@vger.kernel.org>, <adouglas@cadence.com>,
<jbergsagel@ti.com>, <nsekhar@ti.com>, <nm@ti.com>,
<sureshp@cadence.com>, <peter.chen@nxp.com>, <pjez@cadence.com>,
<kurahul@cadence.com>, Pawel Laszczak <pawell@cadence.com>
Subject: [PATCH v2 4/5] usb:common Simplify usb_decode_get_set_descriptor function.
Date: Sun, 23 Dec 2018 15:13:11 +0000 [thread overview]
Message-ID: <1545577992-4013-5-git-send-email-pawell@cadence.com> (raw)
In-Reply-To: <1545577992-4013-1-git-send-email-pawell@cadence.com>
Patch moves switch responsible for decoding descriptor type
outside snprintf. It's little improves code readability.
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
drivers/usb/common/debug.c | 111 +++++++++++++++++++------------------
1 file changed, 57 insertions(+), 54 deletions(-)
diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c
index 77e565a38f29..c15fa066339c 100644
--- a/drivers/usb/common/debug.c
+++ b/drivers/usb/common/debug.c
@@ -104,62 +104,65 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest,
__u16 wValue, __u16 wIndex,
__u16 wLength, char *str)
{
+ char *s;
+
+ switch (wValue >> 8) {
+ case USB_DT_DEVICE:
+ s = "Device";
+ break;
+ case USB_DT_CONFIG:
+ s = "Configuration";
+ break;
+ case USB_DT_STRING:
+ s = "String";
+ break;
+ case USB_DT_INTERFACE:
+ s = "Interface";
+ break;
+ case USB_DT_ENDPOINT:
+ s = "Endpoint";
+ break;
+ case USB_DT_DEVICE_QUALIFIER:
+ s = "Device Qualifier";
+ break;
+ case USB_DT_OTHER_SPEED_CONFIG:
+ s = "Other Speed Config";
+ break;
+ case USB_DT_INTERFACE_POWER:
+ s = "Interface Power";
+ break;
+ case USB_DT_OTG:
+ s = "OTG";
+ break;
+ case USB_DT_DEBUG:
+ s = "Debug";
+ break;
+ case USB_DT_INTERFACE_ASSOCIATION:
+ s = "Interface Association";
+ break;
+ case USB_DT_BOS:
+ s = "BOS";
+ break;
+ case USB_DT_DEVICE_CAPABILITY:
+ s = "Device Capability";
+ break;
+ case USB_DT_PIPE_USAGE:
+ s = "Pipe Usage";
+ break;
+ case USB_DT_SS_ENDPOINT_COMP:
+ s = "SS Endpoint Companion";
+ break;
+ case USB_DT_SSP_ISOC_ENDPOINT_COMP:
+ s = "SSP Isochronous Endpoint Companion";
+ break;
+ default:
+ s = "UNKNOWN";
+ break;
+ }
+
sprintf(str, "%s %s Descriptor(Index = %d, Length = %d)",
bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",
- ({ char *s;
- switch (wValue >> 8) {
- case USB_DT_DEVICE:
- s = "Device";
- break;
- case USB_DT_CONFIG:
- s = "Configuration";
- break;
- case USB_DT_STRING:
- s = "String";
- break;
- case USB_DT_INTERFACE:
- s = "Interface";
- break;
- case USB_DT_ENDPOINT:
- s = "Endpoint";
- break;
- case USB_DT_DEVICE_QUALIFIER:
- s = "Device Qualifier";
- break;
- case USB_DT_OTHER_SPEED_CONFIG:
- s = "Other Speed Config";
- break;
- case USB_DT_INTERFACE_POWER:
- s = "Interface Power";
- break;
- case USB_DT_OTG:
- s = "OTG";
- break;
- case USB_DT_DEBUG:
- s = "Debug";
- break;
- case USB_DT_INTERFACE_ASSOCIATION:
- s = "Interface Association";
- break;
- case USB_DT_BOS:
- s = "BOS";
- break;
- case USB_DT_DEVICE_CAPABILITY:
- s = "Device Capability";
- break;
- case USB_DT_PIPE_USAGE:
- s = "Pipe Usage";
- break;
- case USB_DT_SS_ENDPOINT_COMP:
- s = "SS Endpoint Companion";
- break;
- case USB_DT_SSP_ISOC_ENDPOINT_COMP:
- s = "SSP Isochronous Endpoint Companion";
- break;
- default:
- s = "UNKNOWN";
- break;
- } s; }), wValue & 0xff, wLength);
+ s, wValue & 0xff, wLength);
}
static void usb_decode_get_configuration(__u16 wLength, char *str)
--
2.17.1
next prev parent reply other threads:[~2018-12-23 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 15:13 [PATCH v2 0/5] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 1/5] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 2/5] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 3/5] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2018-12-23 15:13 ` Pawel Laszczak [this message]
2018-12-23 15:13 ` [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-23 17:19 ` Randy Dunlap
2018-12-23 19:20 ` kbuild test robot
2018-12-31 9:42 ` Pawel Laszczak
2018-12-24 9:38 ` Peter Chen
2018-12-25 9:38 ` Peter Chen
2018-12-27 9:36 ` Pawel Laszczak
2018-12-28 1:31 ` Peter Chen
2018-12-31 5:32 ` Pawel Laszczak
2018-12-27 13:11 ` Pawel Laszczak
2018-12-29 7:41 ` Chunfeng Yun
2018-12-31 12:31 ` Pawel Laszczak
2019-01-10 1:30 ` Peter Chen
2019-01-10 6:57 ` Greg Kroah-Hartman
2019-01-10 7:18 ` Pawel Laszczak
2019-01-02 6:44 ` [PATCH v2 0/5] Introduced new Cadence USBSS " Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545577992-4013-5-git-send-email-pawell@cadence.com \
--to=pawell@cadence.com \
--cc=adouglas@cadence.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).