From: Pawel Laszczak <pawell@cadence.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <hzpeterchen@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
lkml <linux-kernel@vger.kernel.org>,
"adouglas@cadence.com" <adouglas@cadence.com>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Thu, 10 Jan 2019 07:18:50 +0000 [thread overview]
Message-ID: <BYAPR07MB4709A8E20953E24E67A801EADD840@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20190110065738.GA28817@kroah.com>
Hi,
>On Thu, Jan 10, 2019 at 09:30:41AM +0800, Peter Chen wrote:
>> On Mon, Dec 24, 2018 at 12:44 AM Pawel Laszczak <pawell@cadence.com> wrote:
>> - debugfs is nice to have feature, I suggest removing it at this
>> initial version. Besides, role switch
>> through /sys is normal feature, the end user may use it at real
>> product, so, it is better at device's
>> /sys entry instead of debugfs.
>>
>> - I don't know why you add "disable" at debugfs, please comment.
>
>As you imply here, no real-world functionality should ever be in
>debugfs as it is an optional system component and kernel code should
>work just fine without it being enabled (as more and more systems are
>disabling it due to the obvious security problems it has.)
>
"disable" it's not required. It's used for testing. It allows to enable/disable the current role.
It can be used for testing eg. connect/disconnect event.
I mainly test the driver remotely and I can't do connect/disconnect by USB cable.
"disable" allow me to get trace log from host/device without disconnecting cable:
I'm using the fallowing sequence:
- load cdns3.ko modules
- echo 1 > disable - disable current role
- echo cdns3:* tracing/set_event
- echo 0 > disable - enable role again
- cat tracing/trace.
Pawel
next prev parent reply other threads:[~2019-01-10 7:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 15:13 [PATCH v2 0/5] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 1/5] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 2/5] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 3/5] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 4/5] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2018-12-23 15:13 ` [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-23 17:19 ` Randy Dunlap
2018-12-23 19:20 ` kbuild test robot
2018-12-31 9:42 ` Pawel Laszczak
2018-12-24 9:38 ` Peter Chen
2018-12-25 9:38 ` Peter Chen
2018-12-27 9:36 ` Pawel Laszczak
2018-12-28 1:31 ` Peter Chen
2018-12-31 5:32 ` Pawel Laszczak
2018-12-27 13:11 ` Pawel Laszczak
2018-12-29 7:41 ` Chunfeng Yun
2018-12-31 12:31 ` Pawel Laszczak
2019-01-10 1:30 ` Peter Chen
2019-01-10 6:57 ` Greg Kroah-Hartman
2019-01-10 7:18 ` Pawel Laszczak [this message]
2019-01-02 6:44 ` [PATCH v2 0/5] Introduced new Cadence USBSS " Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB4709A8E20953E24E67A801EADD840@BYAPR07MB4709.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=adouglas@cadence.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hzpeterchen@gmail.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).