linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
@ 2019-03-11 15:51 Sabyasachi Gupta
  2019-03-11 16:13 ` James Bottomley
  0 siblings, 1 reply; 6+ messages in thread
From: Sabyasachi Gupta @ 2019-03-11 15:51 UTC (permalink / raw)
  To: akpm; +Cc: aacraid, jejb, martin.petersen, linux-scsi, linux-kernel, jrdr.linux

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
 drivers/scsi/dpt_i2o.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 37de8fb..056383a 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
 		schedule_timeout_uninterruptible(1);
 	} while (m == EMPTY_QUEUE);
 
-	status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
+	status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
 	if(status == NULL) {
 		adpt_send_nop(pHba, m);
 		printk(KERN_ERR"IOP reset failed - no free memory.\n");
 		return -ENOMEM;
 	}
-	memset(status,0,4);
 
 	msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
 	msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
@@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
 
 	msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
 
-	status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
+	status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
 	if (!status) {
 		adpt_send_nop(pHba, m);
 		printk(KERN_WARNING"%s: IOP reset failed - no free memory.\n",
 			pHba->name);
 		return -ENOMEM;
 	}
-	memset(status, 0, 4);
 
 	writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
 	writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]);
@@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
 			pHba->reply_pool, pHba->reply_pool_pa);
 	}
 
-	pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
+	pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
 				pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4,
 				&pHba->reply_pool_pa, GFP_KERNEL);
 	if (!pHba->reply_pool) {
 		printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name);
 		return -ENOMEM;
 	}
-	memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4);
 
 	for(i = 0; i < pHba->reply_fifo_size; i++) {
 		writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
@@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
 	sys_tbl_len = sizeof(struct i2o_sys_tbl) +	// Header + IOPs
 				(hba_count) * sizeof(struct i2o_sys_tbl_entry);
 
-	sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
+	sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
 				sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
 	if (!sys_tbl) {
 		printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");	
 		return -ENOMEM;
 	}
-	memset(sys_tbl, 0, sys_tbl_len);
 
 	sys_tbl->num_entries = hba_count;
 	sys_tbl->version = I2OVERSION;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
  2019-03-11 15:51 [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent Sabyasachi Gupta
@ 2019-03-11 16:13 ` James Bottomley
  0 siblings, 0 replies; 6+ messages in thread
From: James Bottomley @ 2019-03-11 16:13 UTC (permalink / raw)
  To: Sabyasachi Gupta, akpm
  Cc: aacraid, martin.petersen, linux-scsi, linux-kernel, jrdr.linux

On Mon, 2019-03-11 at 21:21 +0530, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

I really don't think so.  This API is going away:

https://lkml.org/lkml/2019/1/8/394

James


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
  2018-12-19 13:11   ` Sabyasachi Gupta
@ 2019-01-04 12:49     ` Sabyasachi Gupta
  0 siblings, 0 replies; 6+ messages in thread
From: Sabyasachi Gupta @ 2019-01-04 12:49 UTC (permalink / raw)
  To: aacraid, jejb, martin.petersen
  Cc: Souptick Joarder, linux-scsi, linux-kernel, Brajeswar Ghosh

On Wed, Dec 19, 2018 at 6:41 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> >
> > On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta
> > <sabyasachi.linux@gmail.com> wrote:
> > >
> > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
> > >
> > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> >
> > Any comment on this patch?
>
> Any comment on this patch?
>
Any comment on this patch?

> >
> > > ---
> > >  drivers/scsi/dpt_i2o.c | 12 ++++--------
> > >  1 file changed, 4 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > > index 37de8fb..056383a 100644
> > > --- a/drivers/scsi/dpt_i2o.c
> > > +++ b/drivers/scsi/dpt_i2o.c
> > > @@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
> > >                 schedule_timeout_uninterruptible(1);
> > >         } while (m == EMPTY_QUEUE);
> > >
> > > -       status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > > +       status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > >         if(status == NULL) {
> > >                 adpt_send_nop(pHba, m);
> > >                 printk(KERN_ERR"IOP reset failed - no free memory.\n");
> > >                 return -ENOMEM;
> > >         }
> > > -       memset(status,0,4);
> > >
> > >         msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
> > >         msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
> > > @@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
> > >
> > >         msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
> > >
> > > -       status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > > +       status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > >         if (!status) {
> > >                 adpt_send_nop(pHba, m);
> > >                 printk(KERN_WARNING"%s: IOP reset failed - no free memory.\n",
> > >                         pHba->name);
> > >                 return -ENOMEM;
> > >         }
> > > -       memset(status, 0, 4);
> > >
> > >         writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
> > >         writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]);
> > > @@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
> > >                         pHba->reply_pool, pHba->reply_pool_pa);
> > >         }
> > >
> > > -       pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
> > > +       pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
> > >                                 pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4,
> > >                                 &pHba->reply_pool_pa, GFP_KERNEL);
> > >         if (!pHba->reply_pool) {
> > >                 printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name);
> > >                 return -ENOMEM;
> > >         }
> > > -       memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4);
> > >
> > >         for(i = 0; i < pHba->reply_fifo_size; i++) {
> > >                 writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
> > > @@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
> > >         sys_tbl_len = sizeof(struct i2o_sys_tbl) +      // Header + IOPs
> > >                                 (hba_count) * sizeof(struct i2o_sys_tbl_entry);
> > >
> > > -       sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
> > > +       sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
> > >                                 sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
> > >         if (!sys_tbl) {
> > >                 printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");
> > >                 return -ENOMEM;
> > >         }
> > > -       memset(sys_tbl, 0, sys_tbl_len);
> > >
> > >         sys_tbl->num_entries = hba_count;
> > >         sys_tbl->version = I2OVERSION;
> > > --
> > > 2.7.4
> > >

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
  2018-12-01 13:15 ` Sabyasachi Gupta
@ 2018-12-19 13:11   ` Sabyasachi Gupta
  2019-01-04 12:49     ` Sabyasachi Gupta
  0 siblings, 1 reply; 6+ messages in thread
From: Sabyasachi Gupta @ 2018-12-19 13:11 UTC (permalink / raw)
  To: aacraid, jejb, martin.petersen
  Cc: Souptick Joarder, linux-scsi, linux-kernel, Brajeswar Ghosh

On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> >
> > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>
> Any comment on this patch?

Any comment on this patch?

>
> > ---
> >  drivers/scsi/dpt_i2o.c | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > index 37de8fb..056383a 100644
> > --- a/drivers/scsi/dpt_i2o.c
> > +++ b/drivers/scsi/dpt_i2o.c
> > @@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
> >                 schedule_timeout_uninterruptible(1);
> >         } while (m == EMPTY_QUEUE);
> >
> > -       status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > +       status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> >         if(status == NULL) {
> >                 adpt_send_nop(pHba, m);
> >                 printk(KERN_ERR"IOP reset failed - no free memory.\n");
> >                 return -ENOMEM;
> >         }
> > -       memset(status,0,4);
> >
> >         msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
> >         msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
> > @@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
> >
> >         msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
> >
> > -       status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > +       status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> >         if (!status) {
> >                 adpt_send_nop(pHba, m);
> >                 printk(KERN_WARNING"%s: IOP reset failed - no free memory.\n",
> >                         pHba->name);
> >                 return -ENOMEM;
> >         }
> > -       memset(status, 0, 4);
> >
> >         writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
> >         writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]);
> > @@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
> >                         pHba->reply_pool, pHba->reply_pool_pa);
> >         }
> >
> > -       pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
> > +       pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
> >                                 pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4,
> >                                 &pHba->reply_pool_pa, GFP_KERNEL);
> >         if (!pHba->reply_pool) {
> >                 printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name);
> >                 return -ENOMEM;
> >         }
> > -       memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4);
> >
> >         for(i = 0; i < pHba->reply_fifo_size; i++) {
> >                 writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
> > @@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
> >         sys_tbl_len = sizeof(struct i2o_sys_tbl) +      // Header + IOPs
> >                                 (hba_count) * sizeof(struct i2o_sys_tbl_entry);
> >
> > -       sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
> > +       sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
> >                                 sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
> >         if (!sys_tbl) {
> >                 printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");
> >                 return -ENOMEM;
> >         }
> > -       memset(sys_tbl, 0, sys_tbl_len);
> >
> >         sys_tbl->num_entries = hba_count;
> >         sys_tbl->version = I2OVERSION;
> > --
> > 2.7.4
> >

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
  2018-11-17 12:47 Sabyasachi Gupta
@ 2018-12-01 13:15 ` Sabyasachi Gupta
  2018-12-19 13:11   ` Sabyasachi Gupta
  0 siblings, 1 reply; 6+ messages in thread
From: Sabyasachi Gupta @ 2018-12-01 13:15 UTC (permalink / raw)
  To: aacraid, jejb, martin.petersen
  Cc: Souptick Joarder, linux-scsi, linux-kernel, Brajeswar Ghosh

On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>

Any comment on this patch?

> ---
>  drivers/scsi/dpt_i2o.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index 37de8fb..056383a 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
>                 schedule_timeout_uninterruptible(1);
>         } while (m == EMPTY_QUEUE);
>
> -       status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> +       status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
>         if(status == NULL) {
>                 adpt_send_nop(pHba, m);
>                 printk(KERN_ERR"IOP reset failed - no free memory.\n");
>                 return -ENOMEM;
>         }
> -       memset(status,0,4);
>
>         msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
>         msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
> @@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
>
>         msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
>
> -       status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> +       status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
>         if (!status) {
>                 adpt_send_nop(pHba, m);
>                 printk(KERN_WARNING"%s: IOP reset failed - no free memory.\n",
>                         pHba->name);
>                 return -ENOMEM;
>         }
> -       memset(status, 0, 4);
>
>         writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
>         writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]);
> @@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
>                         pHba->reply_pool, pHba->reply_pool_pa);
>         }
>
> -       pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
> +       pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
>                                 pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4,
>                                 &pHba->reply_pool_pa, GFP_KERNEL);
>         if (!pHba->reply_pool) {
>                 printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name);
>                 return -ENOMEM;
>         }
> -       memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4);
>
>         for(i = 0; i < pHba->reply_fifo_size; i++) {
>                 writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
> @@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
>         sys_tbl_len = sizeof(struct i2o_sys_tbl) +      // Header + IOPs
>                                 (hba_count) * sizeof(struct i2o_sys_tbl_entry);
>
> -       sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
> +       sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
>                                 sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
>         if (!sys_tbl) {
>                 printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");
>                 return -ENOMEM;
>         }
> -       memset(sys_tbl, 0, sys_tbl_len);
>
>         sys_tbl->num_entries = hba_count;
>         sys_tbl->version = I2OVERSION;
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
@ 2018-11-17 12:47 Sabyasachi Gupta
  2018-12-01 13:15 ` Sabyasachi Gupta
  0 siblings, 1 reply; 6+ messages in thread
From: Sabyasachi Gupta @ 2018-11-17 12:47 UTC (permalink / raw)
  To: aacraid, jejb, martin.petersen
  Cc: jrdr.linux, linux-scsi, linux-kernel, brajeswar.linux

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
 drivers/scsi/dpt_i2o.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 37de8fb..056383a 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
 		schedule_timeout_uninterruptible(1);
 	} while (m == EMPTY_QUEUE);
 
-	status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
+	status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
 	if(status == NULL) {
 		adpt_send_nop(pHba, m);
 		printk(KERN_ERR"IOP reset failed - no free memory.\n");
 		return -ENOMEM;
 	}
-	memset(status,0,4);
 
 	msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
 	msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
@@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
 
 	msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
 
-	status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
+	status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
 	if (!status) {
 		adpt_send_nop(pHba, m);
 		printk(KERN_WARNING"%s: IOP reset failed - no free memory.\n",
 			pHba->name);
 		return -ENOMEM;
 	}
-	memset(status, 0, 4);
 
 	writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
 	writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]);
@@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
 			pHba->reply_pool, pHba->reply_pool_pa);
 	}
 
-	pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
+	pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
 				pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4,
 				&pHba->reply_pool_pa, GFP_KERNEL);
 	if (!pHba->reply_pool) {
 		printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name);
 		return -ENOMEM;
 	}
-	memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4);
 
 	for(i = 0; i < pHba->reply_fifo_size; i++) {
 		writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
@@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
 	sys_tbl_len = sizeof(struct i2o_sys_tbl) +	// Header + IOPs
 				(hba_count) * sizeof(struct i2o_sys_tbl_entry);
 
-	sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
+	sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
 				sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
 	if (!sys_tbl) {
 		printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");	
 		return -ENOMEM;
 	}
-	memset(sys_tbl, 0, sys_tbl_len);
 
 	sys_tbl->num_entries = hba_count;
 	sys_tbl->version = I2OVERSION;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-11 16:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 15:51 [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent Sabyasachi Gupta
2019-03-11 16:13 ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2018-11-17 12:47 Sabyasachi Gupta
2018-12-01 13:15 ` Sabyasachi Gupta
2018-12-19 13:11   ` Sabyasachi Gupta
2019-01-04 12:49     ` Sabyasachi Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).