linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>
Subject: [PATCH/RFC 09/12] drm: rcar-du: lvds: Fix companion's mode
Date: Fri,  2 Aug 2019 08:34:06 +0100	[thread overview]
Message-ID: <1564731249-22671-10-git-send-email-fabrizio.castro@bp.renesas.com> (raw)
In-Reply-To: <1564731249-22671-1-git-send-email-fabrizio.castro@bp.renesas.com>

The companion encoder needs to be told to use the same
mode as the primary encoder.

Fixes: e9e8798ab7b8 ("drm: rcar-du: lvds: Add support for dual-link mode")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index edd63f5..7944ae9 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -415,8 +415,12 @@ static void rcar_lvds_enable(struct drm_bridge *bridge)
 		return;
 
 	/* Enable the companion LVDS encoder in dual-link mode. */
-	if (lvds->dual_link && lvds->companion)
+	if (lvds->dual_link && lvds->companion) {
+		struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds(
+							lvds->companion);
+		companion_lvds->mode = lvds->mode;
 		lvds->companion->funcs->enable(lvds->companion);
+	}
 
 	/*
 	 * Hardcode the channels and control signals routing for now.
-- 
2.7.4


  parent reply	other threads:[~2019-08-02  7:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02  7:33 [PATCH/RFC 00/12] Add dual-LVDS panel support to EK874 Fabrizio Castro
2019-08-02  7:33 ` [PATCH/RFC 01/12] dt-bindings: display: renesas: lvds: RZ/G2E needs renesas,companion too Fabrizio Castro
2019-08-02  7:48   ` Laurent Pinchart
2019-08-02  7:33 ` [PATCH/RFC 02/12] dt-bindings: display: renesas: lvds: Document renesas,swap-data Fabrizio Castro
2019-08-02  7:44   ` Laurent Pinchart
2019-08-05  8:59     ` Fabrizio Castro
2019-08-05  9:35       ` Laurent Pinchart
2019-08-05 10:07         ` Fabrizio Castro
2019-08-02  7:34 ` [PATCH/RFC 03/12] dt-bindings: panel: lvds: Add dual-link LVDS display support Fabrizio Castro
2019-08-02  8:00   ` Laurent Pinchart
2019-08-05  9:02     ` Fabrizio Castro
2019-08-02  7:34 ` [PATCH/RFC 04/12] dt-bindings: display: Add bindings for Advantech IDK-2121WR Fabrizio Castro
2019-08-02  8:03   ` Laurent Pinchart
2019-08-05  9:04     ` Fabrizio Castro
2019-08-02  7:34 ` [PATCH/RFC 05/12] drm: rcar-du: lvds: Add data swap support Fabrizio Castro
2019-08-02  8:06   ` Laurent Pinchart
2019-08-02  9:01     ` Geert Uytterhoeven
2019-08-05  9:32     ` Fabrizio Castro
2019-08-05 10:17       ` Laurent Pinchart
2019-08-02  7:34 ` [PATCH/RFC 06/12] drm: rcar-du: lvds: Do not look at ports for identifying bridges Fabrizio Castro
2019-08-02  8:08   ` Laurent Pinchart
2019-08-05  9:06     ` Fabrizio Castro
2019-08-02  7:34 ` [PATCH/RFC 07/12] drm: rcar-du: lvds: Add support for dual link panels Fabrizio Castro
2019-08-02  8:20   ` Laurent Pinchart
2019-08-05  9:12     ` Fabrizio Castro
2019-08-05  9:48       ` Laurent Pinchart
2019-08-05 10:07         ` Fabrizio Castro
2019-08-02  7:34 ` [PATCH/RFC 08/12] drm: rcar-du: lvds: Fix bridge_to_rcar_lvds Fabrizio Castro
2019-08-02  8:22   ` Laurent Pinchart
2019-08-05  9:13     ` Fabrizio Castro
2019-08-02  7:34 ` Fabrizio Castro [this message]
2019-08-02  8:26   ` [PATCH/RFC 09/12] drm: rcar-du: lvds: Fix companion's mode Laurent Pinchart
2019-08-05  9:15     ` Fabrizio Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564731249-22671-10-git-send-email-fabrizio.castro@bp.renesas.com \
    --to=fabrizio.castro@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).