From: "Clément Leger" <cleger@kalrayinc.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Jonathan Corbet <corbet@lwn.net>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-remoteproc <linux-remoteproc@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Andy Gross <agross@kernel.org>,
Patrice Chotard <patrice.chotard@st.com>,
linux-doc <linux-doc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
Loic PALLARDY <loic.pallardy@st.com>, s-anna <s-anna@ti.com>
Subject: Re: [PATCH v5 8/8] remoteproc: Adapt coredump to generate correct elf type
Date: Tue, 10 Mar 2020 09:12:44 +0100 (CET) [thread overview]
Message-ID: <1569234651.9042535.1583827964044.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <20200309235710.GE14744@builder>
Hi Bjorn,
----- On 10 Mar, 2020, at 00:57, Bjorn Andersson bjorn.andersson@linaro.org wrote:
> On Mon 09 Mar 13:32 PDT 2020, Mathieu Poirier wrote:
>
>> On Mon, Mar 02, 2020 at 10:39:02AM +0100, Clement Leger wrote:
>> > Now that remoteproc can load an elf64, coredump elf class should be
>> > the same as the loaded elf class. In order to do that, add a
>> > elf_class field to rproc with default values. If an elf is loaded
>> > successfully, this field will be updated with the loaded elf class.
>> > Then, the coredump core code has been modified to use the generic elf
>> > macro in order to create an elf file with correct class.
>> >
>> > Signed-off-by: Clement Leger <cleger@kalray.eu>
>> > ---
>> > drivers/remoteproc/remoteproc_core.c | 67 ++++++++++++++++--------------
>> > drivers/remoteproc/remoteproc_elf_loader.c | 3 ++
>> > include/linux/remoteproc.h | 1 +
>> > 3 files changed, 39 insertions(+), 32 deletions(-)
>> >
>> > diff --git a/drivers/remoteproc/remoteproc_core.c
>> > b/drivers/remoteproc/remoteproc_core.c
>> > index b932a64a2be2..f923355aa3f9 100644
>> > --- a/drivers/remoteproc/remoteproc_core.c
>> > +++ b/drivers/remoteproc/remoteproc_core.c
>> > @@ -38,6 +38,7 @@
>> > #include <linux/platform_device.h>
>> >
>> > #include "remoteproc_internal.h"
>> > +#include "remoteproc_elf_helpers.h"
>> >
>> > #define HIGH_BITS_MASK 0xFFFFFFFF00000000ULL
>> >
>> > @@ -1566,20 +1567,21 @@ EXPORT_SYMBOL(rproc_coredump_add_custom_segment);
>> > static void rproc_coredump(struct rproc *rproc)
>> > {
>> > struct rproc_dump_segment *segment;
>> > - struct elf32_phdr *phdr;
>> > - struct elf32_hdr *ehdr;
>> > + void *phdr;
>> > + void *ehdr;
>> > size_t data_size;
>> > size_t offset;
>> > void *data;
>> > void *ptr;
>> > + u8 class = rproc->elf_class;
>> > int phnum = 0;
>> >
>> > if (list_empty(&rproc->dump_segments))
>> > return;
>> >
>> > - data_size = sizeof(*ehdr);
>> > + data_size = elf_size_of_hdr(class);
>> > list_for_each_entry(segment, &rproc->dump_segments, node) {
>> > - data_size += sizeof(*phdr) + segment->size;
>> > + data_size += elf_size_of_phdr(class) + segment->size;
>> >
>> > phnum++;
>> > }
>> > @@ -1590,33 +1592,33 @@ static void rproc_coredump(struct rproc *rproc)
>> >
>> > ehdr = data;
>> >
>> > - memset(ehdr, 0, sizeof(*ehdr));
>> > - memcpy(ehdr->e_ident, ELFMAG, SELFMAG);
>> > - ehdr->e_ident[EI_CLASS] = ELFCLASS32;
>> > - ehdr->e_ident[EI_DATA] = ELFDATA2LSB;
>> > - ehdr->e_ident[EI_VERSION] = EV_CURRENT;
>> > - ehdr->e_ident[EI_OSABI] = ELFOSABI_NONE;
>> > - ehdr->e_type = ET_CORE;
>> > - ehdr->e_machine = EM_NONE;
>> > - ehdr->e_version = EV_CURRENT;
>> > - ehdr->e_entry = rproc->bootaddr;
>> > - ehdr->e_phoff = sizeof(*ehdr);
>> > - ehdr->e_ehsize = sizeof(*ehdr);
>> > - ehdr->e_phentsize = sizeof(*phdr);
>> > - ehdr->e_phnum = phnum;
>> > -
>> > - phdr = data + ehdr->e_phoff;
>> > - offset = ehdr->e_phoff + sizeof(*phdr) * ehdr->e_phnum;
>> > + memset(ehdr, 0, elf_size_of_hdr(class));
>> > + /* e_ident field is common for both elf32 and elf64 */
>> > + elf_hdr_init_ident(ehdr, class);
>> > +
>> > + elf_hdr_set_e_type(class, ehdr, ET_CORE);
>> > + elf_hdr_set_e_machine(class, ehdr, EM_NONE);
>> > + elf_hdr_set_e_version(class, ehdr, EV_CURRENT);
>> > + elf_hdr_set_e_entry(class, ehdr, rproc->bootaddr);
>> > + elf_hdr_set_e_phoff(class, ehdr, elf_size_of_hdr(class));
>> > + elf_hdr_set_e_ehsize(class, ehdr, elf_size_of_hdr(class));
>> > + elf_hdr_set_e_phentsize(class, ehdr, elf_size_of_phdr(class));
>> > + elf_hdr_set_e_phnum(class, ehdr, phnum);
>> > +
>> > + phdr = data + elf_hdr_get_e_phoff(class, ehdr);
>> > + offset = elf_hdr_get_e_phoff(class, ehdr);
>> > + offset += elf_size_of_phdr(class) * elf_hdr_get_e_phnum(class, ehdr);
>> > +
>> > list_for_each_entry(segment, &rproc->dump_segments, node) {
>> > - memset(phdr, 0, sizeof(*phdr));
>> > - phdr->p_type = PT_LOAD;
>> > - phdr->p_offset = offset;
>> > - phdr->p_vaddr = segment->da;
>> > - phdr->p_paddr = segment->da;
>> > - phdr->p_filesz = segment->size;
>> > - phdr->p_memsz = segment->size;
>> > - phdr->p_flags = PF_R | PF_W | PF_X;
>> > - phdr->p_align = 0;
>> > + memset(phdr, 0, elf_size_of_phdr(class));
>> > + elf_phdr_set_p_type(class, phdr, PT_LOAD);
>> > + elf_phdr_set_p_offset(class, phdr, offset);
>> > + elf_phdr_set_p_vaddr(class, phdr, segment->da);
>> > + elf_phdr_set_p_paddr(class, phdr, segment->da);
>> > + elf_phdr_set_p_filesz(class, phdr, segment->size);
>> > + elf_phdr_set_p_memsz(class, phdr, segment->size);
>> > + elf_phdr_set_p_flags(class, phdr, PF_R | PF_W | PF_X);
>> > + elf_phdr_set_p_align(class, phdr, 0);
>> >
>> > if (segment->dump) {
>> > segment->dump(rproc, segment, data + offset);
>> > @@ -1632,8 +1634,8 @@ static void rproc_coredump(struct rproc *rproc)
>> > }
>> > }
>> >
>> > - offset += phdr->p_filesz;
>> > - phdr++;
>> > + offset += elf_phdr_get_p_filesz(class, phdr);
>> > + phdr += elf_size_of_phdr(class);
>> > }
>> >
>> > dev_coredumpv(&rproc->dev, data, data_size, GFP_KERNEL);
>> > @@ -2031,6 +2033,7 @@ struct rproc *rproc_alloc(struct device *dev, const char
>> > *name,
>> > rproc->name = name;
>> > rproc->priv = &rproc[1];
>> > rproc->auto_boot = true;
>> > + rproc->elf_class = ELFCLASS32;
>>
>> I would initialise this to ELFCLASSNONE to make sure that if a platform driver
>> overwrites rproc_elf_load_segments or doesn't provide one, we don't falsely
>> deduce the elf type. It goes without saying that if elf_class == ELFCLASSNONE,
>> a coredump is not generated.
>>
>
> I like the idea of making the choice explicit, perhaps even more
> explicit than the assumption that the coredumps should be of the same
> type as the ELF loaded. Note that it's different consumers of the two
> ELF files.
>
>> Unless you think this is a seriously bad idea or Bjorn over rules me,
Ok, I tried to do the equivalent of what was existing (ie elf32 by default).
But IMHO, letting the driver choose the elf type is a better idea.
>>
>> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>
>
> Not sure if it count as "over ruling", I accept your suggestion but used
> your R-b to merge the patch as is, no need to hold this up any longer.
>
> Clement, can you please follow up with a patch implementing this (don't
> forget that the qcom drivers doesn't use rproc_elf_load_segments())
I was going to send a v7, please tell me if you want to hold it a bit more.
If not, I will address the remaining comments in next commits.
>
> Thanks Clement and thanks for the reviews Mathieu.
>
> Regards,
> Bjorn
>
>> Thanks,
>> Mathieu
>>
>> >
>> > device_initialize(&rproc->dev);
>> > rproc->dev.parent = dev;
>> > diff --git a/drivers/remoteproc/remoteproc_elf_loader.c
>> > b/drivers/remoteproc/remoteproc_elf_loader.c
>> > index 4869fb7d8fe4..16e2c496fd45 100644
>> > --- a/drivers/remoteproc/remoteproc_elf_loader.c
>> > +++ b/drivers/remoteproc/remoteproc_elf_loader.c
>> > @@ -248,6 +248,9 @@ int rproc_elf_load_segments(struct rproc *rproc, const
>> > struct firmware *fw)
>> > memset(ptr + filesz, 0, memsz - filesz);
>> > }
>> >
>> > + if (ret == 0)
>> > + rproc->elf_class = class;
>> > +
>> > return ret;
>> > }
>> > EXPORT_SYMBOL(rproc_elf_load_segments);
>> > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
>> > index 1683d6c386a6..ed127b2d35ca 100644
>> > --- a/include/linux/remoteproc.h
>> > +++ b/include/linux/remoteproc.h
>> > @@ -514,6 +514,7 @@ struct rproc {
>> > bool auto_boot;
>> > struct list_head dump_segments;
>> > int nb_vdev;
>> > + u8 elf_class;
>> > };
>> >
>> > /**
>> > --
>> > 2.15.0.276.g89ea799
prev parent reply other threads:[~2020-03-10 8:12 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <04be3345-698d-29b0-7b4b-7eed088e490d@st.com>
2019-08-19 11:45 ` [PATCH] rproc: Add elf64 support in elf loader Clement Leger
2019-09-13 10:58 ` Clément Leger
2019-10-04 8:27 ` Clément Leger
2019-10-04 18:42 ` [PATCH v2] remoteproc: " Clement Leger
2020-01-09 9:31 ` Clément Leger
2020-01-24 0:53 ` Mathieu Poirier
2020-01-24 8:24 ` Clément Leger
2020-01-24 18:10 ` Mathieu Poirier
2020-01-24 21:58 ` Mathieu Poirier
2020-01-27 8:33 ` Clément Leger
2020-01-28 17:14 ` Mathieu Poirier
2020-01-29 8:55 ` Clément Leger
2020-01-29 16:30 ` Mathieu Poirier
2020-02-04 14:33 ` [PATCH v2 1/2] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-04 14:33 ` [PATCH v2 2/2] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-04 16:27 ` [PATCH v2 1/2] remoteproc: Use u64 len for da_to_va Arnaud POULIQUEN
2020-02-04 17:10 ` Clément Leger
2020-02-04 17:42 ` Arnaud POULIQUEN
2020-02-04 17:44 ` [PATCH v3 0/2] remoteproc: Add elf64 support to elf loader Clement Leger
2020-02-04 17:44 ` [PATCH v3 1/2] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-05 21:06 ` Mathieu Poirier
2020-02-04 17:44 ` [PATCH v3 2/2] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-05 22:49 ` Mathieu Poirier
2020-02-06 8:37 ` Clément Leger
2020-02-06 15:05 ` Clément Leger
2020-02-06 17:48 ` Mathieu Poirier
2020-02-07 7:57 ` Clément Leger
2020-02-10 16:22 ` [PATCH v4 0/5] remoteproc: Add elf64 support Clement Leger
2020-02-10 16:22 ` [PATCH v4 1/5] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-11 15:53 ` Arnaud POULIQUEN
2020-02-11 16:39 ` Clément Leger
2020-02-11 17:24 ` Arnaud POULIQUEN
2020-02-11 22:37 ` Mathieu Poirier
2020-02-12 10:37 ` Clément Leger
2020-02-12 21:59 ` Mathieu Poirier
2020-02-18 10:10 ` Clément Leger
2020-02-18 17:01 ` Mathieu Poirier
2020-02-10 16:22 ` [PATCH v4 2/5] remoteproc: Use u64 type for boot_addr Clement Leger
2020-02-10 16:22 ` [PATCH v4 3/5] remoteproc: Add elf helpers to access elf64 and elf32 fields Clement Leger
2020-02-10 16:22 ` [PATCH v4 4/5] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-10 16:22 ` [PATCH v4 5/5] remoteproc: Adapt coredump to generate correct elf type Clement Leger
2020-02-11 23:11 ` Mathieu Poirier
2020-02-11 15:57 ` [PATCH v4 0/5] remoteproc: Add elf64 support Arnaud POULIQUEN
2020-02-11 23:12 ` Mathieu Poirier
2020-02-12 8:15 ` Arnaud POULIQUEN
2020-03-02 9:38 ` [PATCH v5 0/8] " Clement Leger
2020-03-02 9:38 ` [PATCH v5 1/8] remoteproc: Use size_t type for len in da_to_va Clement Leger
2020-03-02 23:06 ` Bjorn Andersson
2020-03-09 17:52 ` Mathieu Poirier
2020-03-27 7:37 ` Oleksij Rempel
2020-03-02 9:38 ` [PATCH v5 2/8] remoteproc: Use size_t instead of int for rproc_mem_entry len Clement Leger
2020-03-02 23:07 ` Bjorn Andersson
2020-03-09 19:21 ` Mathieu Poirier
2020-03-02 9:38 ` [PATCH v5 3/8] remoteproc: Use u64 type for boot_addr Clement Leger
2020-03-02 23:08 ` Bjorn Andersson
2020-03-09 19:52 ` Mathieu Poirier
2020-03-10 7:59 ` Clément Leger
2020-03-10 19:32 ` Bjorn Andersson
2020-03-02 9:38 ` [PATCH v5 4/8] remoteproc: Add elf helpers to access elf64 and elf32 fields Clement Leger
2020-03-02 23:12 ` Bjorn Andersson
2020-03-09 19:56 ` Mathieu Poirier
2020-03-02 9:38 ` [PATCH v5 5/8] remoteproc: Rename rproc_elf_sanity_check for elf32 Clement Leger
2020-03-02 23:13 ` Bjorn Andersson
2020-03-03 8:02 ` Clément Leger
2020-03-10 0:00 ` Bjorn Andersson
2020-03-10 15:20 ` Mathieu Poirier
2020-03-10 15:38 ` Clément Leger
2020-03-10 19:18 ` Mathieu Poirier
2020-03-10 19:30 ` Bjorn Andersson
2020-03-02 9:39 ` [PATCH v5 6/8] remoteproc: Add elf64 support in elf loader Clement Leger
2020-03-02 9:39 ` [PATCH v5 7/8] remoteproc: Allow overriding only sanity_check Clement Leger
2020-03-02 9:39 ` [PATCH v5 8/8] remoteproc: Adapt coredump to generate correct elf type Clement Leger
2020-03-03 22:01 ` Bjorn Andersson
2020-03-09 20:32 ` Mathieu Poirier
2020-03-09 23:57 ` Bjorn Andersson
2020-03-10 8:12 ` Clément Leger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569234651.9042535.1583827964044.JavaMail.zimbra@kalray.eu \
--to=cleger@kalrayinc.com \
--cc=agross@kernel.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=s-anna@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).