linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Cl?ment Leger <cleger@kalrayinc.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Jonathan Corbet <corbet@lwn.net>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-remoteproc <linux-remoteproc@vger.kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Andy Gross <agross@kernel.org>,
	Patrice Chotard <patrice.chotard@st.com>,
	linux-doc <linux-doc@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Arnaud Pouliquen <arnaud.pouliquen@st.com>,
	Loic PALLARDY <loic.pallardy@st.com>, s-anna <s-anna@ti.com>
Subject: Re: [PATCH v5 5/8] remoteproc: Rename rproc_elf_sanity_check for elf32
Date: Tue, 10 Mar 2020 12:30:42 -0700	[thread overview]
Message-ID: <20200310193042.GK264362@yoga> (raw)
In-Reply-To: <371773363.9138477.1583854699708.JavaMail.zimbra@kalray.eu>

On Tue 10 Mar 08:38 PDT 2020, Cl?ment Leger wrote:

> Hi Mathieu,
> 
> ----- On 10 Mar, 2020, at 16:20, Mathieu Poirier mathieu.poirier@linaro.org wrote:
> 
> > On Mon, Mar 09, 2020 at 05:00:05PM -0700, Bjorn Andersson wrote:
> >> On Tue 03 Mar 00:02 PST 2020, Cl?ment Leger wrote:
> >> 
> >> > Hi Bjorn,
> >> > 
> >> > ----- On 3 Mar, 2020, at 00:13, Bjorn Andersson bjorn.andersson@linaro.org
> >> > wrote:
> >> > 
> >> > > On Mon 02 Mar 01:38 PST 2020, Clement Leger wrote:
> >> > > 
> >> > >> Since this function will be modified to support both elf32 and elf64,
> >> > >> rename the existing one to elf32 (which is the only supported format
> >> > >> at the moment). This will allow not to introduce possible side effect
> >> > >> when adding elf64 support (ie: all backends will still support only
> >> > >> elf32 if not requested explicitely using rproc_elf_sanity_check).
> >> > >> 
> >> > > 
> >> > > Is there a reason for preventing ELF64 binaries be loaded?
> >> > 
> >> > I decided to go this way to let driver maintainer decide if they want
> >> > to support elf64 to avoid problems with 64bits addresses/sizes which do
> >> > not fit in their native type (size_t for instance). This is probably
> >> > not going to happen and there are additionnal checks before calling
> >> > rproc_da_to_va. And addresses should be filtered by rproc_da_to_va.
> >> > So, actually it seems there is no reason to forbid supporting elf32/64
> >> > for all drivers.
> >> > 
> >> 
> >> I was hoping to hear some additional feedback on this from others.
> > 
> > I didn't follow up on this one because I agreed with your assesment and didn't
> > think it was needed.
> > 
> > Simply put I would rather see rproc_elf_sanity_check() gain support for elf64
> > and let the platform code decide what to do with format they don't support
> > rather than spinning a new function.
> > 
> >> 
> >> I've merge the patch as is, but think it would be nice to clean this up
> >> and just have the driver ignore if fed a 32 or 64-elf.
> > 
> > It would be really nice to see this cleaned up in time for the coming merge
> > window...
> 
> I could have sent a V7, but Bjorn was faster than my comment ;)

I figured it had been maturing on the list long enough and expected the
cleanup to be a nice incremental patch.

> Bjorn, Is there any way to revert that or it's already pushed ?
> I already have a clean V7.
> 

Please base your changes on what's in rproc-next (and today's
linux-next).

Thank you,
Bjorn

  parent reply	other threads:[~2020-03-10 19:30 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <04be3345-698d-29b0-7b4b-7eed088e490d@st.com>
2019-08-19 11:45 ` [PATCH] rproc: Add elf64 support in elf loader Clement Leger
2019-09-13 10:58   ` Clément Leger
2019-10-04  8:27     ` Clément Leger
2019-10-04 18:42   ` [PATCH v2] remoteproc: " Clement Leger
2020-01-09  9:31     ` Clément Leger
2020-01-24  0:53     ` Mathieu Poirier
2020-01-24  8:24       ` Clément Leger
2020-01-24 18:10         ` Mathieu Poirier
2020-01-24 21:58         ` Mathieu Poirier
2020-01-27  8:33           ` Clément Leger
2020-01-28 17:14             ` Mathieu Poirier
2020-01-29  8:55               ` Clément Leger
2020-01-29 16:30                 ` Mathieu Poirier
2020-02-04 14:33                   ` [PATCH v2 1/2] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-04 14:33                     ` [PATCH v2 2/2] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-04 16:27                     ` [PATCH v2 1/2] remoteproc: Use u64 len for da_to_va Arnaud POULIQUEN
2020-02-04 17:10                       ` Clément Leger
2020-02-04 17:42                         ` Arnaud POULIQUEN
2020-02-04 17:44                   ` [PATCH v3 0/2] remoteproc: Add elf64 support to elf loader Clement Leger
2020-02-04 17:44                     ` [PATCH v3 1/2] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-05 21:06                       ` Mathieu Poirier
2020-02-04 17:44                     ` [PATCH v3 2/2] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-05 22:49                       ` Mathieu Poirier
2020-02-06  8:37                         ` Clément Leger
2020-02-06 15:05                           ` Clément Leger
2020-02-06 17:48                             ` Mathieu Poirier
2020-02-07  7:57                               ` Clément Leger
2020-02-10 16:22                                 ` [PATCH v4 0/5] remoteproc: Add elf64 support Clement Leger
2020-02-10 16:22                                   ` [PATCH v4 1/5] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-11 15:53                                     ` Arnaud POULIQUEN
2020-02-11 16:39                                       ` Clément Leger
2020-02-11 17:24                                         ` Arnaud POULIQUEN
2020-02-11 22:37                                         ` Mathieu Poirier
2020-02-12 10:37                                           ` Clément Leger
2020-02-12 21:59                                             ` Mathieu Poirier
2020-02-18 10:10                                               ` Clément Leger
2020-02-18 17:01                                                 ` Mathieu Poirier
2020-02-10 16:22                                   ` [PATCH v4 2/5] remoteproc: Use u64 type for boot_addr Clement Leger
2020-02-10 16:22                                   ` [PATCH v4 3/5] remoteproc: Add elf helpers to access elf64 and elf32 fields Clement Leger
2020-02-10 16:22                                   ` [PATCH v4 4/5] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-10 16:22                                   ` [PATCH v4 5/5] remoteproc: Adapt coredump to generate correct elf type Clement Leger
2020-02-11 23:11                                     ` Mathieu Poirier
2020-02-11 15:57                                   ` [PATCH v4 0/5] remoteproc: Add elf64 support Arnaud POULIQUEN
2020-02-11 23:12                                     ` Mathieu Poirier
2020-02-12  8:15                                       ` Arnaud POULIQUEN
2020-03-02  9:38                                   ` [PATCH v5 0/8] " Clement Leger
2020-03-02  9:38                                     ` [PATCH v5 1/8] remoteproc: Use size_t type for len in da_to_va Clement Leger
2020-03-02 23:06                                       ` Bjorn Andersson
2020-03-09 17:52                                       ` Mathieu Poirier
2020-03-27  7:37                                       ` Oleksij Rempel
2020-03-02  9:38                                     ` [PATCH v5 2/8] remoteproc: Use size_t instead of int for rproc_mem_entry len Clement Leger
2020-03-02 23:07                                       ` Bjorn Andersson
2020-03-09 19:21                                       ` Mathieu Poirier
2020-03-02  9:38                                     ` [PATCH v5 3/8] remoteproc: Use u64 type for boot_addr Clement Leger
2020-03-02 23:08                                       ` Bjorn Andersson
2020-03-09 19:52                                       ` Mathieu Poirier
2020-03-10  7:59                                         ` Clément Leger
2020-03-10 19:32                                           ` Bjorn Andersson
2020-03-02  9:38                                     ` [PATCH v5 4/8] remoteproc: Add elf helpers to access elf64 and elf32 fields Clement Leger
2020-03-02 23:12                                       ` Bjorn Andersson
2020-03-09 19:56                                       ` Mathieu Poirier
2020-03-02  9:38                                     ` [PATCH v5 5/8] remoteproc: Rename rproc_elf_sanity_check for elf32 Clement Leger
2020-03-02 23:13                                       ` Bjorn Andersson
2020-03-03  8:02                                         ` Clément Leger
2020-03-10  0:00                                           ` Bjorn Andersson
2020-03-10 15:20                                             ` Mathieu Poirier
2020-03-10 15:38                                               ` Clément Leger
2020-03-10 19:18                                                 ` Mathieu Poirier
2020-03-10 19:30                                                 ` Bjorn Andersson [this message]
2020-03-02  9:39                                     ` [PATCH v5 6/8] remoteproc: Add elf64 support in elf loader Clement Leger
2020-03-02  9:39                                     ` [PATCH v5 7/8] remoteproc: Allow overriding only sanity_check Clement Leger
2020-03-02  9:39                                     ` [PATCH v5 8/8] remoteproc: Adapt coredump to generate correct elf type Clement Leger
2020-03-03 22:01                                       ` Bjorn Andersson
2020-03-09 20:32                                       ` Mathieu Poirier
2020-03-09 23:57                                         ` Bjorn Andersson
2020-03-10  8:12                                           ` Clément Leger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310193042.GK264362@yoga \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=cleger@kalrayinc.com \
    --cc=corbet@lwn.net \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=loic.pallardy@st.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=patrice.chotard@st.com \
    --cc=s-anna@ti.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).