* [PATCH] remoteproc: debug: Remove unneeded NULL check
@ 2019-09-24 2:58 Ding Xiang
2019-10-05 4:12 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-09-24 2:58 UTC (permalink / raw)
To: ohad, bjorn.andersson; +Cc: linux-remoteproc, linux-kernel
debugfs_remove_recursive will do NULL check, so remove
the redundant null check
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/remoteproc/remoteproc_debugfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 8cd4a0a..dd93cf0 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -333,9 +333,6 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,
void rproc_delete_debug_dir(struct rproc *rproc)
{
- if (!rproc->dbg_dir)
- return;
-
debugfs_remove_recursive(rproc->dbg_dir);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remoteproc: debug: Remove unneeded NULL check
2019-09-24 2:58 [PATCH] remoteproc: debug: Remove unneeded NULL check Ding Xiang
@ 2019-10-05 4:12 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-10-05 4:12 UTC (permalink / raw)
To: Ding Xiang; +Cc: ohad, linux-remoteproc, linux-kernel
On Mon 23 Sep 19:58 PDT 2019, Ding Xiang wrote:
> debugfs_remove_recursive will do NULL check, so remove
> the redundant null check
>
Nice, applied.
Regards,
Bjorn
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/remoteproc/remoteproc_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index 8cd4a0a..dd93cf0 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -333,9 +333,6 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,
>
> void rproc_delete_debug_dir(struct rproc *rproc)
> {
> - if (!rproc->dbg_dir)
> - return;
> -
> debugfs_remove_recursive(rproc->dbg_dir);
> }
>
> --
> 1.9.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-05 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 2:58 [PATCH] remoteproc: debug: Remove unneeded NULL check Ding Xiang
2019-10-05 4:12 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).