* [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
@ 2020-02-06 13:55 Kiran Gunda
2020-02-06 13:55 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
2020-02-06 19:06 ` [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Stephen Boyd
0 siblings, 2 replies; 11+ messages in thread
From: Kiran Gunda @ 2020-02-06 13:55 UTC (permalink / raw)
To: swboyd, linux-arm-msm, linux-kernel, Andy Gross, Bjorn Andersson,
Lee Jones, Rob Herring, Mark Rutland, devicetree
Cc: rnayak, Kiran Gunda
Convert the bindings from .txt to .yaml format.
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 --------------
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 115 +++++++++++++++++++++
2 files changed, 115 insertions(+), 80 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
deleted file mode 100644
index fffc8fd..0000000
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
+++ /dev/null
@@ -1,80 +0,0 @@
- Qualcomm SPMI PMICs multi-function device bindings
-
-The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084
-PMICs. These PMICs use a QPNP scheme through SPMI interface.
-QPNP is effectively a partitioning scheme for dividing the SPMI extended
-register space up into logical pieces, and set of fixed register
-locations/definitions within these regions, with some of these regions
-specifically used for interrupt handling.
-
-The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are
-interfaced to the chip via the SPMI (System Power Management Interface) bus.
-Support for multiple independent functions are implemented by splitting the
-16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
-each. A function can consume one or more of these fixed-size register regions.
-
-Required properties:
-- compatible: Should contain one of:
- "qcom,pm8941",
- "qcom,pm8841",
- "qcom,pma8084",
- "qcom,pm8019",
- "qcom,pm8226",
- "qcom,pm8110",
- "qcom,pma8084",
- "qcom,pmi8962",
- "qcom,pmd9635",
- "qcom,pm8994",
- "qcom,pmi8994",
- "qcom,pm8916",
- "qcom,pm8004",
- "qcom,pm8909",
- "qcom,pm8950",
- "qcom,pmi8950",
- "qcom,pm8998",
- "qcom,pmi8998",
- "qcom,pm8005",
- or generalized "qcom,spmi-pmic".
-- reg: Specifies the SPMI USID slave address for this device.
- For more information see:
- Documentation/devicetree/bindings/spmi/spmi.txt
-
-Required properties for peripheral child nodes:
-- compatible: Should contain "qcom,xxx", where "xxx" is a peripheral name.
-
-Optional properties for peripheral child nodes:
-- interrupts: Interrupts are specified as a 4-tuple. For more information
- see:
- Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
-- interrupt-names: Corresponding interrupt name to the interrupts property
-
-Each child node of SPMI slave id represents a function of the PMIC. In the
-example below the rtc device node represents a peripheral of pm8941
-SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1.
-
-Example:
-
- spmi {
- compatible = "qcom,spmi-pmic-arb";
-
- pm8941@0 {
- compatible = "qcom,pm8941", "qcom,spmi-pmic";
- reg = <0x0 SPMI_USID>;
-
- rtc {
- compatible = "qcom,rtc";
- interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
- interrupt-names = "alarm";
- };
- };
-
- pm8941@1 {
- compatible = "qcom,pm8941", "qcom,spmi-pmic";
- reg = <0x1 SPMI_USID>;
-
- regulator {
- compatible = "qcom,regulator";
- regulator-name = "8941_boost";
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
new file mode 100644
index 0000000..affc169
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -0,0 +1,115 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bindings/mfd/qcom,spmi-pmic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm SPMI PMICs multi-function device bindings
+
+maintainers:
+ - Lee Jones <lee.jones@linaro.org>
+ - Stephen Boyd <sboyd@codeaurora.org>
+
+description: |
+ The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084
+ PMICs. These PMICs use a QPNP scheme through SPMI interface.
+ QPNP is effectively a partitioning scheme for dividing the SPMI extended
+ register space up into logical pieces, and set of fixed register
+ locations/definitions within these regions, with some of these regions
+ specifically used for interrupt handling.
+
+ The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are
+ interfaced to the chip via the SPMI (System Power Management Interface) bus.
+ Support for multiple independent functions are implemented by splitting the
+ 16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
+ each. A function can consume one or more of these fixed-size register regions.
+
+properties:
+ compatible:
+ enum:
+ - qcom,pm8941
+ - qcom,pm8841
+ - qcom,pma8084
+ - qcom,pm8019
+ - qcom,pm8226
+ - qcom,pm8110
+ - qcom,pma8084
+ - qcom,pmi8962
+ - qcom,pmd9635
+ - qcom,pm8994
+ - qcom,pmi8994
+ - qcom,pm8916
+ - qcom,pm8004
+ - qcom,pm8909
+ - qcom,pm8950
+ - qcom,pmi8950
+ - qcom,pm8998
+ - qcom,pmi8998
+ - qcom,pm8005
+ - qcom,spmi-pmic
+
+ reg:
+ maxItems: 1
+ description:
+ Specifies the SPMI USID slave address for this device.
+ For more information see Documentation/devicetree/bindings/spmi/spmi.txt
+
+patternProperties:
+ "^.*@[0-9a-f]+$":
+ type: object
+ description:
+ Each child node of SPMI slave id represents a function of the PMIC. In the
+ example below the rtc device node represents a peripheral of pm8941
+ SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1.
+
+ properties:
+ compatible:
+ description:
+ Compatible of the PMIC device.
+
+ interrupts:
+ maxItems: 2
+ description:
+ Interrupts are specified as a 4-tuple. For more information
+ see Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
+
+ interrupt-names:
+ description:
+ Corresponding interrupt name to the interrupts property
+
+ required:
+ - compatible
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ spmi {
+ compatible = "qcom,spmi-pmic-arb";
+ #address-cells = <2>;
+ #size-cells = <0>;
+
+ pm8941@0 {
+ compatible = "qcom,pm8941";
+ reg = <0x0 0x0>;
+
+ rtc {
+ compatible = "qcom,rtc";
+ interrupts = <0x0 0x61 0x1 0x1>;
+ interrupt-names = "alarm";
+ };
+ };
+
+ pm8941@1 {
+ compatible = "qcom,pm8941";
+ reg = <0x1 0x0>;
+
+ regulator {
+ compatible = "qcom,regulator";
+ regulator-name = "8941_boost";
+ };
+ };
+ };
+...
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
2020-02-06 13:55 [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Kiran Gunda
@ 2020-02-06 13:55 ` Kiran Gunda
2020-02-06 19:08 ` Stephen Boyd
2020-02-06 19:06 ` [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Stephen Boyd
1 sibling, 1 reply; 11+ messages in thread
From: Kiran Gunda @ 2020-02-06 13:55 UTC (permalink / raw)
To: swboyd, linux-arm-msm, linux-kernel, Andy Gross, Bjorn Andersson,
Lee Jones, Rob Herring, Mark Rutland, devicetree
Cc: rnayak, Kiran Gunda
Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
found on SC7180 based platforms
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
drivers/mfd/qcom-spmi-pmic.c | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index affc169..36f0795 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -46,6 +46,8 @@ properties:
- qcom,pm8998
- qcom,pmi8998
- qcom,pm8005
+ - qcom,pm6150
+ - qcom,pm6150l
- qcom,spmi-pmic
reg:
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
index 1df1a27..5bfeec8 100644
--- a/drivers/mfd/qcom-spmi-pmic.c
+++ b/drivers/mfd/qcom-spmi-pmic.c
@@ -36,6 +36,8 @@
#define PM8998_SUBTYPE 0x14
#define PMI8998_SUBTYPE 0x15
#define PM8005_SUBTYPE 0x18
+#define PM6150L_SUBTYPE 0x1F
+#define PM6150_SUBTYPE 0x28
static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
@@ -57,6 +59,8 @@ static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE },
{ .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
{ .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
+ { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE },
+ { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE },
{ }
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
2020-02-06 13:55 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
@ 2020-02-06 19:08 ` Stephen Boyd
2020-02-07 5:59 ` kgunda
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2020-02-06 19:08 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Kiran Gunda, Lee Jones,
Mark Rutland, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
Cc: rnayak, Kiran Gunda
Quoting Kiran Gunda (2020-02-06 05:55:27)
> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
> found on SC7180 based platforms
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index affc169..36f0795 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -46,6 +46,8 @@ properties:
> - qcom,pm8998
> - qcom,pmi8998
> - qcom,pm8005
> + - qcom,pm6150
> + - qcom,pm6150l
> - qcom,spmi-pmic
Maybe the yaml binding needs to say this is sorted in subtype id in a
comment.
# Sorted based on subtype ID the device reports
Or we should sort this list in the binding and sort the compatible
string table in the driver with a comment that it's sorted based on
subtype id.
>
> reg:
> diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
> index 1df1a27..5bfeec8 100644
> --- a/drivers/mfd/qcom-spmi-pmic.c
> +++ b/drivers/mfd/qcom-spmi-pmic.c
> @@ -36,6 +36,8 @@
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> +#define PM6150L_SUBTYPE 0x1F
> +#define PM6150_SUBTYPE 0x28
>
> static const struct of_device_id pmic_spmi_id_table[] = {
> { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
> @@ -57,6 +59,8 @@ static const struct of_device_id pmic_spmi_id_table[] = {
> { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE },
> { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
> { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
> + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE },
> + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE },
> { }
> };
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
2020-02-06 19:08 ` Stephen Boyd
@ 2020-02-07 5:59 ` kgunda
0 siblings, 0 replies; 11+ messages in thread
From: kgunda @ 2020-02-07 5:59 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, Lee Jones, Mark Rutland,
Rob Herring, devicetree, linux-arm-msm, linux-kernel, rnayak,
linux-arm-msm-owner
On 2020-02-07 00:38, Stephen Boyd wrote:
> Quoting Kiran Gunda (2020-02-06 05:55:27)
>> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
>> found on SC7180 based platforms
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
>> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> index affc169..36f0795 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> @@ -46,6 +46,8 @@ properties:
>> - qcom,pm8998
>> - qcom,pmi8998
>> - qcom,pm8005
>> + - qcom,pm6150
>> + - qcom,pm6150l
>> - qcom,spmi-pmic
>
> Maybe the yaml binding needs to say this is sorted in subtype id in a
> comment.
>
> # Sorted based on subtype ID the device reports
>
Ok.. I will add it in next post.
> Or we should sort this list in the binding and sort the compatible
> string table in the driver with a comment that it's sorted based on
> subtype id.
>
>>
>> reg:
>> diff --git a/drivers/mfd/qcom-spmi-pmic.c
>> b/drivers/mfd/qcom-spmi-pmic.c
>> index 1df1a27..5bfeec8 100644
>> --- a/drivers/mfd/qcom-spmi-pmic.c
>> +++ b/drivers/mfd/qcom-spmi-pmic.c
>> @@ -36,6 +36,8 @@
>> #define PM8998_SUBTYPE 0x14
>> #define PMI8998_SUBTYPE 0x15
>> #define PM8005_SUBTYPE 0x18
>> +#define PM6150L_SUBTYPE 0x1F
>> +#define PM6150_SUBTYPE 0x28
>>
>> static const struct of_device_id pmic_spmi_id_table[] = {
>> { .compatible = "qcom,spmi-pmic", .data = (void
>> *)COMMON_SUBTYPE },
>> @@ -57,6 +59,8 @@ static const struct of_device_id
>> pmic_spmi_id_table[] = {
>> { .compatible = "qcom,pm8998", .data = (void
>> *)PM8998_SUBTYPE },
>> { .compatible = "qcom,pmi8998", .data = (void
>> *)PMI8998_SUBTYPE },
>> { .compatible = "qcom,pm8005", .data = (void
>> *)PM8005_SUBTYPE },
>> + { .compatible = "qcom,pm6150l", .data = (void
>> *)PM6150L_SUBTYPE },
>> + { .compatible = "qcom,pm6150", .data = (void
>> *)PM6150_SUBTYPE },
>> { }
>> };
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
2020-02-06 13:55 [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Kiran Gunda
2020-02-06 13:55 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
@ 2020-02-06 19:06 ` Stephen Boyd
2020-02-06 22:06 ` Rob Herring
2020-02-07 5:57 ` kgunda
1 sibling, 2 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-02-06 19:06 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Kiran Gunda, Lee Jones,
Mark Rutland, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
Cc: rnayak, Kiran Gunda
Quoting Kiran Gunda (2020-02-06 05:55:26)
> Convert the bindings from .txt to .yaml format.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
Did something change? Is there a cover letter?
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> new file mode 100644
> index 0000000..affc169
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -0,0 +1,115 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/mfd/qcom,spmi-pmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SPMI PMICs multi-function device bindings
> +
> +maintainers:
> + - Lee Jones <lee.jones@linaro.org>
> + - Stephen Boyd <sboyd@codeaurora.org>
Please change this to sboyd@kernel.org
> +
> +description: |
> + The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084
> + PMICs. These PMICs use a QPNP scheme through SPMI interface.
This first sentence will need continual updating. Please drop it.
> + QPNP is effectively a partitioning scheme for dividing the SPMI extended
> + register space up into logical pieces, and set of fixed register
> + locations/definitions within these regions, with some of these regions
> + specifically used for interrupt handling.
> +
> + The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are
> + interfaced to the chip via the SPMI (System Power Management Interface) bus.
> + Support for multiple independent functions are implemented by splitting the
> + 16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
> + each. A function can consume one or more of these fixed-size register regions.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pm8941
> + - qcom,pm8841
> + - qcom,pma8084
> + - qcom,pm8019
> + - qcom,pm8226
> + - qcom,pm8110
> + - qcom,pma8084
> + - qcom,pmi8962
> + - qcom,pmd9635
> + - qcom,pm8994
> + - qcom,pmi8994
> + - qcom,pm8916
> + - qcom,pm8004
> + - qcom,pm8909
> + - qcom,pm8950
> + - qcom,pmi8950
> + - qcom,pm8998
> + - qcom,pmi8998
> + - qcom,pm8005
> + - qcom,spmi-pmic
I think we want qcom,spmi-pmic to be there always. To do that we need it
to look like:
compatible:
items:
enum:
- qcom,pm8941
...
enum:
- qcom,spmi-pmic
> +
> + reg:
> + maxItems: 1
> + description:
> + Specifies the SPMI USID slave address for this device.
> + For more information see Documentation/devicetree/bindings/spmi/spmi.txt
> +
> +patternProperties:
> + "^.*@[0-9a-f]+$":
> + type: object
> + description:
> + Each child node of SPMI slave id represents a function of the PMIC. In the
> + example below the rtc device node represents a peripheral of pm8941
> + SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1.
> +
> + properties:
> + compatible:
> + description:
> + Compatible of the PMIC device.
> +
> + interrupts:
> + maxItems: 2
> + description:
> + Interrupts are specified as a 4-tuple. For more information
> + see Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
Just make this bindings/spmi/qcom,spmi-pmic-arb.txt so that we don't
have to worry about it. Why is max items 2? Isn't it 4? Is this property
supposed to be specified at all?
> +
> + interrupt-names:
> + description:
> + Corresponding interrupt name to the interrupts property
Does this need to be specified either?
> +
> + required:
> + - compatible
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + spmi {
> + compatible = "qcom,spmi-pmic-arb";
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + pm8941@0 {
pmic@0
> + compatible = "qcom,pm8941";
> + reg = <0x0 0x0>;
Why not include the header file to get the SPMI_USID macro?
> +
> + rtc {
> + compatible = "qcom,rtc";
> + interrupts = <0x0 0x61 0x1 0x1>;
> + interrupt-names = "alarm";
> + };
> + };
> +
> + pm8941@1 {
pmic@1
> + compatible = "qcom,pm8941";
> + reg = <0x1 0x0>;
> +
> + regulator {
> + compatible = "qcom,regulator";
> + regulator-name = "8941_boost";
> + };
> + };
> + };
> +...
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
2020-02-06 19:06 ` [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Stephen Boyd
@ 2020-02-06 22:06 ` Rob Herring
2020-02-07 6:46 ` kgunda
2020-02-07 5:57 ` kgunda
1 sibling, 1 reply; 11+ messages in thread
From: Rob Herring @ 2020-02-06 22:06 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, Kiran Gunda, Lee Jones,
Mark Rutland, devicetree, linux-arm-msm, linux-kernel, rnayak
On Thu, Feb 06, 2020 at 11:06:55AM -0800, Stephen Boyd wrote:
> Quoting Kiran Gunda (2020-02-06 05:55:26)
> > Convert the bindings from .txt to .yaml format.
> >
> > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> > ---
>
> Did something change? Is there a cover letter?
>
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > new file mode 100644
> > index 0000000..affc169
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > @@ -0,0 +1,115 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/bindings/mfd/qcom,spmi-pmic.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm SPMI PMICs multi-function device bindings
> > +
> > +maintainers:
> > + - Lee Jones <lee.jones@linaro.org>
> > + - Stephen Boyd <sboyd@codeaurora.org>
>
> Please change this to sboyd@kernel.org
Should be the h/w owner, not applier of changes.
>
> > +
> > +description: |
> > + The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084
> > + PMICs. These PMICs use a QPNP scheme through SPMI interface.
>
> This first sentence will need continual updating. Please drop it.
>
> > + QPNP is effectively a partitioning scheme for dividing the SPMI extended
> > + register space up into logical pieces, and set of fixed register
> > + locations/definitions within these regions, with some of these regions
> > + specifically used for interrupt handling.
> > +
> > + The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are
> > + interfaced to the chip via the SPMI (System Power Management Interface) bus.
> > + Support for multiple independent functions are implemented by splitting the
> > + 16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
> > + each. A function can consume one or more of these fixed-size register regions.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - qcom,pm8941
> > + - qcom,pm8841
> > + - qcom,pma8084
> > + - qcom,pm8019
> > + - qcom,pm8226
> > + - qcom,pm8110
> > + - qcom,pma8084
> > + - qcom,pmi8962
> > + - qcom,pmd9635
> > + - qcom,pm8994
> > + - qcom,pmi8994
> > + - qcom,pm8916
> > + - qcom,pm8004
> > + - qcom,pm8909
> > + - qcom,pm8950
> > + - qcom,pmi8950
> > + - qcom,pm8998
> > + - qcom,pmi8998
> > + - qcom,pm8005
> > + - qcom,spmi-pmic
>
> I think we want qcom,spmi-pmic to be there always. To do that we need it
> to look like:
>
> compatible:
> items:
> enum:
> - qcom,pm8941
> ...
> enum:
> - qcom,spmi-pmic
Yes, but missing '-' before the enum's.
>
> > +
> > + reg:
> > + maxItems: 1
> > + description:
> > + Specifies the SPMI USID slave address for this device.
> > + For more information see Documentation/devicetree/bindings/spmi/spmi.txt
> > +
> > +patternProperties:
> > + "^.*@[0-9a-f]+$":
You are going to need to define the specific child nodes with the
schemas for them, but a SPMI bus schema may be useful.
> > + type: object
> > + description:
> > + Each child node of SPMI slave id represents a function of the PMIC. In the
> > + example below the rtc device node represents a peripheral of pm8941
> > + SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1.
> > +
> > + properties:
> > + compatible:
> > + description:
> > + Compatible of the PMIC device.
> > +
> > + interrupts:
> > + maxItems: 2
> > + description:
> > + Interrupts are specified as a 4-tuple. For more information
> > + see Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>
> Just make this bindings/spmi/qcom,spmi-pmic-arb.txt so that we don't
> have to worry about it. Why is max items 2? Isn't it 4? Is this property
> supposed to be specified at all?
>
> > +
> > + interrupt-names:
> > + description:
> > + Corresponding interrupt name to the interrupts property
>
> Does this need to be specified either?
>
> > +
> > + required:
> > + - compatible
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + spmi {
> > + compatible = "qcom,spmi-pmic-arb";
> > + #address-cells = <2>;
> > + #size-cells = <0>;
> > +
> > + pm8941@0 {
>
> pmic@0
>
> > + compatible = "qcom,pm8941";
> > + reg = <0x0 0x0>;
>
> Why not include the header file to get the SPMI_USID macro?
>
> > +
> > + rtc {
> > + compatible = "qcom,rtc";
> > + interrupts = <0x0 0x61 0x1 0x1>;
> > + interrupt-names = "alarm";
> > + };
> > + };
> > +
> > + pm8941@1 {
>
> pmic@1
>
> > + compatible = "qcom,pm8941";
> > + reg = <0x1 0x0>;
> > +
> > + regulator {
> > + compatible = "qcom,regulator";
> > + regulator-name = "8941_boost";
> > + };
> > + };
> > + };
> > +...
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
2020-02-06 22:06 ` Rob Herring
@ 2020-02-07 6:46 ` kgunda
0 siblings, 0 replies; 11+ messages in thread
From: kgunda @ 2020-02-07 6:46 UTC (permalink / raw)
To: Rob Herring
Cc: Stephen Boyd, Andy Gross, Bjorn Andersson, Lee Jones,
Mark Rutland, devicetree, linux-arm-msm, linux-kernel, rnayak,
linux-arm-msm-owner
On 2020-02-07 03:36, Rob Herring wrote:
> On Thu, Feb 06, 2020 at 11:06:55AM -0800, Stephen Boyd wrote:
>> Quoting Kiran Gunda (2020-02-06 05:55:26)
>> > Convert the bindings from .txt to .yaml format.
>> >
>> > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> > ---
>>
>> Did something change? Is there a cover letter?
>>
>> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> > new file mode 100644
>> > index 0000000..affc169
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> > @@ -0,0 +1,115 @@
>> > +# SPDX-License-Identifier: GPL-2.0-only
>> > +%YAML 1.2
>> > +---
>> > +$id: http://devicetree.org/schemas/bindings/mfd/qcom,spmi-pmic.yaml#
>> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> > +
>> > +title: Qualcomm SPMI PMICs multi-function device bindings
>> > +
>> > +maintainers:
>> > + - Lee Jones <lee.jones@linaro.org>
>> > + - Stephen Boyd <sboyd@codeaurora.org>
>>
>> Please change this to sboyd@kernel.org
>
> Should be the h/w owner, not applier of changes.
>
Ok.. I will remove it in next post.
>>
>> > +
>> > +description: |
>> > + The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084
>> > + PMICs. These PMICs use a QPNP scheme through SPMI interface.
>>
>> This first sentence will need continual updating. Please drop it.
>>
>> > + QPNP is effectively a partitioning scheme for dividing the SPMI extended
>> > + register space up into logical pieces, and set of fixed register
>> > + locations/definitions within these regions, with some of these regions
>> > + specifically used for interrupt handling.
>> > +
>> > + The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are
>> > + interfaced to the chip via the SPMI (System Power Management Interface) bus.
>> > + Support for multiple independent functions are implemented by splitting the
>> > + 16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
>> > + each. A function can consume one or more of these fixed-size register regions.
>> > +
>> > +properties:
>> > + compatible:
>> > + enum:
>> > + - qcom,pm8941
>> > + - qcom,pm8841
>> > + - qcom,pma8084
>> > + - qcom,pm8019
>> > + - qcom,pm8226
>> > + - qcom,pm8110
>> > + - qcom,pma8084
>> > + - qcom,pmi8962
>> > + - qcom,pmd9635
>> > + - qcom,pm8994
>> > + - qcom,pmi8994
>> > + - qcom,pm8916
>> > + - qcom,pm8004
>> > + - qcom,pm8909
>> > + - qcom,pm8950
>> > + - qcom,pmi8950
>> > + - qcom,pm8998
>> > + - qcom,pmi8998
>> > + - qcom,pm8005
>> > + - qcom,spmi-pmic
>>
>> I think we want qcom,spmi-pmic to be there always. To do that we need
>> it
>> to look like:
>>
>> compatible:
>> items:
>> enum:
>> - qcom,pm8941
>> ...
>> enum:
>> - qcom,spmi-pmic
>
> Yes, but missing '-' before the enum's.
>
Will add it in next post
>>
>> > +
>> > + reg:
>> > + maxItems: 1
>> > + description:
>> > + Specifies the SPMI USID slave address for this device.
>> > + For more information see Documentation/devicetree/bindings/spmi/spmi.txt
>> > +
>> > +patternProperties:
>> > + "^.*@[0-9a-f]+$":
>
> You are going to need to define the specific child nodes with the
> schemas for them, but a SPMI bus schema may be useful.
>
Ok.. I will add it in next post.
>> > + type: object
>> > + description:
>> > + Each child node of SPMI slave id represents a function of the PMIC. In the
>> > + example below the rtc device node represents a peripheral of pm8941
>> > + SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1.
>> > +
>> > + properties:
>> > + compatible:
>> > + description:
>> > + Compatible of the PMIC device.
>> > +
>> > + interrupts:
>> > + maxItems: 2
>> > + description:
>> > + Interrupts are specified as a 4-tuple. For more information
>> > + see Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>>
>> Just make this bindings/spmi/qcom,spmi-pmic-arb.txt so that we don't
>> have to worry about it. Why is max items 2? Isn't it 4? Is this
>> property
>> supposed to be specified at all?
>>
>> > +
>> > + interrupt-names:
>> > + description:
>> > + Corresponding interrupt name to the interrupts property
>>
>> Does this need to be specified either?
>>
>> > +
>> > + required:
>> > + - compatible
>> > +
>> > +required:
>> > + - compatible
>> > + - reg
>> > +
>> > +examples:
>> > + - |
>> > + spmi {
>> > + compatible = "qcom,spmi-pmic-arb";
>> > + #address-cells = <2>;
>> > + #size-cells = <0>;
>> > +
>> > + pm8941@0 {
>>
>> pmic@0
>>
>> > + compatible = "qcom,pm8941";
>> > + reg = <0x0 0x0>;
>>
>> Why not include the header file to get the SPMI_USID macro?
>>
>> > +
>> > + rtc {
>> > + compatible = "qcom,rtc";
>> > + interrupts = <0x0 0x61 0x1 0x1>;
>> > + interrupt-names = "alarm";
>> > + };
>> > + };
>> > +
>> > + pm8941@1 {
>>
>> pmic@1
>>
>> > + compatible = "qcom,pm8941";
>> > + reg = <0x1 0x0>;
>> > +
>> > + regulator {
>> > + compatible = "qcom,regulator";
>> > + regulator-name = "8941_boost";
>> > + };
>> > + };
>> > + };
>> > +...
>> > --
>> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> > a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
2020-02-06 19:06 ` [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Stephen Boyd
2020-02-06 22:06 ` Rob Herring
@ 2020-02-07 5:57 ` kgunda
2020-10-02 21:45 ` Stephen Boyd
1 sibling, 1 reply; 11+ messages in thread
From: kgunda @ 2020-02-07 5:57 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, Lee Jones, Mark Rutland,
Rob Herring, devicetree, linux-arm-msm, linux-kernel, rnayak,
linux-arm-msm-owner
On 2020-02-07 00:36, Stephen Boyd wrote:
> Quoting Kiran Gunda (2020-02-06 05:55:26)
>> Convert the bindings from .txt to .yaml format.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>
> Did something change? Is there a cover letter?
>
Other than converting the bindings to .yaml not much changed from the
previous post.
I will log the per patch changes in next post.
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> new file mode 100644
>> index 0000000..affc169
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> @@ -0,0 +1,115 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/bindings/mfd/qcom,spmi-pmic.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm SPMI PMICs multi-function device bindings
>> +
>> +maintainers:
>> + - Lee Jones <lee.jones@linaro.org>
>> + - Stephen Boyd <sboyd@codeaurora.org>
>
> Please change this to sboyd@kernel.org
>
Sorry for that. I will change it in next post.
>> +
>> +description: |
>> + The Qualcomm SPMI series presently includes PM8941, PM8841 and
>> PMA8084
>> + PMICs. These PMICs use a QPNP scheme through SPMI interface.
>
> This first sentence will need continual updating. Please drop it.
>
Sure. Will do it in next post.
>> + QPNP is effectively a partitioning scheme for dividing the SPMI
>> extended
>> + register space up into logical pieces, and set of fixed register
>> + locations/definitions within these regions, with some of these
>> regions
>> + specifically used for interrupt handling.
>> +
>> + The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs,
>> and are
>> + interfaced to the chip via the SPMI (System Power Management
>> Interface) bus.
>> + Support for multiple independent functions are implemented by
>> splitting the
>> + 16-bit SPMI slave address space into 256 smaller fixed-size
>> regions, 256 bytes
>> + each. A function can consume one or more of these fixed-size
>> register regions.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,pm8941
>> + - qcom,pm8841
>> + - qcom,pma8084
>> + - qcom,pm8019
>> + - qcom,pm8226
>> + - qcom,pm8110
>> + - qcom,pma8084
>> + - qcom,pmi8962
>> + - qcom,pmd9635
>> + - qcom,pm8994
>> + - qcom,pmi8994
>> + - qcom,pm8916
>> + - qcom,pm8004
>> + - qcom,pm8909
>> + - qcom,pm8950
>> + - qcom,pmi8950
>> + - qcom,pm8998
>> + - qcom,pmi8998
>> + - qcom,pm8005
>> + - qcom,spmi-pmic
>
> I think we want qcom,spmi-pmic to be there always. To do that we need
> it
> to look like:
>
> compatible:
> items:
> enum:
> - qcom,pm8941
> ...
> enum:
> - qcom,spmi-pmic
>
Ok.. I will do it next post.
>> +
>> + reg:
>> + maxItems: 1
>> + description:
>> + Specifies the SPMI USID slave address for this device.
>> + For more information see
>> Documentation/devicetree/bindings/spmi/spmi.txt
>> +
>> +patternProperties:
>> + "^.*@[0-9a-f]+$":
>> + type: object
>> + description:
>> + Each child node of SPMI slave id represents a function of the
>> PMIC. In the
>> + example below the rtc device node represents a peripheral of
>> pm8941
>> + SID = 0. The regulator device node represents a peripheral of
>> pm8941 SID = 1.
>> +
>> + properties:
>> + compatible:
>> + description:
>> + Compatible of the PMIC device.
>> +
>> + interrupts:
>> + maxItems: 2
>> + description:
>> + Interrupts are specified as a 4-tuple. For more information
>> + see
>> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>
> Just make this bindings/spmi/qcom,spmi-pmic-arb.txt so that we don't
> have to worry about it.
Ok. Will do it in next post.
Why is max items 2? Isn't it 4?
Correct. It should be 4. I will correct it.
Is this property
> supposed to be specified at all?
>
The interrupts are used by many of the PMIC devices. I think better to
mention it.
>> +
>> + interrupt-names:
>> + description:
>> + Corresponding interrupt name to the interrupts property
>
> Does this need to be specified either?
>
The interrupts are used by many of the PMIC devices. I think better to
mention it.
>> +
>> + required:
>> + - compatible
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +examples:
>> + - |
>> + spmi {
>> + compatible = "qcom,spmi-pmic-arb";
>> + #address-cells = <2>;
>> + #size-cells = <0>;
>> +
>> + pm8941@0 {
>
> pmic@0
>
Ok. Will address in next series.
>> + compatible = "qcom,pm8941";
>> + reg = <0x0 0x0>;
>
> Why not include the header file to get the SPMI_USID macro?
>
Ok. I will include it in next post.
>> +
>> + rtc {
>> + compatible = "qcom,rtc";
>> + interrupts = <0x0 0x61 0x1 0x1>;
>> + interrupt-names = "alarm";
>> + };
>> + };
>> +
>> + pm8941@1 {
>
> pmic@1
>
Ok. Will address in next series.
>> + compatible = "qcom,pm8941";
>> + reg = <0x1 0x0>;
>> +
>> + regulator {
>> + compatible = "qcom,regulator";
>> + regulator-name = "8941_boost";
>> + };
>> + };
>> + };
>> +...
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
2020-02-07 5:57 ` kgunda
@ 2020-10-02 21:45 ` Stephen Boyd
2020-10-21 15:09 ` kgunda
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2020-10-02 21:45 UTC (permalink / raw)
To: kgunda
Cc: Andy Gross, Bjorn Andersson, Lee Jones, Mark Rutland,
Rob Herring, devicetree, linux-arm-msm, linux-kernel, rnayak,
linux-arm-msm-owner
Quoting kgunda@codeaurora.org (2020-02-06 21:57:49)
> On 2020-02-07 00:36, Stephen Boyd wrote:
> > Quoting Kiran Gunda (2020-02-06 05:55:26)
> >> Convert the bindings from .txt to .yaml format.
> >>
> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> >> ---
> >
> > Did something change? Is there a cover letter?
> >
> Other than converting the bindings to .yaml not much changed from the
> previous post.
> I will log the per patch changes in next post.
What happened to this series? It never got resent.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
2020-10-02 21:45 ` Stephen Boyd
@ 2020-10-21 15:09 ` kgunda
0 siblings, 0 replies; 11+ messages in thread
From: kgunda @ 2020-10-21 15:09 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, Lee Jones, Mark Rutland,
Rob Herring, devicetree, linux-arm-msm, linux-kernel, rnayak,
linux-arm-msm-owner
On 2020-10-03 03:15, Stephen Boyd wrote:
> Quoting kgunda@codeaurora.org (2020-02-06 21:57:49)
>> On 2020-02-07 00:36, Stephen Boyd wrote:
>> > Quoting Kiran Gunda (2020-02-06 05:55:26)
>> >> Convert the bindings from .txt to .yaml format.
>> >>
>> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> >> ---
>> >
>> > Did something change? Is there a cover letter?
>> >
>> Other than converting the bindings to .yaml not much changed from the
>> previous post.
>> I will log the per patch changes in next post.
>
> What happened to this series? It never got resent.
Couldn't get the chance to work on it. Will work on it and post the next
patch in couple weeks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V3 0/2] Convert qcom,spmi-pmic bindings from .txt to .yaml
@ 2020-12-17 11:38 Kiran Gunda
2020-12-17 11:38 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
0 siblings, 1 reply; 11+ messages in thread
From: Kiran Gunda @ 2020-12-17 11:38 UTC (permalink / raw)
To: swboyd, robh; +Cc: devicetree, linux-arm-msm, linux-kernel, Kiran Gunda
This patch series does the following:
1. converts the qcom,spmi-pmic bindings from .txt to .yaml format
2. Sorted the compatible strings
3. Adds PM6150 and PM6150L subtypes.
Changes from V2:
- Addressed Stephen Boyd and Rob Herring comments.
Kiran Gunda (2):
mfd: qcom-spmi-pmic: Convert bindings to .yaml format
mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 -------------
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 129 +++++++++++++++++++++
drivers/mfd/qcom-spmi-pmic.c | 4 +
3 files changed, 133 insertions(+), 80 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
2020-12-17 11:38 [PATCH V3 0/2] Convert qcom,spmi-pmic bindings from .txt to .yaml Kiran Gunda
@ 2020-12-17 11:38 ` Kiran Gunda
0 siblings, 0 replies; 11+ messages in thread
From: Kiran Gunda @ 2020-12-17 11:38 UTC (permalink / raw)
To: swboyd, robh, Andy Gross, Bjorn Andersson, Lee Jones,
Rob Herring, Stephen Boyd, linux-arm-msm, devicetree,
linux-kernel
Cc: Kiran Gunda
Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
found on SC7180 based platforms.
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
drivers/mfd/qcom-spmi-pmic.c | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 0b3e440..92cf7e9 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -58,6 +58,8 @@ patternProperties:
- qcom,pm8005
- qcom,pm660l
- qcom,pm660
+ - qcom,pm6150l
+ - qcom,pm6150
- enum:
- qcom,spmi-pmic
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
index a35d5cf..6d8b688 100644
--- a/drivers/mfd/qcom-spmi-pmic.c
+++ b/drivers/mfd/qcom-spmi-pmic.c
@@ -38,6 +38,8 @@
#define PM8005_SUBTYPE 0x18
#define PM660L_SUBTYPE 0x1A
#define PM660_SUBTYPE 0x1B
+#define PM6150L_SUBTYPE 0x1F
+#define PM6150_SUBTYPE 0x28
static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
@@ -61,6 +63,8 @@ static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
{ .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE },
{ .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE },
+ { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE },
+ { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE },
{ }
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-12-17 11:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 13:55 [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Kiran Gunda
2020-02-06 13:55 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
2020-02-06 19:08 ` Stephen Boyd
2020-02-07 5:59 ` kgunda
2020-02-06 19:06 ` [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Stephen Boyd
2020-02-06 22:06 ` Rob Herring
2020-02-07 6:46 ` kgunda
2020-02-07 5:57 ` kgunda
2020-10-02 21:45 ` Stephen Boyd
2020-10-21 15:09 ` kgunda
2020-12-17 11:38 [PATCH V3 0/2] Convert qcom,spmi-pmic bindings from .txt to .yaml Kiran Gunda
2020-12-17 11:38 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).