* [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h
@ 2020-04-23 13:59 Anson Huang
2020-04-23 13:59 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
2020-04-23 15:13 ` [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Aisheng Dong
0 siblings, 2 replies; 5+ messages in thread
From: Anson Huang @ 2020-04-23 13:59 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, rui.zhang, daniel.lezcano,
amit.kucheria, robh+dt, leonard.crestez, linux, peng.fan,
linux-kernel, linux-arm-kernel, linux-pm
Cc: Linux-imx
Now that linux/firmware/imx/types.h is removed, remove it from the
include list in imx-scu.c driver.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/firmware/imx/imx-scu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
index f71eaa5..f3340fa 100644
--- a/drivers/firmware/imx/imx-scu.c
+++ b/drivers/firmware/imx/imx-scu.c
@@ -8,7 +8,6 @@
*/
#include <linux/err.h>
-#include <linux/firmware/imx/types.h>
#include <linux/firmware/imx/ipc.h>
#include <linux/firmware/imx/sci.h>
#include <linux/interrupt.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h
2020-04-23 13:59 [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Anson Huang
@ 2020-04-23 13:59 ` Anson Huang
2020-04-23 14:19 ` Daniel Baluta
2020-04-23 15:13 ` [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Aisheng Dong
1 sibling, 1 reply; 5+ messages in thread
From: Anson Huang @ 2020-04-23 13:59 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, rui.zhang, daniel.lezcano,
amit.kucheria, robh+dt, leonard.crestez, linux, peng.fan,
linux-kernel, linux-arm-kernel, linux-pm
Cc: Linux-imx
The linux/firmware/imx/types.h has been merged into
dt-bindings/firmware/imx/rsrc.h, change the includes
in imx_sc_thermal.c driver accordingly.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/thermal/imx_sc_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index b2b68c9..b01d28e 100644
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -3,9 +3,9 @@
* Copyright 2018-2020 NXP.
*/
+#include <dt-bindings/firmware/imx/rsrc.h>
#include <linux/err.h>
#include <linux/firmware/imx/sci.h>
-#include <linux/firmware/imx/types.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h
2020-04-23 13:59 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
@ 2020-04-23 14:19 ` Daniel Baluta
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2020-04-23 14:19 UTC (permalink / raw)
To: Anson Huang, shawnguo, s.hauer, kernel, festevam, rui.zhang,
daniel.lezcano, amit.kucheria, robh+dt, leonard.crestez, linux,
peng.fan, linux-kernel, linux-arm-kernel, linux-pm
Cc: Linux-imx
On 4/23/20 4:59 PM, Anson Huang wrote:
> The linux/firmware/imx/types.h has been merged into
> dt-bindings/firmware/imx/rsrc.h, change the includes
> in imx_sc_thermal.c driver accordingly.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/thermal/imx_sc_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index b2b68c9..b01d28e 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -3,9 +3,9 @@
> * Copyright 2018-2020 NXP.
> */
>
> +#include <dt-bindings/firmware/imx/rsrc.h>
> #include <linux/err.h>
> #include <linux/firmware/imx/sci.h>
> -#include <linux/firmware/imx/types.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
You should do the operation of removing the header file and updating the
*.c files in one single patch.
Otherwise, we will break bisection. There will be states of the linux
kernel tree that do not compile.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h
2020-04-23 13:59 [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Anson Huang
2020-04-23 13:59 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
@ 2020-04-23 15:13 ` Aisheng Dong
1 sibling, 0 replies; 5+ messages in thread
From: Aisheng Dong @ 2020-04-23 15:13 UTC (permalink / raw)
To: Anson Huang, shawnguo, s.hauer, kernel, festevam, rui.zhang,
daniel.lezcano, amit.kucheria, robh+dt, Leonard Crestez, linux,
Peng Fan, linux-kernel, linux-arm-kernel, linux-pm
Cc: dl-linux-imx
> From: Anson Huang <Anson.Huang@nxp.com>
> Sent: Thursday, April 23, 2020 10:00 PM
>
> Now that linux/firmware/imx/types.h is removed, remove it from the include list
> in imx-scu.c driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
You need combine them in order to not break bisect.
Regards
Aisheng
> ---
> drivers/firmware/imx/imx-scu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index f71eaa5..f3340fa 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -8,7 +8,6 @@
> */
>
> #include <linux/err.h>
> -#include <linux/firmware/imx/types.h>
> #include <linux/firmware/imx/ipc.h>
> #include <linux/firmware/imx/sci.h>
> #include <linux/interrupt.h>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h
2020-04-23 14:00 [PATCH 1/3] dt-bindings: firmware: imx: Move system control into dt-binding headfile Anson Huang
@ 2020-04-23 14:00 ` Anson Huang
0 siblings, 0 replies; 5+ messages in thread
From: Anson Huang @ 2020-04-23 14:00 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, rui.zhang, daniel.lezcano,
amit.kucheria, robh+dt, leonard.crestez, linux, peng.fan,
linux-kernel, linux-arm-kernel, linux-pm
Cc: Linux-imx
The linux/firmware/imx/types.h has been merged into
dt-bindings/firmware/imx/rsrc.h, change the includes
in imx_sc_thermal.c driver accordingly.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/thermal/imx_sc_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index b2b68c9..b01d28e 100644
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -3,9 +3,9 @@
* Copyright 2018-2020 NXP.
*/
+#include <dt-bindings/firmware/imx/rsrc.h>
#include <linux/err.h>
#include <linux/firmware/imx/sci.h>
-#include <linux/firmware/imx/types.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-23 15:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 13:59 [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Anson Huang
2020-04-23 13:59 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
2020-04-23 14:19 ` Daniel Baluta
2020-04-23 15:13 ` [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Aisheng Dong
2020-04-23 14:00 [PATCH 1/3] dt-bindings: firmware: imx: Move system control into dt-binding headfile Anson Huang
2020-04-23 14:00 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).