* [PATCH] coccinelle: api: remove kobj_to_dev.cocci script
@ 2021-06-21 17:48 Keith Busch
2021-06-21 18:32 ` Denis Efremov
2021-06-21 18:33 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Keith Busch @ 2021-06-21 17:48 UTC (permalink / raw)
To: linux-kernel
Cc: Keith Busch, Christoph Hellwig, Jens Axboe, Denis Efremov, Julia Lawall
Using kobj_to_dev() instead of container_of() is not universally
accepted among maintainers as an improvement. The warning leads to
repeated patch submissions that won't be accepted. Remove the script.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Denis Efremov <efremov@linux.com>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------
1 file changed, 45 deletions(-)
delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci
deleted file mode 100644
index cd5d31c6fe76..000000000000
--- a/scripts/coccinelle/api/kobj_to_dev.cocci
+++ /dev/null
@@ -1,45 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-///
-/// Use kobj_to_dev() instead of container_of()
-///
-// Confidence: High
-// Copyright: (C) 2020 Denis Efremov ISPRAS
-// Options: --no-includes --include-headers
-//
-// Keywords: kobj_to_dev, container_of
-//
-
-virtual context
-virtual report
-virtual org
-virtual patch
-
-
-@r depends on !patch@
-expression ptr;
-symbol kobj;
-position p;
-@@
-
-* container_of(ptr, struct device, kobj)@p
-
-
-@depends on patch@
-expression ptr;
-@@
-
-- container_of(ptr, struct device, kobj)
-+ kobj_to_dev(ptr)
-
-
-@script:python depends on report@
-p << r.p;
-@@
-
-coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()")
-
-@script:python depends on org@
-p << r.p;
-@@
-
-coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] coccinelle: api: remove kobj_to_dev.cocci script
2021-06-21 17:48 [PATCH] coccinelle: api: remove kobj_to_dev.cocci script Keith Busch
@ 2021-06-21 18:32 ` Denis Efremov
2021-06-21 18:47 ` Julia Lawall
2021-06-21 18:33 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Denis Efremov @ 2021-06-21 18:32 UTC (permalink / raw)
To: Keith Busch, linux-kernel; +Cc: Christoph Hellwig, Jens Axboe, Julia Lawall
On 6/21/21 8:48 PM, Keith Busch wrote:
> Using kobj_to_dev() instead of container_of() is not universally
> accepted among maintainers as an improvement. The warning leads to
> repeated patch submissions that won't be accepted. Remove the script.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Denis Efremov <efremov@linux.com>
> Cc: Julia Lawall <Julia.Lawall@inria.fr>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Acked-by: Denis Efremov <efremov@linux.com>
> ---
> scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------
> 1 file changed, 45 deletions(-)
> delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
>
> diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci
> deleted file mode 100644
> index cd5d31c6fe76..000000000000
> --- a/scripts/coccinelle/api/kobj_to_dev.cocci
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0-only
> -///
> -/// Use kobj_to_dev() instead of container_of()
> -///
> -// Confidence: High
> -// Copyright: (C) 2020 Denis Efremov ISPRAS
> -// Options: --no-includes --include-headers
> -//
> -// Keywords: kobj_to_dev, container_of
> -//
> -
> -virtual context
> -virtual report
> -virtual org
> -virtual patch
> -
> -
> -@r depends on !patch@
> -expression ptr;
> -symbol kobj;
> -position p;
> -@@
> -
> -* container_of(ptr, struct device, kobj)@p
> -
> -
> -@depends on patch@
> -expression ptr;
> -@@
> -
> -- container_of(ptr, struct device, kobj)
> -+ kobj_to_dev(ptr)
> -
> -
> -@script:python depends on report@
> -p << r.p;
> -@@
> -
> -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()")
> -
> -@script:python depends on org@
> -p << r.p;
> -@@
> -
> -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coccinelle: api: remove kobj_to_dev.cocci script
2021-06-21 17:48 [PATCH] coccinelle: api: remove kobj_to_dev.cocci script Keith Busch
2021-06-21 18:32 ` Denis Efremov
@ 2021-06-21 18:33 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-06-21 18:33 UTC (permalink / raw)
To: Keith Busch, linux-kernel; +Cc: Christoph Hellwig, Denis Efremov, Julia Lawall
On 6/21/21 11:48 AM, Keith Busch wrote:
> Using kobj_to_dev() instead of container_of() is not universally
> accepted among maintainers as an improvement. The warning leads to
> repeated patch submissions that won't be accepted. Remove the script.
Acked-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coccinelle: api: remove kobj_to_dev.cocci script
2021-06-21 18:32 ` Denis Efremov
@ 2021-06-21 18:47 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2021-06-21 18:47 UTC (permalink / raw)
To: Denis Efremov; +Cc: Keith Busch, linux-kernel, Christoph Hellwig, Jens Axboe
On Mon, 21 Jun 2021, Denis Efremov wrote:
>
>
> On 6/21/21 8:48 PM, Keith Busch wrote:
> > Using kobj_to_dev() instead of container_of() is not universally
> > accepted among maintainers as an improvement. The warning leads to
> > repeated patch submissions that won't be accepted. Remove the script.
> >
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Denis Efremov <efremov@linux.com>
> > Cc: Julia Lawall <Julia.Lawall@inria.fr>
> > Signed-off-by: Keith Busch <kbusch@kernel.org>
>
> Acked-by: Denis Efremov <efremov@linux.com>
Applied.
>
> > ---
> > scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------
> > 1 file changed, 45 deletions(-)
> > delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
> >
> > diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci
> > deleted file mode 100644
> > index cd5d31c6fe76..000000000000
> > --- a/scripts/coccinelle/api/kobj_to_dev.cocci
> > +++ /dev/null
> > @@ -1,45 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0-only
> > -///
> > -/// Use kobj_to_dev() instead of container_of()
> > -///
> > -// Confidence: High
> > -// Copyright: (C) 2020 Denis Efremov ISPRAS
> > -// Options: --no-includes --include-headers
> > -//
> > -// Keywords: kobj_to_dev, container_of
> > -//
> > -
> > -virtual context
> > -virtual report
> > -virtual org
> > -virtual patch
> > -
> > -
> > -@r depends on !patch@
> > -expression ptr;
> > -symbol kobj;
> > -position p;
> > -@@
> > -
> > -* container_of(ptr, struct device, kobj)@p
> > -
> > -
> > -@depends on patch@
> > -expression ptr;
> > -@@
> > -
> > -- container_of(ptr, struct device, kobj)
> > -+ kobj_to_dev(ptr)
> > -
> > -
> > -@script:python depends on report@
> > -p << r.p;
> > -@@
> > -
> > -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()")
> > -
> > -@script:python depends on org@
> > -p << r.p;
> > -@@
> > -
> > -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-21 18:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-21 17:48 [PATCH] coccinelle: api: remove kobj_to_dev.cocci script Keith Busch
2021-06-21 18:32 ` Denis Efremov
2021-06-21 18:47 ` Julia Lawall
2021-06-21 18:33 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).