* Re: + arch-x86-makefile-use-config_shell.patch added to -mm tree [not found] <20200505211301.9_zLPwR3D%akpm@linux-foundation.org> @ 2020-05-05 21:19 ` Borislav Petkov 2020-05-06 7:56 ` [tip: x86/build] x86/build: Use $(CONFIG_SHELL) tip-bot2 for Andrew Morton 2020-05-17 13:08 ` tip-bot2 for Andrew Morton 0 siblings, 2 replies; 3+ messages in thread From: Borislav Petkov @ 2020-05-05 21:19 UTC (permalink / raw) To: akpm; +Cc: mm-commits, ndesaulniers, lkml On Tue, May 05, 2020 at 02:13:01PM -0700, akpm@linux-foundation.org wrote: > > The patch titled > Subject: arch/x86/Makefile: use $(CONFIG_SHELL) > has been added to the -mm tree. Its filename is > arch-x86-makefile-use-config_shell.patch > > This patch should soon appear at > http://ozlabs.org/~akpm/mmots/broken-out/arch-x86-makefile-use-config_shell.patch > and later at > http://ozlabs.org/~akpm/mmotm/broken-out/arch-x86-makefile-use-config_shell.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > > The -mm tree is included into linux-next and is updated > there every 3-4 working days > > ------------------------------------------------------ > From: Andrew Morton <akpm@linux-foundation.org> > Subject: arch/x86/Makefile: use $(CONFIG_SHELL) > > When scripts/x86-check-compiler.sh doesn't have the x bit set: > > q:/usr/src/25> make clean > make: execvp: ./scripts/x86-check-compiler.sh: Permission denied > > Fix this by using $(CONFIG_SHELL). > > This will happen if the user downloads and applies patch-5.7.tar.gz, since > patch(1) doesn't preserve the x bit. > > Fixes: 73da86741e7f7 ("x86/build: Check whether the compiler is sane") > Cc: Borislav Petkov <bp@suse.de> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > arch/x86/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/x86/Makefile~arch-x86-makefile-use-config_shell > +++ a/arch/x86/Makefile > @@ -2,7 +2,7 @@ > # Unified Makefile for i386 and x86_64 > > # Check the compiler > -sane_compiler := $(shell $(srctree)/scripts/x86-check-compiler.sh $(CC)) > +sane_compiler := $($(CONFIG_SHELL) $(srctree)/scripts/x86-check-compiler.sh $(CC)) > $(if $(sane_compiler),$(error $(CC) check failed. Aborting),) > > # select defconfig based on actual architecture > _ Ah, interesting. Thanks Andrew, I'll queue it tomorrow through tip. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg ^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/build] x86/build: Use $(CONFIG_SHELL) 2020-05-05 21:19 ` + arch-x86-makefile-use-config_shell.patch added to -mm tree Borislav Petkov @ 2020-05-06 7:56 ` tip-bot2 for Andrew Morton 2020-05-17 13:08 ` tip-bot2 for Andrew Morton 1 sibling, 0 replies; 3+ messages in thread From: tip-bot2 for Andrew Morton @ 2020-05-06 7:56 UTC (permalink / raw) To: linux-tip-commits; +Cc: Andrew Morton, Borislav Petkov, x86, LKML The following commit has been merged into the x86/build branch of tip: Commit-ID: 950a37078aa0ab63a57673e7027e8735e73d4bc6 Gitweb: https://git.kernel.org/tip/950a37078aa0ab63a57673e7027e8735e73d4bc6 Author: Andrew Morton <akpm@linux-foundation.org> AuthorDate: Tue, 05 May 2020 14:26:51 -07:00 Committer: Borislav Petkov <bp@suse.de> CommitterDate: Wed, 06 May 2020 09:46:26 +02:00 x86/build: Use $(CONFIG_SHELL) When scripts/x86-check-compiler.sh doesn't have the executable bit set: q:/usr/src/25> make clean make: execvp: ./scripts/x86-check-compiler.sh: Permission denied Fix this by using $(CONFIG_SHELL). This will happen if the user downloads and applies patch-5.7.tar.gz, since patch(1) doesn't preserve the x bit. Fixes: 73da86741e7f7 ("x86/build: Check whether the compiler is sane") Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Borislav Petkov <bp@suse.de> Link: https://lkml.kernel.org/r/20200505211932.GE6880@zn.tnic --- arch/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 38d3eec..9e22791 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -2,7 +2,7 @@ # Unified Makefile for i386 and x86_64 # Check the compiler -sane_compiler := $(shell $(srctree)/scripts/x86-check-compiler.sh $(CC)) +sane_compiler := $($(CONFIG_SHELL) $(srctree)/scripts/x86-check-compiler.sh $(CC)) $(if $(sane_compiler),$(error $(CC) check failed. Aborting),) # select defconfig based on actual architecture ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip: x86/build] x86/build: Use $(CONFIG_SHELL) 2020-05-05 21:19 ` + arch-x86-makefile-use-config_shell.patch added to -mm tree Borislav Petkov 2020-05-06 7:56 ` [tip: x86/build] x86/build: Use $(CONFIG_SHELL) tip-bot2 for Andrew Morton @ 2020-05-17 13:08 ` tip-bot2 for Andrew Morton 1 sibling, 0 replies; 3+ messages in thread From: tip-bot2 for Andrew Morton @ 2020-05-17 13:08 UTC (permalink / raw) To: linux-tip-commits; +Cc: Andrew Morton, Borislav Petkov, Ingo Molnar, x86, LKML The following commit has been merged into the x86/build branch of tip: Commit-ID: 0be11088b848774ae1f693169fdb9575e0ff06ba Gitweb: https://git.kernel.org/tip/0be11088b848774ae1f693169fdb9575e0ff06ba Author: Andrew Morton <akpm@linux-foundation.org> AuthorDate: Tue, 05 May 2020 14:26:51 -07:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Sun, 17 May 2020 16:01:33 +03:00 x86/build: Use $(CONFIG_SHELL) When scripts/x86-check-compiler.sh doesn't have the executable bit set: q:/usr/src/25> make clean make: execvp: ./scripts/x86-check-compiler.sh: Permission denied Fix this by using $(CONFIG_SHELL). This will happen if the user downloads and applies patch-5.7.tar.gz, since patch(1) doesn't preserve the x bit. Fixes: 73da86741e7f7 ("x86/build: Check whether the compiler is sane") Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Borislav Petkov <bp@suse.de> Link: https://lkml.kernel.org/r/20200505211932.GE6880@zn.tnic Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 38d3eec..9e22791 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -2,7 +2,7 @@ # Unified Makefile for i386 and x86_64 # Check the compiler -sane_compiler := $(shell $(srctree)/scripts/x86-check-compiler.sh $(CC)) +sane_compiler := $($(CONFIG_SHELL) $(srctree)/scripts/x86-check-compiler.sh $(CC)) $(if $(sane_compiler),$(error $(CC) check failed. Aborting),) # select defconfig based on actual architecture ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-17 13:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200505211301.9_zLPwR3D%akpm@linux-foundation.org> 2020-05-05 21:19 ` + arch-x86-makefile-use-config_shell.patch added to -mm tree Borislav Petkov 2020-05-06 7:56 ` [tip: x86/build] x86/build: Use $(CONFIG_SHELL) tip-bot2 for Andrew Morton 2020-05-17 13:08 ` tip-bot2 for Andrew Morton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).