From: Chunyu Hu <chuhu@redhat.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Chunyu Hu <chuhu.ncepu@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in gfp_kmemleak_mask
Date: Fri, 27 Apr 2018 06:17:12 -0400 (EDT) [thread overview]
Message-ID: <1591480647.20311538.1524824232546.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180426125634.uybpbbk5puee7fsg@armageddon.cambridge.arm.com>
----- Original Message -----
> From: "Catalin Marinas" <catalin.marinas@arm.com>
> To: "Chunyu Hu" <chuhu@redhat.com>
> Cc: "Michal Hocko" <mhocko@kernel.org>, "Chunyu Hu" <chuhu.ncepu@gmail.com>, "Dmitry Vyukov" <dvyukov@google.com>,
> "LKML" <linux-kernel@vger.kernel.org>, "Linux-MM" <linux-mm@kvack.org>
> Sent: Thursday, April 26, 2018 8:56:35 PM
> Subject: Re: [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in gfp_kmemleak_mask
>
> On Thu, Apr 26, 2018 at 08:23:19AM -0400, Chunyu Hu wrote:
> > kmemleak is using kmem_cache to record every pointers returned from kernel
> > mem
> > allocation activities such as kmem_cache_alloc(). every time an object from
> > slab allocator is returned, a following new kmemleak object is allocated.
> >
> > And when a slab object is freed, then the kmemleak object which contains
> > the ptr will also be freed.
> >
> > and kmemleak scan thread will run in period to scan the kernel data, stack,
> > and per cpu areas to check that every pointers recorded by kmemleak has at
> > least
> > one reference in those areas beside the one recorded by kmemleak. If there
> > is no place in the memory acreas recording the ptr, then it's possible a
> > leak.
> >
> > so once a kmemleak object allocation failed, it has to disable itself,
> > otherwise
> > it would lose track of some object pointers, and become less meaningful to
> > continue record and scan the kernel memory for the pointers. So disable
> > it forever. so this is why kmemleak can't tolerate a slab alloc fail (from
> > fault injection)
> >
> > @Catalin,
> >
> > Is this right? If something not so correct or precise, please correct me.
>
> That's a good description, thanks.
>
> > I'm thinking about, is it possible that make kmemleak don't disable itself
> > when fail_page_alloc is enabled? I can't think clearly what would happen
> > if several memory allocation missed by kmelkeak trace, what's the bad
> > result?
>
> Take for example a long linked list. If kmemleak doesn't track an object
> in such list (because the metadata allocation failed), such list_head is
> never scanned and the subsequent objects in the list (pointed at by
> 'next') will be reported as leaks. Kmemleak pretty much becomes unusable
> with a high number of false positives.
Thanks for the example, one object may contain many pointers, so loose one,
means many false reports. I'm clear now.
>
> --
> Catalin
>
--
Regards,
Chunyu Hu
next prev parent reply other threads:[~2018-04-27 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 16:58 [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in gfp_kmemleak_mask Chunyu Hu
2018-04-20 17:50 ` Catalin Marinas
2018-04-20 17:52 ` Dmitry Vyukov
2018-04-22 12:51 ` Michal Hocko
2018-04-22 15:00 ` Dmitry Vyukov
2018-04-23 4:17 ` Chunyu Hu
2018-04-24 13:20 ` Michal Hocko
2018-04-24 13:41 ` Catalin Marinas
2018-04-25 9:50 ` Chunyu Hu
2018-04-25 12:51 ` Catalin Marinas
2018-04-25 14:33 ` Chunyu Hu
2018-04-27 10:13 ` Chunyu Hu
2018-04-24 16:48 ` Chunyu Hu
2018-04-24 17:02 ` Michal Hocko
2018-04-24 17:16 ` Dmitry Vyukov
2018-04-26 12:23 ` Chunyu Hu
2018-04-26 12:56 ` Catalin Marinas
2018-04-27 10:17 ` Chunyu Hu [this message]
2018-04-23 3:30 ` Chunyu Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591480647.20311538.1524824232546.JavaMail.zimbra@redhat.com \
--to=chuhu@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=chuhu.ncepu@gmail.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).