* [PATCH 0/2] Modularize RPMH driver @ 2020-08-19 10:07 Maulik Shah 2020-08-19 10:07 ` [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Maulik Shah 2020-08-19 10:07 ` [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" Maulik Shah 0 siblings, 2 replies; 9+ messages in thread From: Maulik Shah @ 2020-08-19 10:07 UTC (permalink / raw) To: bjorn.andersson, agross Cc: linux-kernel, linux-arm-msm, ulf.hansson, swboyd, dianders, rnayak, ilina, lsrao, Maulik Shah This series is to modularize RPMH driver The tracepoint in RPMH driver was changed to _rcuidle variant based on the test results of unmerged series [1] where .power_off callback from genpd reported RCU warnings. The series which finally got merged [2] uses CPU PM notifications and genpd .power_off callback is not implemented in RPMH driver to invoke rpmh_flush(). The CPU PM notifications are done with RCU non idle in kernel (see cpu_pm_notify() uses rcu_irq_enter_irqson() before notifications) However using _rcuidle variant prevented RPMH driver to compile as module since these _rcuidle are not exported symbols for tracepoints. This seris reverts the change [3] to remove _rcuidle variant for tracepoint as its no more valid test case (genpd .power_off is not implemented) and bring backs the change [4] that was reverted due to _rcuidle preventing to become modular. [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=243931 [2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=269733 [3] https://lore.kernel.org/r/20200115013751.249588-1-swboyd@chromium.org [4] https://lore.kernel.org/r/20200326224459.105170-3-john.stultz@linaro.org Maulik Shah (2): Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" drivers/soc/qcom/Kconfig | 2 +- drivers/soc/qcom/rpmh-rsc.c | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" 2020-08-19 10:07 [PATCH 0/2] Modularize RPMH driver Maulik Shah @ 2020-08-19 10:07 ` Maulik Shah 2020-08-19 18:04 ` Stephen Boyd ` (2 more replies) 2020-08-19 10:07 ` [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" Maulik Shah 1 sibling, 3 replies; 9+ messages in thread From: Maulik Shah @ 2020-08-19 10:07 UTC (permalink / raw) To: bjorn.andersson, agross Cc: linux-kernel, linux-arm-msm, ulf.hansson, swboyd, dianders, rnayak, ilina, lsrao, Maulik Shah, Sai Prakash Ranjan, John Stultz, Stephen Rothwell This change was done based on an test results of unmerged series of adding RSC power domain and using .power_off callback of genpd to invoke rpmh_flush(). Call trace: dump_backtrace+0x0/0x174 show_stack+0x20/0x2c dump_stack+0xc8/0x124 lockdep_rcu_suspicious+0xe4/0x104 __tcs_buffer_write+0x230/0x2d0 rpmh_rsc_write_ctrl_data+0x210/0x270 rpmh_flush+0x84/0x24c rpmh_domain_power_off+0x78/0x98 _genpd_power_off+0x40/0xc0 genpd_power_off+0x168/0x208 Later the final merged solution is to use CPU PM notification to invoke rpmh_flush() and .power_off callback of genpd is not implemented in the driver. Remove this change since RCU will not be idle during CPU PM notifications hence not required to use _rcuidle tracepoint. Using _rcuidle tracepoint prevented rpmh driver to be loadable module as these are not exported symbols. This reverts commit efde2659b0fe835732047357b2902cca14f054d9. Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Cc: John Stultz <john.stultz@linaro.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> --- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index ae66757..fabe390d 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -495,7 +495,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int tcs_id, int cmd_id, write_tcs_cmd(drv, RSC_DRV_CMD_MSGID, tcs_id, j, msgid); write_tcs_cmd(drv, RSC_DRV_CMD_ADDR, tcs_id, j, cmd->addr); write_tcs_cmd(drv, RSC_DRV_CMD_DATA, tcs_id, j, cmd->data); - trace_rpmh_send_msg_rcuidle(drv, tcs_id, j, msgid, cmd); + trace_rpmh_send_msg(drv, tcs_id, j, msgid, cmd); } write_tcs_reg(drv, RSC_DRV_CMD_WAIT_FOR_CMPL, tcs_id, cmd_complete); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" 2020-08-19 10:07 ` [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Maulik Shah @ 2020-08-19 18:04 ` Stephen Boyd 2020-08-22 16:21 ` Maulik Shah 2020-08-20 6:19 ` Sai Prakash Ranjan 2020-08-24 11:35 ` Ulf Hansson 2 siblings, 1 reply; 9+ messages in thread From: Stephen Boyd @ 2020-08-19 18:04 UTC (permalink / raw) To: Maulik Shah, agross, bjorn.andersson Cc: linux-kernel, linux-arm-msm, ulf.hansson, dianders, rnayak, ilina, lsrao, Maulik Shah, Sai Prakash Ranjan, John Stultz, Stephen Rothwell Quoting Maulik Shah (2020-08-19 03:07:49) > This change was done based on an test results of unmerged series of > adding RSC power domain and using .power_off callback of genpd to > invoke rpmh_flush(). Perhaps: Commit efde2659b0fe ("drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh") was written to fix a bug seen in an unmerged series that implemented a struct generic_pm_domain::power_off() callback calling rpmh_flush(). See stack trace below. > > Call trace: > dump_backtrace+0x0/0x174 > show_stack+0x20/0x2c > dump_stack+0xc8/0x124 > lockdep_rcu_suspicious+0xe4/0x104 > __tcs_buffer_write+0x230/0x2d0 > rpmh_rsc_write_ctrl_data+0x210/0x270 > rpmh_flush+0x84/0x24c > rpmh_domain_power_off+0x78/0x98 > _genpd_power_off+0x40/0xc0 > genpd_power_off+0x168/0x208 > > Later the final merged solution is to use CPU PM notification to invoke > rpmh_flush() and .power_off callback of genpd is not implemented in the > driver. I'd also add: CPU PM notifiers are run with RCU enabled/watching (see cpu_pm_notify() and how it calls rcu_irq_enter_irqson() before calling the notifiers). > > Remove this change since RCU will not be idle during CPU PM notifications > hence not required to use _rcuidle tracepoint. Using _rcuidle tracepoint > prevented rpmh driver to be loadable module as these are not exported > symbols. > > This reverts commit efde2659b0fe835732047357b2902cca14f054d9. > > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Cc: John Stultz <john.stultz@linaro.org> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > --- Otherwise Reviewed-by: Stephen Boyd <swboyd@chromium.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" 2020-08-19 18:04 ` Stephen Boyd @ 2020-08-22 16:21 ` Maulik Shah 0 siblings, 0 replies; 9+ messages in thread From: Maulik Shah @ 2020-08-22 16:21 UTC (permalink / raw) To: Stephen Boyd, agross, bjorn.andersson Cc: linux-kernel, linux-arm-msm, ulf.hansson, dianders, rnayak, ilina, lsrao, Sai Prakash Ranjan, John Stultz, Stephen Rothwell Hi, On 8/19/2020 11:34 PM, Stephen Boyd wrote: > Quoting Maulik Shah (2020-08-19 03:07:49) >> This change was done based on an test results of unmerged series of >> adding RSC power domain and using .power_off callback of genpd to >> invoke rpmh_flush(). > Perhaps: > > Commit efde2659b0fe ("drivers: qcom: rpmh-rsc: Use rcuidle tracepoints > for rpmh") was written to fix a bug seen in an unmerged series that > implemented a struct generic_pm_domain::power_off() callback calling > rpmh_flush(). See stack trace below. Sure i will update in v2. > >> Call trace: >> dump_backtrace+0x0/0x174 >> show_stack+0x20/0x2c >> dump_stack+0xc8/0x124 >> lockdep_rcu_suspicious+0xe4/0x104 >> __tcs_buffer_write+0x230/0x2d0 >> rpmh_rsc_write_ctrl_data+0x210/0x270 >> rpmh_flush+0x84/0x24c >> rpmh_domain_power_off+0x78/0x98 >> _genpd_power_off+0x40/0xc0 >> genpd_power_off+0x168/0x208 >> >> Later the final merged solution is to use CPU PM notification to invoke >> rpmh_flush() and .power_off callback of genpd is not implemented in the >> driver. > I'd also add: > > CPU PM notifiers are run with RCU enabled/watching (see cpu_pm_notify() > and how it calls rcu_irq_enter_irqson() before calling the notifiers). Sure i will update in v2. > >> Remove this change since RCU will not be idle during CPU PM notifications >> hence not required to use _rcuidle tracepoint. Using _rcuidle tracepoint >> prevented rpmh driver to be loadable module as these are not exported >> symbols. >> >> This reverts commit efde2659b0fe835732047357b2902cca14f054d9. >> >> Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> >> Cc: John Stultz <john.stultz@linaro.org> >> Cc: Stephen Rothwell <sfr@canb.auug.org.au> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> --- > Otherwise > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Thanks for the review. Thanks, Maulik -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" 2020-08-19 10:07 ` [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Maulik Shah 2020-08-19 18:04 ` Stephen Boyd @ 2020-08-20 6:19 ` Sai Prakash Ranjan 2020-08-24 11:35 ` Ulf Hansson 2 siblings, 0 replies; 9+ messages in thread From: Sai Prakash Ranjan @ 2020-08-20 6:19 UTC (permalink / raw) To: Maulik Shah Cc: bjorn.andersson, agross, linux-kernel, linux-arm-msm, ulf.hansson, swboyd, dianders, rnayak, ilina, lsrao, John Stultz, Stephen Rothwell On 2020-08-19 15:37, Maulik Shah wrote: > This change was done based on an test results of unmerged series of > adding RSC power domain and using .power_off callback of genpd to > invoke rpmh_flush(). > > Call trace: > dump_backtrace+0x0/0x174 > show_stack+0x20/0x2c > dump_stack+0xc8/0x124 > lockdep_rcu_suspicious+0xe4/0x104 > __tcs_buffer_write+0x230/0x2d0 > rpmh_rsc_write_ctrl_data+0x210/0x270 > rpmh_flush+0x84/0x24c > rpmh_domain_power_off+0x78/0x98 > _genpd_power_off+0x40/0xc0 > genpd_power_off+0x168/0x208 > > Later the final merged solution is to use CPU PM notification to invoke > rpmh_flush() and .power_off callback of genpd is not implemented in the > driver. > > Remove this change since RCU will not be idle during CPU PM > notifications > hence not required to use _rcuidle tracepoint. Using _rcuidle > tracepoint > prevented rpmh driver to be loadable module as these are not exported > symbols. > > This reverts commit efde2659b0fe835732047357b2902cca14f054d9. > > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Cc: John Stultz <john.stultz@linaro.org> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > --- Reviewed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" 2020-08-19 10:07 ` [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Maulik Shah 2020-08-19 18:04 ` Stephen Boyd 2020-08-20 6:19 ` Sai Prakash Ranjan @ 2020-08-24 11:35 ` Ulf Hansson 2 siblings, 0 replies; 9+ messages in thread From: Ulf Hansson @ 2020-08-24 11:35 UTC (permalink / raw) To: Maulik Shah Cc: Bjorn Andersson, Andy Gross, Linux Kernel Mailing List, linux-arm-msm, Stephen Boyd, Doug Anderson, Rajendra Nayak, Lina Iyer, lsrao, Sai Prakash Ranjan, John Stultz, Stephen Rothwell On Wed, 19 Aug 2020 at 12:08, Maulik Shah <mkshah@codeaurora.org> wrote: > > This change was done based on an test results of unmerged series of > adding RSC power domain and using .power_off callback of genpd to > invoke rpmh_flush(). > > Call trace: > dump_backtrace+0x0/0x174 > show_stack+0x20/0x2c > dump_stack+0xc8/0x124 > lockdep_rcu_suspicious+0xe4/0x104 > __tcs_buffer_write+0x230/0x2d0 > rpmh_rsc_write_ctrl_data+0x210/0x270 > rpmh_flush+0x84/0x24c > rpmh_domain_power_off+0x78/0x98 > _genpd_power_off+0x40/0xc0 > genpd_power_off+0x168/0x208 > > Later the final merged solution is to use CPU PM notification to invoke > rpmh_flush() and .power_off callback of genpd is not implemented in the > driver. > > Remove this change since RCU will not be idle during CPU PM notifications > hence not required to use _rcuidle tracepoint. Using _rcuidle tracepoint > prevented rpmh driver to be loadable module as these are not exported > symbols. > > This reverts commit efde2659b0fe835732047357b2902cca14f054d9. > > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Cc: John Stultz <john.stultz@linaro.org> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> Along with Stephen's comments, feel free to add: Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Also note, when using the PSCI OSI mode, I am proposing to use "genpd on/off notifiers" [1]. This may lead to similar RCU issues, but let's come back to adress that later on, when/if needed. Kind regards Uffe [1] https://www.spinics.net/lists/kernel/msg3629443.html > --- > drivers/soc/qcom/rpmh-rsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c > index ae66757..fabe390d 100644 > --- a/drivers/soc/qcom/rpmh-rsc.c > +++ b/drivers/soc/qcom/rpmh-rsc.c > @@ -495,7 +495,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int tcs_id, int cmd_id, > write_tcs_cmd(drv, RSC_DRV_CMD_MSGID, tcs_id, j, msgid); > write_tcs_cmd(drv, RSC_DRV_CMD_ADDR, tcs_id, j, cmd->addr); > write_tcs_cmd(drv, RSC_DRV_CMD_DATA, tcs_id, j, cmd->data); > - trace_rpmh_send_msg_rcuidle(drv, tcs_id, j, msgid, cmd); > + trace_rpmh_send_msg(drv, tcs_id, j, msgid, cmd); > } > > write_tcs_reg(drv, RSC_DRV_CMD_WAIT_FOR_CMPL, tcs_id, cmd_complete); > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" 2020-08-19 10:07 [PATCH 0/2] Modularize RPMH driver Maulik Shah 2020-08-19 10:07 ` [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Maulik Shah @ 2020-08-19 10:07 ` Maulik Shah 2020-08-20 23:12 ` Stephen Boyd 1 sibling, 1 reply; 9+ messages in thread From: Maulik Shah @ 2020-08-19 10:07 UTC (permalink / raw) To: bjorn.andersson, agross Cc: linux-kernel, linux-arm-msm, ulf.hansson, swboyd, dianders, rnayak, ilina, lsrao, Maulik Shah, John Stultz, Stephen Rothwell, Todd Kjos, Saravana Kannan The _rcuidle tracepoints are removed from RPMH driver which prevented to compile it as module. Bring back the change to make it module. This reverts commit 1f7a3eb785e4a4e196729cd3d5ec97bd5f9f2940. Cc: John Stultz <john.stultz@linaro.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Todd Kjos <tkjos@google.com> Cc: Saravana Kannan <saravanak@google.com> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> --- drivers/soc/qcom/Kconfig | 2 +- drivers/soc/qcom/rpmh-rsc.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 3dc3e3d..892bdc7 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -92,7 +92,7 @@ config QCOM_RMTFS_MEM Say y here if you intend to boot the modem remoteproc. config QCOM_RPMH - bool "Qualcomm RPM-Hardened (RPMH) Communication" + tristate "Qualcomm RPM-Hardened (RPMH) Communication" depends on ARCH_QCOM || COMPILE_TEST help Support for communication with the hardened-RPM blocks in diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index fabe390d..5fce87c 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -13,6 +13,7 @@ #include <linux/iopoll.h> #include <linux/kernel.h> #include <linux/list.h> +#include <linux/module.h> #include <linux/of.h> #include <linux/of_irq.h> #include <linux/of_platform.h> @@ -1025,6 +1026,7 @@ static const struct of_device_id rpmh_drv_match[] = { { .compatible = "qcom,rpmh-rsc", }, { } }; +MODULE_DEVICE_TABLE(of, rpmh_drv_match); static struct platform_driver rpmh_driver = { .probe = rpmh_rsc_probe, @@ -1040,3 +1042,6 @@ static int __init rpmh_driver_init(void) return platform_driver_register(&rpmh_driver); } arch_initcall(rpmh_driver_init); + +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver"); +MODULE_LICENSE("GPL v2"); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" 2020-08-19 10:07 ` [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" Maulik Shah @ 2020-08-20 23:12 ` Stephen Boyd 2020-08-22 16:23 ` Maulik Shah 0 siblings, 1 reply; 9+ messages in thread From: Stephen Boyd @ 2020-08-20 23:12 UTC (permalink / raw) To: Maulik Shah, agross, bjorn.andersson Cc: linux-kernel, linux-arm-msm, ulf.hansson, dianders, rnayak, ilina, lsrao, Maulik Shah, John Stultz, Stephen Rothwell, Todd Kjos, Saravana Kannan Quoting Maulik Shah (2020-08-19 03:07:50) > The _rcuidle tracepoints are removed from RPMH driver which prevented > to compile it as module. Bring back the change to make it module. > > This reverts commit 1f7a3eb785e4a4e196729cd3d5ec97bd5f9f2940. > > Cc: John Stultz <john.stultz@linaro.org> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Todd Kjos <tkjos@google.com> > Cc: Saravana Kannan <saravanak@google.com> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > --- Please send the original patch and add your SoB to it. Reverting a patch out of the history works, but doesn't do justice to the authorship of the patch. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" 2020-08-20 23:12 ` Stephen Boyd @ 2020-08-22 16:23 ` Maulik Shah 0 siblings, 0 replies; 9+ messages in thread From: Maulik Shah @ 2020-08-22 16:23 UTC (permalink / raw) To: Stephen Boyd, agross, bjorn.andersson Cc: linux-kernel, linux-arm-msm, ulf.hansson, dianders, rnayak, ilina, lsrao, John Stultz, Stephen Rothwell, Todd Kjos, Saravana Kannan Hi, On 8/21/2020 4:42 AM, Stephen Boyd wrote: > Quoting Maulik Shah (2020-08-19 03:07:50) >> The _rcuidle tracepoints are removed from RPMH driver which prevented >> to compile it as module. Bring back the change to make it module. >> >> This reverts commit 1f7a3eb785e4a4e196729cd3d5ec97bd5f9f2940. >> >> Cc: John Stultz <john.stultz@linaro.org> >> Cc: Stephen Rothwell <sfr@canb.auug.org.au> >> Cc: Todd Kjos <tkjos@google.com> >> Cc: Saravana Kannan <saravanak@google.com> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> --- > Please send the original patch and add your SoB to it. Reverting a patch > out of the history works, but doesn't do justice to the authorship of > the patch. Sure, i will re-send the original patch in v2 instead of doing revert's revert. Thanks, Maulik -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-08-24 11:40 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-19 10:07 [PATCH 0/2] Modularize RPMH driver Maulik Shah 2020-08-19 10:07 ` [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" Maulik Shah 2020-08-19 18:04 ` Stephen Boyd 2020-08-22 16:21 ` Maulik Shah 2020-08-20 6:19 ` Sai Prakash Ranjan 2020-08-24 11:35 ` Ulf Hansson 2020-08-19 10:07 ` [PATCH 2/2] Revert "Revert "soc: qcom: rpmh: Allow RPMH driver to be loaded as a module"" Maulik Shah 2020-08-20 23:12 ` Stephen Boyd 2020-08-22 16:23 ` Maulik Shah
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).