linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/8] Fix cdrom autoclose.
@ 2019-10-23 12:52 Michal Suchanek
  2019-10-23 12:52 ` [PATCH v2 1/8] cdrom: add poll_event_interruptible Michal Suchanek
                   ` (7 more replies)
  0 siblings, 8 replies; 36+ messages in thread
From: Michal Suchanek @ 2019-10-23 12:52 UTC (permalink / raw)
  To: linux-scsi
  Cc: Michal Suchanek, Jonathan Corbet, Jens Axboe,
	James E.J. Bottomley, Martin K. Petersen, Alexander Viro,
	Mauro Carvalho Chehab, Eric Biggers, J. Bruce Fields,
	Benjamin Coddington, Hannes Reinecke, Omar Sandoval, Ming Lei,
	Damien Le Moal, Bart Van Assche, Tejun Heo, linux-doc,
	linux-kernel, linux-fsdevel

Link: https://lore.kernel.org/lkml/cover.1513263482.git.msuchanek@suse.de/

Hello,

there is cdrom autoclose feature that is supposed to close the tray,
wait for the disc to become ready, and then open the device.

This used to work in ancient times. Then in old times there was a hack
in util-linux which worked around the breakage which probably resulted
from switching to scsi emulation.

Currently util-linux maintainer refuses to merge another hack on the
basis that kernel still has the feature so it should be fixed there.
The code needs not be replicated in every userspace utility like mount
or dd which has no business knowing which devices are CD-roms and where
the autoclose setting is in the kernel.

Michal Suchanek (8):
  cdrom: add poll_event_interruptible
  cdrom: factor out common open_for_* code
  cdrom: wait for the tray to close
  cdrom: separate autoclose into an IOCTL
  docs: cdrom: Add autoclose IOCTL
  bdev: add open_finish.
  scsi: sr: workaround VMware ESXi cdrom emulation bug
  scsi: sr: wait for the medium to become ready

 Documentation/filesystems/locking.rst |   2 +
 Documentation/ioctl/cdrom.rst         |  25 ++++
 drivers/cdrom/cdrom.c                 | 188 ++++++++++++++------------
 drivers/scsi/sr.c                     |  60 ++++++--
 fs/block_dev.c                        |  21 ++-
 include/linux/blkdev.h                |   1 +
 include/uapi/linux/cdrom.h            |   1 +
 7 files changed, 198 insertions(+), 100 deletions(-)

-- 
2.23.0


^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2019-11-21 15:21 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 12:52 [PATCH v2 0/8] Fix cdrom autoclose Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 1/8] cdrom: add poll_event_interruptible Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 2/8] cdrom: factor out common open_for_* code Michal Suchanek
2019-10-24  2:19   ` Christoph Hellwig
2019-10-24  8:50     ` Michal Suchánek
2019-10-25  2:39       ` Christoph Hellwig
2019-10-25 10:42         ` Michal Suchánek
2019-10-26  6:46           ` Finn Thain
2019-10-24 13:23     ` Matthew Wilcox
2019-10-25  2:38       ` Christoph Hellwig
2019-10-23 12:52 ` [PATCH v2 3/8] cdrom: wait for the tray to close Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 4/8] cdrom: separate autoclose into an IOCTL Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 5/8] docs: cdrom: Add autoclose IOCTL Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 6/8] bdev: add open_finish Michal Suchanek
2019-10-24  2:22   ` Christoph Hellwig
2019-10-24  8:55     ` Michal Suchánek
2019-10-24 13:12       ` Matthew Wilcox
2019-10-24 13:19         ` Michal Suchánek
2019-11-21 10:15         ` Michal Suchánek
2019-10-23 12:52 ` [PATCH v2 7/8] scsi: sr: workaround VMware ESXi cdrom emulation bug Michal Suchanek
2019-10-23 14:13   ` Hannes Reinecke
2019-10-23 16:23     ` Michal Suchánek
2019-10-23 21:44       ` Ewan D. Milne
2019-10-24  5:46       ` Hannes Reinecke
2019-10-24  8:56         ` Michal Suchánek
2019-10-24  9:41           ` Hannes Reinecke
2019-10-24 10:11             ` Michal Suchánek
2019-10-24 11:45             ` [PATCH RFC] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation Michal Suchanek
2019-10-24  2:23   ` [PATCH v2 7/8] scsi: sr: workaround VMware ESXi cdrom emulation bug Christoph Hellwig
2019-10-24  8:53     ` Michal Suchánek
2019-11-21 15:21     ` Michal Suchánek
2019-10-23 12:52 ` [PATCH v2 8/8] scsi: sr: wait for the medium to become ready Michal Suchanek
2019-10-24  2:24   ` Christoph Hellwig
2019-10-24  8:51     ` Michal Suchánek
2019-10-24 13:14       ` Matthew Wilcox
2019-10-26 14:57   ` [scsi] 9ed2563662: BUG:kernel_NULL_pointer_dereference,address kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).