* [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
@ 2021-01-27 21:43 richard.gong
2021-01-27 21:43 ` richard.gong
0 siblings, 1 reply; 5+ messages in thread
From: richard.gong @ 2021-01-27 21:43 UTC (permalink / raw)
To: gregkh; +Cc: mdf, trix, linux-kernel, Richard Gong
From: Richard Gong <richard.gong@intel.com>
This is a bug fix and needs to be backported to stable kernel releases.
Richard Gong (1):
firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
include/linux/firmware/intel/stratix10-svc-client.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
2021-01-27 21:43 [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0 richard.gong
@ 2021-01-27 21:43 ` richard.gong
2021-01-27 22:00 ` Tom Rix
2021-01-28 8:00 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: richard.gong @ 2021-01-27 21:43 UTC (permalink / raw)
To: gregkh; +Cc: mdf, trix, linux-kernel, Richard Gong
From: Richard Gong <richard.gong@intel.com>
Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
aligns with the firmware settings.
Signed-off-by: Richard Gong <richard.gong@intel.com>
---
include/linux/firmware/intel/stratix10-svc-client.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
index ebc2956..1ffb982 100644
--- a/include/linux/firmware/intel/stratix10-svc-client.h
+++ b/include/linux/firmware/intel/stratix10-svc-client.h
@@ -51,12 +51,12 @@
#define SVC_STATUS_NO_SUPPORT 6
/*
- * Flag bit for COMMAND_RECONFIG
+ * Flag for COMMAND_RECONFIG, in bit number
*
* COMMAND_RECONFIG_FLAG_PARTIAL:
- * Set to FPGA configuration type (full or partial).
+ * Set for partial configuration.
*/
-#define COMMAND_RECONFIG_FLAG_PARTIAL 1
+#define COMMAND_RECONFIG_FLAG_PARTIAL 0
/*
* Timeout settings for service clients:
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
2021-01-27 21:43 ` richard.gong
@ 2021-01-27 22:00 ` Tom Rix
2021-01-28 8:01 ` Greg KH
2021-01-28 8:00 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Tom Rix @ 2021-01-27 22:00 UTC (permalink / raw)
To: richard.gong, gregkh; +Cc: mdf, linux-kernel, Richard Gong
On 1/27/21 1:43 PM, richard.gong@linux.intel.com wrote:
> From: Richard Gong <richard.gong@intel.com>
>
> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> aligns with the firmware settings.
For fixes, you need to have a 'Fixes: ... ' line in the comment.
This lets folks doing the stable branch know how far back to apply the fix.
For this case, this is likely
Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values")
This should go right above your signoff.
By stand alone patch, this change should be split out from your current
[PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
So the next rev out your patch set will have 7 patches, because 1/6 is being split into two patches.
I would recommend the fix be 1/7, to minimize chance of conflicts merging it with stable.
or
submit the split out fix first.
Tom
>
> Signed-off-by: Richard Gong <richard.gong@intel.com>
> ---
> include/linux/firmware/intel/stratix10-svc-client.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> index ebc2956..1ffb982 100644
> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> @@ -51,12 +51,12 @@
> #define SVC_STATUS_NO_SUPPORT 6
>
> /*
> - * Flag bit for COMMAND_RECONFIG
> + * Flag for COMMAND_RECONFIG, in bit number
> *
> * COMMAND_RECONFIG_FLAG_PARTIAL:
> - * Set to FPGA configuration type (full or partial).
> + * Set for partial configuration.
> */
> -#define COMMAND_RECONFIG_FLAG_PARTIAL 1
> +#define COMMAND_RECONFIG_FLAG_PARTIAL 0
>
> /*
> * Timeout settings for service clients:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
2021-01-27 21:43 ` richard.gong
2021-01-27 22:00 ` Tom Rix
@ 2021-01-28 8:00 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2021-01-28 8:00 UTC (permalink / raw)
To: richard.gong; +Cc: mdf, trix, linux-kernel, Richard Gong
On Wed, Jan 27, 2021 at 03:43:21PM -0600, richard.gong@linux.intel.com wrote:
> From: Richard Gong <richard.gong@intel.com>
>
> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> aligns with the firmware settings.
>
> Signed-off-by: Richard Gong <richard.gong@intel.com>
> ---
> include/linux/firmware/intel/stratix10-svc-client.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
2021-01-27 22:00 ` Tom Rix
@ 2021-01-28 8:01 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2021-01-28 8:01 UTC (permalink / raw)
To: Tom Rix; +Cc: richard.gong, mdf, linux-kernel, Richard Gong
On Wed, Jan 27, 2021 at 02:00:06PM -0800, Tom Rix wrote:
>
> On 1/27/21 1:43 PM, richard.gong@linux.intel.com wrote:
> > From: Richard Gong <richard.gong@intel.com>
> >
> > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> > aligns with the firmware settings.
>
> For fixes, you need to have a 'Fixes: ... ' line in the comment.
>
> This lets folks doing the stable branch know how far back to apply the fix.
It is a nice hint, but not always needed, and is NOT how to trigger a
patch to be backported to stable kernels. Please read the documentation
on how to properly do that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-28 8:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 21:43 [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0 richard.gong
2021-01-27 21:43 ` richard.gong
2021-01-27 22:00 ` Tom Rix
2021-01-28 8:01 ` Greg KH
2021-01-28 8:00 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).