* [PATCH] mips/kvm: Use BUG_ON instead of if condition followed by BUG
@ 2021-04-23 8:35 zhouchuangao
2021-06-21 9:53 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: zhouchuangao @ 2021-04-23 8:35 UTC (permalink / raw)
To: Huacai Chen, Aleksandar Markovic, Thomas Bogendoerfer,
linux-mips, kvm, linux-kernel
Cc: zhouchuangao
BUG_ON uses unlikely in if(), it can be optimized at compile time.
Usually, the condition in if() is not satisfied. In my opinion,
this can improve the efficiency of the multi-stage pipeline.
Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
---
arch/mips/kvm/tlb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c
index 1088114..a3b50d5 100644
--- a/arch/mips/kvm/tlb.c
+++ b/arch/mips/kvm/tlb.c
@@ -58,8 +58,7 @@ static int _kvm_mips_host_tlb_inv(unsigned long entryhi)
tlb_probe_hazard();
idx = read_c0_index();
- if (idx >= current_cpu_data.tlbsize)
- BUG();
+ BUG_ON(idx >= current_cpu_data.tlbsize);
if (idx >= 0) {
write_c0_entryhi(UNIQUE_ENTRYHI(idx));
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mips/kvm: Use BUG_ON instead of if condition followed by BUG
2021-04-23 8:35 [PATCH] mips/kvm: Use BUG_ON instead of if condition followed by BUG zhouchuangao
@ 2021-06-21 9:53 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2021-06-21 9:53 UTC (permalink / raw)
To: zhouchuangao
Cc: Huacai Chen, Aleksandar Markovic, linux-mips, kvm, linux-kernel
On Fri, Apr 23, 2021 at 01:35:09AM -0700, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
>
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
>
> Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
> ---
> arch/mips/kvm/tlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-21 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 8:35 [PATCH] mips/kvm: Use BUG_ON instead of if condition followed by BUG zhouchuangao
2021-06-21 9:53 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).