Re: Input issues - key down with no key up

[Neil Brown <neilb@cse.unsw.edu.au>]

On Tuesday August 19, vojtech@suse.cz wrote:
> > It behaved REALLY strangly until I fixed these typoes:
> > 
> > > +				mod_timer(&atkbd->timer,
> > > +					(test_bit(atkbd->keycode[code], &atkbd->dev.key)
> > > +						? HZ/30 : HZ/4) + HZ/100);
> > 
> > should be
> > 
> > > +				mod_timer(&atkbd->timer, jiffies + 
> > > +					(test_bit(atkbd->keycode[code], atkbd->dev.key)
> > > +						? HZ/30 : HZ/4) + HZ/100);
> 
> Thanks for spotting that! I originally had "!test_bit" there, and then
> removed the ! and forgot to swap the conditional values.

I swapped the "30" and the "4", it is is better still.  Auto-repeat of
normal keys is ok (I think - didn't test extensively).
control/shift is still a problem, though not quite as a bad

When I hold right-control down, evtest shows:

Event: time 1061335715.975639, type 1 (Key), code 97 (RightCtrl), value 1
Event: time 1061335715.975639, -------------- Config Sync ------------
Event: time 1061335716.014658, type 1 (Key), code 97 (RightCtrl), value 0
Event: time 1061335716.014659, -------------- Config Sync ------------
Event: time 1061335716.485899, type 1 (Key), code 97 (RightCtrl), value 1
Event: time 1061335716.485899, -------------- Config Sync ------------
Event: time 1061335716.734535, type 1 (Key), code 97 (RightCtrl), value 2
Event: time 1061335716.734536, -------------- Config Sync ------------
Event: time 1061335716.764555, type 1 (Key), code 97 (RightCtrl), value 2
Event: time 1061335716.764556, -------------- Config Sync ------------

so if I type another char between 30ms and 500ms after pressing
control, the control isn't noticed, else it is.

NeilBrown