From: Vojtech Pavlik <vojtech@suse.cz>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
Andries Brouwer <aebr@win.tue.nl>,
linux-kernel@vger.kernel.org
Subject: Re: Input issues - key down with no key up
Date: Tue, 19 Aug 2003 13:50:14 +0200 [thread overview]
Message-ID: <20030819115014.GA5403@ucw.cz> (raw)
In-Reply-To: <16194.3240.192318.806260@gargle.gargle.HOWL>
On Tue, Aug 19, 2003 at 09:40:24PM +1000, Neil Brown wrote:
> On Monday August 18, vojtech@suse.cz wrote:
> >
> > How about this patch? It tries to be a bit clever, but hopefully not too
> > much ...
> >
>
> Uhmm.. mixed.
>
> It behaved REALLY strangly until I fixed these typoes:
>
> > + mod_timer(&atkbd->timer,
> > + (test_bit(atkbd->keycode[code], &atkbd->dev.key)
> > + ? HZ/30 : HZ/4) + HZ/100);
>
> should be
>
> > + mod_timer(&atkbd->timer, jiffies +
> > + (test_bit(atkbd->keycode[code], atkbd->dev.key)
> > + ? HZ/30 : HZ/4) + HZ/100);
Thanks for spotting that! I originally had "!test_bit" there, and then
removed the ! and forgot to swap the conditional values.
> Then it sort-of worked - my problem keys gave nice up/down
> transitions.
Good to know. I'll test the rest on my keyboards here.
> However the hardware autorepeat and the software autorepeat seemed to
> interfere with each other and auto-repeat was rather erratic.
Yep, you'll need to make the software autorepeat settings longer.
They're HZ/4 and HZ/33 now, and need to be bigger than the in the above
fixed statement.
> More of a problem was that control and shift would auto-repeat, and
This is normal.
> would often appear to be "up" when I was holding them "down", so
> control-X keys strokes were not reliable.
Hmm, this is bad. I thought the code shouldn't be able to cause this (I
tried to make it so), I'll try to fix it.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2003-08-19 11:50 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-15 5:16 Input issues - key down with no key up Neil Brown
2003-08-15 7:46 ` Andries Brouwer
2003-08-15 10:58 ` Vojtech Pavlik
2003-08-15 12:36 ` Andries Brouwer
2003-08-15 12:43 ` Vojtech Pavlik
2003-08-15 13:27 ` Jamie Lokier
2003-08-15 13:52 ` Vojtech Pavlik
2003-08-15 14:02 ` Jamie Lokier
2003-08-15 15:05 ` Jason Lunz
2003-08-15 13:04 ` Jamie Lokier
2003-08-15 13:10 ` Vojtech Pavlik
2003-08-15 13:33 ` Jamie Lokier
2003-08-15 13:53 ` Vojtech Pavlik
2003-08-16 13:02 ` Maciej W. Rozycki
2003-08-16 14:09 ` Jamie Lokier
2003-08-17 21:54 ` Vojtech Pavlik
2003-08-18 12:22 ` Maciej W. Rozycki
2003-08-18 10:29 ` Andries Brouwer
2003-08-19 13:04 ` Maciej W. Rozycki
2003-08-19 17:48 ` Andries Brouwer
2003-08-21 11:37 ` Maciej W. Rozycki
2003-08-21 12:44 ` Andries Brouwer
2003-08-21 13:45 ` Maciej W. Rozycki
2003-08-21 14:28 ` Andries Brouwer
2003-08-21 14:38 ` Maciej W. Rozycki
2003-08-21 13:48 ` Jamie Lokier
2003-08-21 14:08 ` Maciej W. Rozycki
2003-08-21 14:14 ` Vojtech Pavlik
2003-08-21 14:33 ` Maciej W. Rozycki
2003-08-21 14:44 ` Andries Brouwer
2003-08-21 15:03 ` Maciej W. Rozycki
2003-08-21 15:29 ` Vojtech Pavlik
2003-08-16 13:01 ` Maciej W. Rozycki
2003-08-15 12:46 ` Neil Brown
2003-08-15 12:54 ` Vojtech Pavlik
2003-08-15 13:52 ` Andries Brouwer
2003-08-15 14:13 ` Vojtech Pavlik
2003-08-16 7:57 ` Neil Brown
2003-08-18 16:01 ` Vojtech Pavlik
2003-08-19 11:40 ` Neil Brown
2003-08-19 11:50 ` Vojtech Pavlik [this message]
2003-08-19 23:59 ` Neil Brown
2003-08-20 22:36 ` Andries Brouwer
2003-08-20 22:58 ` Jamie Lokier
2003-08-20 23:52 ` Andries Brouwer
2003-08-21 0:03 ` Jamie Lokier
2003-08-21 0:33 ` Andries Brouwer
2003-08-21 1:36 ` Jamie Lokier
2003-08-21 8:08 ` Vojtech Pavlik
2003-08-21 8:06 ` Vojtech Pavlik
2003-08-21 11:40 ` Maciej W. Rozycki
2003-08-21 12:48 ` Andries Brouwer
2003-08-21 13:22 ` Jamie Lokier
2003-08-21 13:29 ` Maciej W. Rozycki
2003-08-21 8:01 ` Vojtech Pavlik
2003-08-22 0:27 ` Andries Brouwer
2003-08-22 7:33 ` Vojtech Pavlik
2003-08-25 4:22 ` Jamie Lokier
2003-08-25 8:22 ` Vojtech Pavlik
2003-08-25 19:36 ` Jamie Lokier
2003-09-03 8:06 ` Pavel Machek
2003-08-22 13:35 ` Maciej W. Rozycki
2003-08-16 15:15 John Bradford
2003-08-18 11:53 ` Maciej W. Rozycki
2003-08-19 19:37 John Bradford
2003-08-19 23:58 ` Jamie Lokier
2003-08-20 5:59 John Bradford
2003-08-20 15:17 ` Jamie Lokier
2003-08-21 12:11 John Bradford
2003-08-21 12:26 ` Vojtech Pavlik
2003-08-23 12:30 Norman Diamond
2003-08-25 4:24 ` Jamie Lokier
2003-08-25 12:15 ` Norman Diamond
2003-08-25 8:45 John Bradford
2003-08-25 12:47 John Bradford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030819115014.GA5403@ucw.cz \
--to=vojtech@suse.cz \
--cc=aebr@win.tue.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).