linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string
@ 2021-05-02  0:12 brookxu
  2021-05-03 12:50 ` Steven Rostedt
  2021-05-14 22:30 ` Steven Rostedt
  0 siblings, 2 replies; 3+ messages in thread
From: brookxu @ 2021-05-02  0:12 UTC (permalink / raw)
  To: rostedt, mingo; +Cc: linux-kernel

From: Chunguang Xu <brookxu@tencent.com>

Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
string is better.

v2: replace some space with tab.

Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
 include/trace/events/writeback.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 1efa463..7c78c04 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -36,7 +36,8 @@
 	EM( WB_REASON_PERIODIC,			"periodic")		\
 	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
 	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
-	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
+	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
+	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
 
 WB_WORK_REASON
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string
  2021-05-02  0:12 [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string brookxu
@ 2021-05-03 12:50 ` Steven Rostedt
  2021-05-14 22:30 ` Steven Rostedt
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2021-05-03 12:50 UTC (permalink / raw)
  To: brookxu; +Cc: mingo, linux-kernel, Dave Chinner, Jens Axboe


This should go through the folks that maintain the write back trace events.

-- Steve


On Sun,  2 May 2021 08:12:27 +0800
brookxu <brookxu.cn@gmail.com> wrote:

> From: Chunguang Xu <brookxu@tencent.com>
> 
> Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
> string is better.
> 
> v2: replace some space with tab.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> ---
>  include/trace/events/writeback.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 1efa463..7c78c04 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -36,7 +36,8 @@
>  	EM( WB_REASON_PERIODIC,			"periodic")		\
>  	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
>  	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
> -	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
> +	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
> +	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
>  
>  WB_WORK_REASON
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string
  2021-05-02  0:12 [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string brookxu
  2021-05-03 12:50 ` Steven Rostedt
@ 2021-05-14 22:30 ` Steven Rostedt
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2021-05-14 22:30 UTC (permalink / raw)
  To: brookxu, Andrew Morton; +Cc: mingo, linux-kernel


Andrew,

Would you like to take this?

-- Steve


On Sun,  2 May 2021 08:12:27 +0800
brookxu <brookxu.cn@gmail.com> wrote:

> From: Chunguang Xu <brookxu@tencent.com>
> 
> Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
> string is better.
> 
> v2: replace some space with tab.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> ---
>  include/trace/events/writeback.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 1efa463..7c78c04 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -36,7 +36,8 @@
>  	EM( WB_REASON_PERIODIC,			"periodic")		\
>  	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
>  	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
> -	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
> +	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
> +	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
>  
>  WB_WORK_REASON
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-14 22:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-02  0:12 [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string brookxu
2021-05-03 12:50 ` Steven Rostedt
2021-05-14 22:30 ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).