linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 net-next resend] ibmvnic: remove default label from to_string switch
@ 2021-05-20  6:50 Michal Suchanek
  2021-05-20 22:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchanek @ 2021-05-20  6:50 UTC (permalink / raw)
  To: netdev
  Cc: Michal Suchanek, Lijun Pan, Dany Madden, Sukadev Bhattiprolu,
	Thomas Falcon, Michael Ellerman, Benjamin Herrenschmidt,
	Paul Mackerras, David S. Miller, Jakub Kicinski, linuxppc-dev,
	linux-kernel

This way the compiler warns when a new value is added to the enum but
not to the string translation like:

drivers/net/ethernet/ibm/ibmvnic.c: In function 'adapter_state_to_string':
drivers/net/ethernet/ibm/ibmvnic.c:832:2: warning: enumeration value 'VNIC_FOOBAR' not handled in switch [-Wswitch]
  switch (state) {
  ^~~~~~
drivers/net/ethernet/ibm/ibmvnic.c: In function 'reset_reason_to_string':
drivers/net/ethernet/ibm/ibmvnic.c:1935:2: warning: enumeration value 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch]
  switch (reason) {
  ^~~~~~

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Acked-by: Lijun Pan <lijunp213@gmail.com>
Link: https://lore.kernel.org/netdev/CAOhMmr701LecfuNM+EozqbiTxFvDiXjFdY2aYeKJYaXq9kqVDg@mail.gmail.com/
---
v2: Fix typo in commit message
---
 drivers/net/ethernet/ibm/ibmvnic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 5788bb956d73..4d439413f6d9 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -846,9 +846,8 @@ static const char *adapter_state_to_string(enum vnic_state state)
 		return "REMOVING";
 	case VNIC_REMOVED:
 		return "REMOVED";
-	default:
-		return "UNKNOWN";
 	}
+	return "UNKNOWN";
 }
 
 static int ibmvnic_login(struct net_device *netdev)
@@ -1946,9 +1945,8 @@ static const char *reset_reason_to_string(enum ibmvnic_reset_reason reason)
 		return "TIMEOUT";
 	case VNIC_RESET_CHANGE_PARAM:
 		return "CHANGE_PARAM";
-	default:
-		return "UNKNOWN";
 	}
+	return "UNKNOWN";
 }
 
 /*
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ibmvnic: remove default label from to_string switch
@ 2021-05-03 20:47 David Miller
  2021-05-04 19:19 ` [PATCH v2 net-next resend] " Michal Suchanek
  0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2021-05-03 20:47 UTC (permalink / raw)
  To: lijunp213
  Cc: msuchanek, netdev, mpe, benh, paulus, drt, sukadev, tlfalcon,
	kuba, linuxppc-dev, linux-kernel

From: Lijun Pan <lijunp213@gmail.com>
Date: Mon, 3 May 2021 13:21:00 -0500

> On Mon, May 3, 2021 at 5:54 AM Michal Suchanek <msuchanek@suse.de> wrote:
>>
>> This way the compiler warns when a new value is added to the enum but
>> not the string transation like:
> 
> s/transation/translation/
> 
> This trick works.
> Since the original code does not generate gcc warnings/errors, should
> this patch be sent to net-next as an improvement?

Yes.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-20 22:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20  6:50 [PATCH v2 net-next resend] ibmvnic: remove default label from to_string switch Michal Suchanek
2021-05-20 22:50 ` patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2021-05-03 20:47 [PATCH] " David Miller
2021-05-04 19:19 ` [PATCH v2 net-next resend] " Michal Suchanek
2021-05-04 19:39   ` Lijun Pan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).