* [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc()
@ 2021-06-18 15:16 Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 2/7] irqchip/alpine-msi: " Andy Shevchenko
` (7 more replies)
0 siblings, 8 replies; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-partition-percpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-partition-percpu.c b/drivers/irqchip/irq-partition-percpu.c
index 89c23a1566dc..8e76d2913e6b 100644
--- a/drivers/irqchip/irq-partition-percpu.c
+++ b/drivers/irqchip/irq-partition-percpu.c
@@ -215,8 +215,7 @@ struct partition_desc *partition_create_desc(struct fwnode_handle *fwnode,
goto out;
desc->domain = d;
- desc->bitmap = kcalloc(BITS_TO_LONGS(nr_parts), sizeof(long),
- GFP_KERNEL);
+ desc->bitmap = bitmap_zalloc(nr_parts, GFP_KERNEL);
if (WARN_ON(!desc->bitmap))
goto out;
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 2/7] irqchip/alpine-msi: Switch to bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
@ 2021-06-18 15:16 ` Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 3/7] irqchip/gic-v2m: " Andy Shevchenko
` (6 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-alpine-msi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
index ede02dc2bcd0..5ddb8e578ac6 100644
--- a/drivers/irqchip/irq-alpine-msi.c
+++ b/drivers/irqchip/irq-alpine-msi.c
@@ -267,9 +267,7 @@ static int alpine_msix_init(struct device_node *node,
goto err_priv;
}
- priv->msi_map = kcalloc(BITS_TO_LONGS(priv->num_spis),
- sizeof(*priv->msi_map),
- GFP_KERNEL);
+ priv->msi_map = bitmap_zalloc(priv->num_spis, GFP_KERNEL);
if (!priv->msi_map) {
ret = -ENOMEM;
goto err_priv;
@@ -285,7 +283,7 @@ static int alpine_msix_init(struct device_node *node,
return 0;
err_map:
- kfree(priv->msi_map);
+ bitmap_free(priv->msi_map);
err_priv:
kfree(priv);
return ret;
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 3/7] irqchip/gic-v2m: Switch to bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 2/7] irqchip/alpine-msi: " Andy Shevchenko
@ 2021-06-18 15:16 ` Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 4/7] irqchip/gic-v3: " Andy Shevchenko
` (5 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-gic-v2m.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index be9ea6fd6f8b..9349fc68b81a 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -269,7 +269,7 @@ static void gicv2m_teardown(void)
list_for_each_entry_safe(v2m, tmp, &v2m_nodes, entry) {
list_del(&v2m->entry);
- kfree(v2m->bm);
+ bitmap_free(v2m->bm);
iounmap(v2m->base);
of_node_put(to_of_node(v2m->fwnode));
if (is_fwnode_irqchip(v2m->fwnode))
@@ -386,8 +386,7 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
break;
}
}
- v2m->bm = kcalloc(BITS_TO_LONGS(v2m->nr_spis), sizeof(long),
- GFP_KERNEL);
+ v2m->bm = bitmap_zalloc(v2m->nr_spis, GFP_KERNEL);
if (!v2m->bm) {
ret = -ENOMEM;
goto err_iounmap;
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 4/7] irqchip/gic-v3: Switch to bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 2/7] irqchip/alpine-msi: " Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 3/7] irqchip/gic-v2m: " Andy Shevchenko
@ 2021-06-18 15:16 ` Andy Shevchenko
2021-07-26 17:05 ` Marc Zyngier
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc() Andy Shevchenko
` (4 subsequent siblings)
7 siblings, 2 replies; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-gic-v3-its.c | 9 ++++-----
drivers/irqchip/irq-gic-v3-mbi.c | 5 ++---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index ba39668c3e08..daa5b1c968f0 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -2140,7 +2140,7 @@ static unsigned long *its_lpi_alloc(int nr_irqs, u32 *base, int *nr_ids)
if (err)
goto out;
- bitmap = kcalloc(BITS_TO_LONGS(nr_irqs), sizeof (long), GFP_ATOMIC);
+ bitmap = bitmap_zalloc(nr_irqs, GFP_ATOMIC);
if (!bitmap)
goto out;
@@ -2156,7 +2156,7 @@ static unsigned long *its_lpi_alloc(int nr_irqs, u32 *base, int *nr_ids)
static void its_lpi_free(unsigned long *bitmap, u32 base, u32 nr_ids)
{
WARN_ON(free_lpi_range(base, nr_ids));
- kfree(bitmap);
+ bitmap_free(bitmap);
}
static void gic_reset_prop_table(void *va)
@@ -3376,8 +3376,7 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
if (alloc_lpis) {
lpi_map = its_lpi_alloc(nvecs, &lpi_base, &nr_lpis);
if (lpi_map)
- col_map = kcalloc(nr_lpis, sizeof(*col_map),
- GFP_KERNEL);
+ col_map = kcalloc(nr_lpis, sizeof(*col_map), GFP_KERNEL);
} else {
col_map = kcalloc(nr_ites, sizeof(*col_map), GFP_KERNEL);
nr_lpis = 0;
@@ -3387,7 +3386,7 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
if (!dev || !itt || !col_map || (!lpi_map && alloc_lpis)) {
kfree(dev);
kfree(itt);
- kfree(lpi_map);
+ bitmap_free(lpi_map);
kfree(col_map);
return NULL;
}
diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c
index e81e89a81cb5..b84c9c2eccdc 100644
--- a/drivers/irqchip/irq-gic-v3-mbi.c
+++ b/drivers/irqchip/irq-gic-v3-mbi.c
@@ -290,8 +290,7 @@ int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent)
if (ret)
goto err_free_mbi;
- mbi_ranges[n].bm = kcalloc(BITS_TO_LONGS(mbi_ranges[n].nr_spis),
- sizeof(long), GFP_KERNEL);
+ mbi_ranges[n].bm = bitmap_zalloc(mbi_ranges[n].nr_spis, GFP_KERNEL);
if (!mbi_ranges[n].bm) {
ret = -ENOMEM;
goto err_free_mbi;
@@ -329,7 +328,7 @@ int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent)
err_free_mbi:
if (mbi_ranges) {
for (n = 0; n < mbi_range_nr; n++)
- kfree(mbi_ranges[n].bm);
+ bitmap_free(mbi_ranges[n].bm);
kfree(mbi_ranges);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
` (2 preceding siblings ...)
2021-06-18 15:16 ` [PATCH v1 4/7] irqchip/gic-v3: " Andy Shevchenko
@ 2021-06-18 15:16 ` Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 6/7] irqchip/mvebu-gicp: " Andy Shevchenko
` (3 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to devm_bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-ls-scfg-msi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
index 55322da51c56..b4927e425f7b 100644
--- a/drivers/irqchip/irq-ls-scfg-msi.c
+++ b/drivers/irqchip/irq-ls-scfg-msi.c
@@ -362,10 +362,7 @@ static int ls_scfg_msi_probe(struct platform_device *pdev)
msi_data->irqs_num = MSI_IRQS_PER_MSIR *
(1 << msi_data->cfg->ibs_shift);
- msi_data->used = devm_kcalloc(&pdev->dev,
- BITS_TO_LONGS(msi_data->irqs_num),
- sizeof(*msi_data->used),
- GFP_KERNEL);
+ msi_data->used = devm_bitmap_zalloc(&pdev->dev, msi_data->irqs_num, GFP_KERNEL);
if (!msi_data->used)
return -ENOMEM;
/*
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 6/7] irqchip/mvebu-gicp: Switch to devm_bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
` (3 preceding siblings ...)
2021-06-18 15:16 ` [PATCH v1 5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc() Andy Shevchenko
@ 2021-06-18 15:16 ` Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc() Andy Shevchenko
` (2 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to devm_bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-mvebu-gicp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
index 3be5c5dba1da..fe88a782173d 100644
--- a/drivers/irqchip/irq-mvebu-gicp.c
+++ b/drivers/irqchip/irq-mvebu-gicp.c
@@ -210,9 +210,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
gicp->spi_cnt += gicp->spi_ranges[i].count;
}
- gicp->spi_bitmap = devm_kcalloc(&pdev->dev,
- BITS_TO_LONGS(gicp->spi_cnt), sizeof(long),
- GFP_KERNEL);
+ gicp->spi_bitmap = devm_bitmap_zalloc(&pdev->dev, gicp->spi_cnt, GFP_KERNEL);
if (!gicp->spi_bitmap)
return -ENOMEM;
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
` (4 preceding siblings ...)
2021-06-18 15:16 ` [PATCH v1 6/7] irqchip/mvebu-gicp: " Andy Shevchenko
@ 2021-06-18 15:16 ` Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] irqchip/partitions: " irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [PATCH v1 1/7] irqchip: " Marc Zyngier
7 siblings, 1 reply; 16+ messages in thread
From: Andy Shevchenko @ 2021-06-18 15:16 UTC (permalink / raw)
To: Marc Zyngier, Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Tsahee Zidenberg, Antoine Tenart, Thomas Gleixner, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/irqchip/irq-mvebu-odmi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c
index b4d367868dbb..dc4145abdd6f 100644
--- a/drivers/irqchip/irq-mvebu-odmi.c
+++ b/drivers/irqchip/irq-mvebu-odmi.c
@@ -171,8 +171,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
if (!odmis)
return -ENOMEM;
- odmis_bm = kcalloc(BITS_TO_LONGS(odmis_count * NODMIS_PER_FRAME),
- sizeof(long), GFP_KERNEL);
+ odmis_bm = bitmap_zalloc(odmis_count * NODMIS_PER_FRAME, GFP_KERNEL);
if (!odmis_bm) {
ret = -ENOMEM;
goto err_alloc;
@@ -227,7 +226,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
if (odmi->base && !IS_ERR(odmi->base))
iounmap(odmis[i].base);
}
- kfree(odmis_bm);
+ bitmap_free(odmis_bm);
err_alloc:
kfree(odmis);
return ret;
--
2.30.2
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v1 4/7] irqchip/gic-v3: Switch to bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 4/7] irqchip/gic-v3: " Andy Shevchenko
@ 2021-07-26 17:05 ` Marc Zyngier
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
1 sibling, 0 replies; 16+ messages in thread
From: Marc Zyngier @ 2021-07-26 17:05 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, linux-kernel, Tsahee Zidenberg, Antoine Tenart,
Thomas Gleixner, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth
On Fri, 18 Jun 2021 16:16:54 +0100,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> @@ -3376,8 +3376,7 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
> if (alloc_lpis) {
> lpi_map = its_lpi_alloc(nvecs, &lpi_base, &nr_lpis);
> if (lpi_map)
> - col_map = kcalloc(nr_lpis, sizeof(*col_map),
> - GFP_KERNEL);
> + col_map = kcalloc(nr_lpis, sizeof(*col_map), GFP_KERNEL);
This looks like an unrelated/spurious change. I've reverted it locally.
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/mvebu-odmi: Switch to bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc() Andy Shevchenko
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
0 siblings, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: c980983daebf10633c922998bade3a7fd74f1fc1
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/c980983daebf10633c922998bade3a7fd74f1fc1
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:57 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:04:11 +01:00
irqchip/mvebu-odmi: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-7-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-mvebu-odmi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c
index b4d3678..dc4145a 100644
--- a/drivers/irqchip/irq-mvebu-odmi.c
+++ b/drivers/irqchip/irq-mvebu-odmi.c
@@ -171,8 +171,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
if (!odmis)
return -ENOMEM;
- odmis_bm = kcalloc(BITS_TO_LONGS(odmis_count * NODMIS_PER_FRAME),
- sizeof(long), GFP_KERNEL);
+ odmis_bm = bitmap_zalloc(odmis_count * NODMIS_PER_FRAME, GFP_KERNEL);
if (!odmis_bm) {
ret = -ENOMEM;
goto err_alloc;
@@ -227,7 +226,7 @@ err_unmap:
if (odmi->base && !IS_ERR(odmi->base))
iounmap(odmis[i].base);
}
- kfree(odmis_bm);
+ bitmap_free(odmis_bm);
err_alloc:
kfree(odmis);
return ret;
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/mvebu-gicp: Switch to devm_bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 6/7] irqchip/mvebu-gicp: " Andy Shevchenko
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
0 siblings, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 3db3969f5375fe0a43c03cb4b55ed643585b140d
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3db3969f5375fe0a43c03cb4b55ed643585b140d
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:56 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:04:10 +01:00
irqchip/mvebu-gicp: Switch to devm_bitmap_zalloc()
Switch to devm_bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-6-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-mvebu-gicp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
index 3be5c5d..fe88a78 100644
--- a/drivers/irqchip/irq-mvebu-gicp.c
+++ b/drivers/irqchip/irq-mvebu-gicp.c
@@ -210,9 +210,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
gicp->spi_cnt += gicp->spi_ranges[i].count;
}
- gicp->spi_bitmap = devm_kcalloc(&pdev->dev,
- BITS_TO_LONGS(gicp->spi_cnt), sizeof(long),
- GFP_KERNEL);
+ gicp->spi_bitmap = devm_bitmap_zalloc(&pdev->dev, gicp->spi_cnt, GFP_KERNEL);
if (!gicp->spi_bitmap)
return -ENOMEM;
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/gic-v3: Switch to bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 4/7] irqchip/gic-v3: " Andy Shevchenko
2021-07-26 17:05 ` Marc Zyngier
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
1 sibling, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: ff5fe8867a5feaf90b1cb9b766f3de3a1caf9f33
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/ff5fe8867a5feaf90b1cb9b766f3de3a1caf9f33
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:54 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:04:01 +01:00
irqchip/gic-v3: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-4-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-gic-v3-its.c | 6 +++---
drivers/irqchip/irq-gic-v3-mbi.c | 5 ++---
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index ba39668..7f40dca 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -2140,7 +2140,7 @@ static unsigned long *its_lpi_alloc(int nr_irqs, u32 *base, int *nr_ids)
if (err)
goto out;
- bitmap = kcalloc(BITS_TO_LONGS(nr_irqs), sizeof (long), GFP_ATOMIC);
+ bitmap = bitmap_zalloc(nr_irqs, GFP_ATOMIC);
if (!bitmap)
goto out;
@@ -2156,7 +2156,7 @@ out:
static void its_lpi_free(unsigned long *bitmap, u32 base, u32 nr_ids)
{
WARN_ON(free_lpi_range(base, nr_ids));
- kfree(bitmap);
+ bitmap_free(bitmap);
}
static void gic_reset_prop_table(void *va)
@@ -3387,7 +3387,7 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
if (!dev || !itt || !col_map || (!lpi_map && alloc_lpis)) {
kfree(dev);
kfree(itt);
- kfree(lpi_map);
+ bitmap_free(lpi_map);
kfree(col_map);
return NULL;
}
diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c
index e81e89a..b84c9c2 100644
--- a/drivers/irqchip/irq-gic-v3-mbi.c
+++ b/drivers/irqchip/irq-gic-v3-mbi.c
@@ -290,8 +290,7 @@ int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent)
if (ret)
goto err_free_mbi;
- mbi_ranges[n].bm = kcalloc(BITS_TO_LONGS(mbi_ranges[n].nr_spis),
- sizeof(long), GFP_KERNEL);
+ mbi_ranges[n].bm = bitmap_zalloc(mbi_ranges[n].nr_spis, GFP_KERNEL);
if (!mbi_ranges[n].bm) {
ret = -ENOMEM;
goto err_free_mbi;
@@ -329,7 +328,7 @@ int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent)
err_free_mbi:
if (mbi_ranges) {
for (n = 0; n < mbi_range_nr; n++)
- kfree(mbi_ranges[n].bm);
+ bitmap_free(mbi_ranges[n].bm);
kfree(mbi_ranges);
}
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc() Andy Shevchenko
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
0 siblings, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 43a1965fc5ae911c83a49ad793677aa6ba0e18e2
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/43a1965fc5ae911c83a49ad793677aa6ba0e18e2
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:55 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:04:10 +01:00
irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc()
Switch to devm_bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-5-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-ls-scfg-msi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
index 55322da..b4927e4 100644
--- a/drivers/irqchip/irq-ls-scfg-msi.c
+++ b/drivers/irqchip/irq-ls-scfg-msi.c
@@ -362,10 +362,7 @@ static int ls_scfg_msi_probe(struct platform_device *pdev)
msi_data->irqs_num = MSI_IRQS_PER_MSIR *
(1 << msi_data->cfg->ibs_shift);
- msi_data->used = devm_kcalloc(&pdev->dev,
- BITS_TO_LONGS(msi_data->irqs_num),
- sizeof(*msi_data->used),
- GFP_KERNEL);
+ msi_data->used = devm_bitmap_zalloc(&pdev->dev, msi_data->irqs_num, GFP_KERNEL);
if (!msi_data->used)
return -ENOMEM;
/*
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/gic-v2m: Switch to bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 3/7] irqchip/gic-v2m: " Andy Shevchenko
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
0 siblings, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 81d3c9e7b43e9426e67a5df66d51a5f2bfce0362
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/81d3c9e7b43e9426e67a5df66d51a5f2bfce0362
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:53 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:01:44 +01:00
irqchip/gic-v2m: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-3-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-gic-v2m.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index be9ea6f..9349fc6 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -269,7 +269,7 @@ static void gicv2m_teardown(void)
list_for_each_entry_safe(v2m, tmp, &v2m_nodes, entry) {
list_del(&v2m->entry);
- kfree(v2m->bm);
+ bitmap_free(v2m->bm);
iounmap(v2m->base);
of_node_put(to_of_node(v2m->fwnode));
if (is_fwnode_irqchip(v2m->fwnode))
@@ -386,8 +386,7 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
break;
}
}
- v2m->bm = kcalloc(BITS_TO_LONGS(v2m->nr_spis), sizeof(long),
- GFP_KERNEL);
+ v2m->bm = bitmap_zalloc(v2m->nr_spis, GFP_KERNEL);
if (!v2m->bm) {
ret = -ENOMEM;
goto err_iounmap;
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/alpine-msi: Switch to bitmap_zalloc()
2021-06-18 15:16 ` [PATCH v1 2/7] irqchip/alpine-msi: " Andy Shevchenko
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
0 siblings, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 3f1808f63f0458762403549b3d975ef6e971b6e0
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3f1808f63f0458762403549b3d975ef6e971b6e0
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:52 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:01:44 +01:00
irqchip/alpine-msi: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-2-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-alpine-msi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
index ede02dc..5ddb8e5 100644
--- a/drivers/irqchip/irq-alpine-msi.c
+++ b/drivers/irqchip/irq-alpine-msi.c
@@ -267,9 +267,7 @@ static int alpine_msix_init(struct device_node *node,
goto err_priv;
}
- priv->msi_map = kcalloc(BITS_TO_LONGS(priv->num_spis),
- sizeof(*priv->msi_map),
- GFP_KERNEL);
+ priv->msi_map = bitmap_zalloc(priv->num_spis, GFP_KERNEL);
if (!priv->msi_map) {
ret = -ENOMEM;
goto err_priv;
@@ -285,7 +283,7 @@ static int alpine_msix_init(struct device_node *node,
return 0;
err_map:
- kfree(priv->msi_map);
+ bitmap_free(priv->msi_map);
err_priv:
kfree(priv);
return ret;
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/partitions: Switch to bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
` (5 preceding siblings ...)
2021-06-18 15:16 ` [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc() Andy Shevchenko
@ 2021-07-26 17:12 ` irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [PATCH v1 1/7] irqchip: " Marc Zyngier
7 siblings, 0 replies; 16+ messages in thread
From: irqchip-bot for Andy Shevchenko @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 4cad4da0795e9c03973d5456945394aee75bdf0f
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/4cad4da0795e9c03973d5456945394aee75bdf0f
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 18 Jun 2021 18:16:51 +03:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 26 Jul 2021 18:01:27 +01:00
irqchip/partitions: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210618151657.65305-1-andriy.shevchenko@linux.intel.com
---
drivers/irqchip/irq-partition-percpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-partition-percpu.c b/drivers/irqchip/irq-partition-percpu.c
index 89c23a1..8e76d29 100644
--- a/drivers/irqchip/irq-partition-percpu.c
+++ b/drivers/irqchip/irq-partition-percpu.c
@@ -215,8 +215,7 @@ struct partition_desc *partition_create_desc(struct fwnode_handle *fwnode,
goto out;
desc->domain = d;
- desc->bitmap = kcalloc(BITS_TO_LONGS(nr_parts), sizeof(long),
- GFP_KERNEL);
+ desc->bitmap = bitmap_zalloc(nr_parts, GFP_KERNEL);
if (WARN_ON(!desc->bitmap))
goto out;
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc()
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
` (6 preceding siblings ...)
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] irqchip/partitions: " irqchip-bot for Andy Shevchenko
@ 2021-07-26 17:12 ` Marc Zyngier
7 siblings, 0 replies; 16+ messages in thread
From: Marc Zyngier @ 2021-07-26 17:12 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, Andy Shevchenko
Cc: Andrew Lunn, Tsahee Zidenberg, Sebastian Hesselbarth,
Gregory Clement, Antoine Tenart, Thomas Gleixner
On Fri, 18 Jun 2021 18:16:51 +0300, Andy Shevchenko wrote:
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void *.
Applied to irq/irqchip-next, thanks!
[1/7] irqchip: Switch to bitmap_zalloc()
commit: 4cad4da0795e9c03973d5456945394aee75bdf0f
[2/7] irqchip/alpine-msi: Switch to bitmap_zalloc()
commit: 3f1808f63f0458762403549b3d975ef6e971b6e0
[3/7] irqchip/gic-v2m: Switch to bitmap_zalloc()
commit: 81d3c9e7b43e9426e67a5df66d51a5f2bfce0362
[4/7] irqchip/gic-v3: Switch to bitmap_zalloc()
commit: ff5fe8867a5feaf90b1cb9b766f3de3a1caf9f33
[5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc()
commit: 43a1965fc5ae911c83a49ad793677aa6ba0e18e2
[6/7] irqchip/mvebu-gicp: Switch to devm_bitmap_zalloc()
commit: 3db3969f5375fe0a43c03cb4b55ed643585b140d
[7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc()
commit: c980983daebf10633c922998bade3a7fd74f1fc1
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-07-26 17:26 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 2/7] irqchip/alpine-msi: " Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 3/7] irqchip/gic-v2m: " Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 4/7] irqchip/gic-v3: " Andy Shevchenko
2021-07-26 17:05 ` Marc Zyngier
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc() Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 6/7] irqchip/mvebu-gicp: " Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc() Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] irqchip/partitions: " irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [PATCH v1 1/7] irqchip: " Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).