linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard
@ 2021-07-26  9:45 Brent Lu
  2021-07-26 14:08 ` Pierre-Louis Bossart
  2021-07-26 21:34 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Brent Lu @ 2021-07-26  9:45 UTC (permalink / raw)
  To: alsa-devel
  Cc: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
	Mark Brown, Jaroslav Kysela, Takashi Iwai, Guennadi Liakhovetski,
	Zou Wei, Kuninori Morimoto, Brent Lu, Rander Wang, Paul Olaru,
	linux-kernel

The default codec for speaker amp's DAI Link is max98373 and will be
overwritten in probe function if the board id is sof_da7219_mx98360a.
However, the probe function does not do it because the board id is
changed in earlier commit.

Fixes: 1cc04d195dc2 ("ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters")
Signed-off-by: Brent Lu <brent.lu@intel.com>
---
 sound/soc/intel/boards/sof_da7219_max98373.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c
index 896251d742fe..b7b3b0bf994a 100644
--- a/sound/soc/intel/boards/sof_da7219_max98373.c
+++ b/sound/soc/intel/boards/sof_da7219_max98373.c
@@ -404,7 +404,7 @@ static int audio_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	/* By default dais[0] is configured for max98373 */
-	if (!strcmp(pdev->name, "sof_da7219_max98360a")) {
+	if (!strcmp(pdev->name, "sof_da7219_mx98360a")) {
 		dais[0] = (struct snd_soc_dai_link) {
 			.name = "SSP1-Codec",
 			.id = 0,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard
  2021-07-26  9:45 [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard Brent Lu
@ 2021-07-26 14:08 ` Pierre-Louis Bossart
  2021-07-26 21:34 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2021-07-26 14:08 UTC (permalink / raw)
  To: Brent Lu, alsa-devel
  Cc: Guennadi Liakhovetski, Cezary Rojewski, Kuninori Morimoto,
	linux-kernel, Takashi Iwai, Jie Yang, Liam Girdwood, Mark Brown,
	Paul Olaru, Zou Wei, Rander Wang



On 7/26/21 4:45 AM, Brent Lu wrote:
> The default codec for speaker amp's DAI Link is max98373 and will be
> overwritten in probe function if the board id is sof_da7219_mx98360a.
> However, the probe function does not do it because the board id is
> changed in earlier commit.
> 
> Fixes: 1cc04d195dc2 ("ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters")
> Signed-off-by: Brent Lu <brent.lu@intel.com>

Nice catch indeed.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>  sound/soc/intel/boards/sof_da7219_max98373.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c
> index 896251d742fe..b7b3b0bf994a 100644
> --- a/sound/soc/intel/boards/sof_da7219_max98373.c
> +++ b/sound/soc/intel/boards/sof_da7219_max98373.c
> @@ -404,7 +404,7 @@ static int audio_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	/* By default dais[0] is configured for max98373 */
> -	if (!strcmp(pdev->name, "sof_da7219_max98360a")) {
> +	if (!strcmp(pdev->name, "sof_da7219_mx98360a")) {
>  		dais[0] = (struct snd_soc_dai_link) {
>  			.name = "SSP1-Codec",
>  			.id = 0,
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard
  2021-07-26  9:45 [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard Brent Lu
  2021-07-26 14:08 ` Pierre-Louis Bossart
@ 2021-07-26 21:34 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-07-26 21:34 UTC (permalink / raw)
  To: alsa-devel, Brent Lu
  Cc: Mark Brown, Guennadi Liakhovetski, Zou Wei, Pierre-Louis Bossart,
	linux-kernel, Liam Girdwood, Jie Yang, Rander Wang,
	Kuninori Morimoto, Jaroslav Kysela, Takashi Iwai,
	Cezary Rojewski, Paul Olaru

On Mon, 26 Jul 2021 17:45:25 +0800, Brent Lu wrote:
> The default codec for speaker amp's DAI Link is max98373 and will be
> overwritten in probe function if the board id is sof_da7219_mx98360a.
> However, the probe function does not do it because the board id is
> changed in earlier commit.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard
      commit: 0f32d9eb38c13c32895b5bf695eac639cee02d6c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-26 21:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26  9:45 [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard Brent Lu
2021-07-26 14:08 ` Pierre-Louis Bossart
2021-07-26 21:34 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).