[PATCH net-next] devlink: Fix port_type_set function pointer check

[PATCH net-next] devlink: Fix port_type_set function pointer check

[Leon Romanovsky]

From: Leon Romanovsky <leonro@nvidia.com>

Fix a typo when checking existence of port_type_set function pointer.

Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 net/core/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index d3b16dd9f64e..b02d54ab59ac 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1274,7 +1274,7 @@ static int devlink_port_type_set(struct devlink_port *devlink_port,
 {
 	int err;
 
-	if (devlink_port->devlink->ops->port_type_set)
+	if (!devlink_port->devlink->ops->port_type_set)
 		return -EOPNOTSUPP;
 
 	if (port_type == devlink_port->type)
-- 
2.31.1

Re: [PATCH net-next] devlink: Fix port_type_set function pointer check

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon,  9 Aug 2021 15:03:19 +0300 you wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Fix a typo when checking existence of port_type_set function pointer.
> 
> Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next] devlink: Fix port_type_set function pointer check
    https://git.kernel.org/netdev/net-next/c/2a2b6e3640c4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next] devlink: Fix port_type_set function pointer check

[Leon Romanovsky]

On Mon, Aug 09, 2021 at 12:40:05PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net-next.git (refs/heads/master):a

Dave, thanks a lot for your fast response.

> 
> On Mon,  9 Aug 2021 15:03:19 +0300 you wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> > 
> > Fix a typo when checking existence of port_type_set function pointer.
> > 
> > Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net-next] devlink: Fix port_type_set function pointer check
>     https://git.kernel.org/netdev/net-next/c/2a2b6e3640c4
> 
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
> 
>