* [PATCH net-next] devlink: Fix port_type_set function pointer check
@ 2021-08-09 12:03 Leon Romanovsky
2021-08-09 12:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2021-08-09 12:03 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: Leon Romanovsky, Jiri Pirko, linux-kernel, netdev, kernel test robot
From: Leon Romanovsky <leonro@nvidia.com>
Fix a typo when checking existence of port_type_set function pointer.
Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
net/core/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index d3b16dd9f64e..b02d54ab59ac 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1274,7 +1274,7 @@ static int devlink_port_type_set(struct devlink_port *devlink_port,
{
int err;
- if (devlink_port->devlink->ops->port_type_set)
+ if (!devlink_port->devlink->ops->port_type_set)
return -EOPNOTSUPP;
if (port_type == devlink_port->type)
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] devlink: Fix port_type_set function pointer check
2021-08-09 12:03 [PATCH net-next] devlink: Fix port_type_set function pointer check Leon Romanovsky
@ 2021-08-09 12:40 ` patchwork-bot+netdevbpf
2021-08-09 12:55 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-09 12:40 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: davem, kuba, leonro, jiri, linux-kernel, netdev, lkp
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 9 Aug 2021 15:03:19 +0300 you wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Fix a typo when checking existence of port_type_set function pointer.
>
> Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] devlink: Fix port_type_set function pointer check
https://git.kernel.org/netdev/net-next/c/2a2b6e3640c4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] devlink: Fix port_type_set function pointer check
2021-08-09 12:40 ` patchwork-bot+netdevbpf
@ 2021-08-09 12:55 ` Leon Romanovsky
0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2021-08-09 12:55 UTC (permalink / raw)
To: davem; +Cc: kuba, jiri, linux-kernel, netdev, lkp
On Mon, Aug 09, 2021 at 12:40:05PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net-next.git (refs/heads/master):a
Dave, thanks a lot for your fast response.
>
> On Mon, 9 Aug 2021 15:03:19 +0300 you wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > Fix a typo when checking existence of port_type_set function pointer.
> >
> > Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> >
> > [...]
>
> Here is the summary with links:
> - [net-next] devlink: Fix port_type_set function pointer check
> https://git.kernel.org/netdev/net-next/c/2a2b6e3640c4
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-09 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 12:03 [PATCH net-next] devlink: Fix port_type_set function pointer check Leon Romanovsky
2021-08-09 12:40 ` patchwork-bot+netdevbpf
2021-08-09 12:55 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).