* [PATCH] rtw89: fix error function parameter
@ 2021-10-19 3:53 cgel.zte
2021-10-19 5:21 ` Pkshih
2021-10-20 8:50 ` Kalle Valo
0 siblings, 2 replies; 10+ messages in thread
From: cgel.zte @ 2021-10-19 3:53 UTC (permalink / raw)
To: kvalo
Cc: davem, kuba, pkshih, lv.ruyi, linux-wireless, netdev,
linux-kernel, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING possible condition with no effect (if == else)
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
index b1b87f0aadbb..5c6ffca3a324 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
@@ -753,11 +753,11 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
if (is_2g)
rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
B_P1_MODE_SEL,
1, phy_idx);
else
rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
B_P1_MODE_SEL,
- 1, phy_idx);
+ 0, phy_idx);
/* SCO compensate FC setting */
sco_comp = rtw8852a_sco_mapping(central_ch);
rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* RE: [PATCH] rtw89: fix error function parameter
2021-10-19 3:53 [PATCH] rtw89: fix error function parameter cgel.zte
@ 2021-10-19 5:21 ` Pkshih
2021-10-20 8:50 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Pkshih @ 2021-10-19 5:21 UTC (permalink / raw)
To: cgel.zte, kvalo
Cc: davem, kuba, lv.ruyi, linux-wireless, netdev, linux-kernel, Zeal Robot
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Tuesday, October 19, 2021 11:53 AM
> To: kvalo@codeaurora.org
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal
> Robot <zealci@zte.com.cn>
> Subject: [PATCH] rtw89: fix error function parameter
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Thanks for the catch.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -753,11 +753,11 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
> if (is_2g)
> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> 1, phy_idx);
> else
> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> - 1, phy_idx);
> + 0, phy_idx);
> /* SCO compensate FC setting */
> sco_comp = rtw8852a_sco_mapping(central_ch);
> rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtw89: fix error function parameter
2021-10-19 3:53 [PATCH] rtw89: fix error function parameter cgel.zte
2021-10-19 5:21 ` Pkshih
@ 2021-10-20 8:50 ` Kalle Valo
2021-10-20 9:46 ` Pkshih
1 sibling, 1 reply; 10+ messages in thread
From: Kalle Valo @ 2021-10-20 8:50 UTC (permalink / raw)
To: cgel.zte
Cc: davem, kuba, pkshih, lv.ruyi, linux-wireless, netdev,
linux-kernel, Zeal Robot
cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Failed to apply, please rebase on top of wireless-drivers-next.
error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtw89: fix error function parameter
Using index info to reconstruct a base tree...
Patch failed at 0001 rtw89: fix error function parameter
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211019035311.974706-1-lv.ruyi@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] rtw89: fix error function parameter
2021-10-20 8:50 ` Kalle Valo
@ 2021-10-20 9:46 ` Pkshih
2021-10-20 10:03 ` Kalle Valo
0 siblings, 1 reply; 10+ messages in thread
From: Pkshih @ 2021-10-20 9:46 UTC (permalink / raw)
To: Kalle Valo, cgel.zte
Cc: davem, kuba, lv.ruyi, linux-wireless, netdev, linux-kernel, Zeal Robot
> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> Valo
> Sent: Wednesday, October 20, 2021 4:50 PM
> To: cgel.zte@gmail.com
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: Re: [PATCH] rtw89: fix error function parameter
>
> cgel.zte@gmail.com wrote:
>
> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> >
> > This patch fixes the following Coccinelle warning:
> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > WARNING possible condition with no effect (if == else)
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Failed to apply, please rebase on top of wireless-drivers-next.
>
> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
> hint: Use 'git am --show-current-patch' to see the failed patch
> Applying: rtw89: fix error function parameter
> Using index info to reconstruct a base tree...
> Patch failed at 0001 rtw89: fix error function parameter
>
> Patch set to Changes Requested.
>
I think this is because the patch is translated into spaces instead of tabs,
in this and following statements.
" if (is_2g)"
--
Ping-Ke
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtw89: fix error function parameter
2021-10-20 9:46 ` Pkshih
@ 2021-10-20 10:03 ` Kalle Valo
2021-10-21 1:34 ` Pkshih
0 siblings, 1 reply; 10+ messages in thread
From: Kalle Valo @ 2021-10-20 10:03 UTC (permalink / raw)
To: Pkshih
Cc: cgel.zte, davem, kuba, lv.ruyi, linux-wireless, netdev,
linux-kernel, Zeal Robot
Pkshih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: kvalo=codeaurora.org@mg.codeaurora.org
>> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
>> Valo
>> Sent: Wednesday, October 20, 2021 4:50 PM
>> To: cgel.zte@gmail.com
>> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
>> <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
>> linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
>> linux-kernel@vger.kernel.org; Zeal Robot
>> <zealci@zte.com.cn>
>> Subject: Re: [PATCH] rtw89: fix error function parameter
>>
>> cgel.zte@gmail.com wrote:
>>
>> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
>> >
>> > This patch fixes the following Coccinelle warning:
>> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
>> > WARNING possible condition with no effect (if == else)
>> >
>> > Reported-by: Zeal Robot <zealci@zte.com.cn>
>> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>>
>> Failed to apply, please rebase on top of wireless-drivers-next.
>>
>> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
>> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
>> error: Did you hand edit your patch?
>> It does not apply to blobs recorded in its index.
>> hint: Use 'git am --show-current-patch' to see the failed patch
>> Applying: rtw89: fix error function parameter
>> Using index info to reconstruct a base tree...
>> Patch failed at 0001 rtw89: fix error function parameter
>>
>> Patch set to Changes Requested.
>>
>
> I think this is because the patch is translated into spaces instead of tabs,
> in this and following statements.
> " if (is_2g)"
Ah, I did wonder why it failed as I didn't see any similar patches. We
have an item about this in the wiki:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] rtw89: fix error function parameter
2021-10-20 10:03 ` Kalle Valo
@ 2021-10-21 1:34 ` Pkshih
2021-10-21 3:10 ` CGEL
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
0 siblings, 2 replies; 10+ messages in thread
From: Pkshih @ 2021-10-21 1:34 UTC (permalink / raw)
To: Kalle Valo
Cc: cgel.zte, davem, kuba, lv.ruyi, linux-wireless, netdev,
linux-kernel, Zeal Robot
> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> Valo
> Sent: Wednesday, October 20, 2021 6:04 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: Re: [PATCH] rtw89: fix error function parameter
>
> Pkshih <pkshih@realtek.com> writes:
>
> >> -----Original Message-----
> >> From: kvalo=codeaurora.org@mg.codeaurora.org
> >> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> >> Valo
> >> Sent: Wednesday, October 20, 2021 4:50 PM
> >> To: cgel.zte@gmail.com
> >> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
> >> <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> >> linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> >> linux-kernel@vger.kernel.org; Zeal Robot
> >> <zealci@zte.com.cn>
> >> Subject: Re: [PATCH] rtw89: fix error function parameter
> >>
> >> cgel.zte@gmail.com wrote:
> >>
> >> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> >> >
> >> > This patch fixes the following Coccinelle warning:
> >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> >> > WARNING possible condition with no effect (if == else)
> >> >
> >> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> >> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> >> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> >>
> >> Failed to apply, please rebase on top of wireless-drivers-next.
> >>
> >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> >> error: Did you hand edit your patch?
> >> It does not apply to blobs recorded in its index.
> >> hint: Use 'git am --show-current-patch' to see the failed patch
> >> Applying: rtw89: fix error function parameter
> >> Using index info to reconstruct a base tree...
> >> Patch failed at 0001 rtw89: fix error function parameter
> >>
> >> Patch set to Changes Requested.
> >>
> >
> > I think this is because the patch is translated into spaces instead of tabs,
> > in this and following statements.
> > " if (is_2g)"
>
> Ah, I did wonder why it failed as I didn't see any similar patches. We
> have an item about this in the wiki:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
>
I don't know why neither.
I check the mail header of this patch, the mailer is
"X-Mailer: git-send-email 2.25.1". It should work properly.
Lv Ruyi, could you help to check what happens?
--
Ping-Ke
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtw89: fix error function parameter
2021-10-21 1:34 ` Pkshih
@ 2021-10-21 3:10 ` CGEL
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
1 sibling, 0 replies; 10+ messages in thread
From: CGEL @ 2021-10-21 3:10 UTC (permalink / raw)
To: Pkshih
Cc: Kalle Valo, davem, kuba, lv.ruyi, linux-wireless, netdev,
linux-kernel, Zeal Robot
On Thu, Oct 21, 2021 at 01:34:25AM +0000, Pkshih wrote:
>
> > -----Original Message-----
> > From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> > Valo
> > Sent: Wednesday, October 20, 2021 6:04 PM
> > To: Pkshih <pkshih@realtek.com>
> > Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn;
> > linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> > <zealci@zte.com.cn>
> > Subject: Re: [PATCH] rtw89: fix error function parameter
> >
> > Pkshih <pkshih@realtek.com> writes:
> >
> > >> -----Original Message-----
> > >> From: kvalo=codeaurora.org@mg.codeaurora.org
> > >> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> > >> Valo
> > >> Sent: Wednesday, October 20, 2021 4:50 PM
> > >> To: cgel.zte@gmail.com
> > >> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
> > >> <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> > >> linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> > >> linux-kernel@vger.kernel.org; Zeal Robot
> > >> <zealci@zte.com.cn>
> > >> Subject: Re: [PATCH] rtw89: fix error function parameter
> > >>
> > >> cgel.zte@gmail.com wrote:
> > >>
> > >> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> > >> >
> > >> > This patch fixes the following Coccinelle warning:
> > >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > >> > WARNING possible condition with no effect (if == else)
> > >> >
> > >> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > >> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > >> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> > >>
> > >> Failed to apply, please rebase on top of wireless-drivers-next.
> > >>
> > >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> > >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> > >> error: Did you hand edit your patch?
> > >> It does not apply to blobs recorded in its index.
> > >> hint: Use 'git am --show-current-patch' to see the failed patch
> > >> Applying: rtw89: fix error function parameter
> > >> Using index info to reconstruct a base tree...
> > >> Patch failed at 0001 rtw89: fix error function parameter
> > >>
> > >> Patch set to Changes Requested.
> > >>
> > >
> > > I think this is because the patch is translated into spaces instead of tabs,
> > > in this and following statements.
> > > " if (is_2g)"
> >
> > Ah, I did wonder why it failed as I didn't see any similar patches. We
> > have an item about this in the wiki:
> >
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
> >
>
> I don't know why neither.
>
> I check the mail header of this patch, the mailer is
> "X-Mailer: git-send-email 2.25.1". It should work properly.
>
> Lv Ruyi, could you help to check what happens?
>
> --
> Ping-Ke
Thanks for Ping-Ke's suggestion,you are right.The previous patch
is translated into spaces instead of tabs,and I will submitt a
new correct one.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V2] rtw89: fix error function parameter
2021-10-21 1:34 ` Pkshih
2021-10-21 3:10 ` CGEL
@ 2021-10-21 4:20 ` cgel.zte
2021-10-21 5:22 ` Pkshih
2021-10-27 7:36 ` Kalle Valo
1 sibling, 2 replies; 10+ messages in thread
From: cgel.zte @ 2021-10-21 4:20 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel,
Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING possible condition with no effect (if == else)
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
index b1b87f0aadbb..5c6ffca3a324 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
@@ -757,7 +757,7 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
else
rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
B_P1_MODE_SEL,
- 1, phy_idx);
+ 0, phy_idx);
/* SCO compensate FC setting */
sco_comp = rtw8852a_sco_mapping(central_ch);
rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH V2] rtw89: fix error function parameter
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
@ 2021-10-21 5:22 ` Pkshih
2021-10-27 7:36 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Pkshih @ 2021-10-21 5:22 UTC (permalink / raw)
To: cgel.zte
Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel,
Lv Ruyi, Zeal Robot
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Thursday, October 21, 2021 12:21 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Lv Ruyi <lv.ruyi@zte.com.cn>; Zeal Robot
> <zealci@zte.com.cn>
> Subject: [PATCH V2] rtw89: fix error function parameter
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
I think you can say something about the changes of v2 followed by '---', like
---
v2: fix tabs are converted to spaces
> ---
> drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -757,7 +757,7 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
> else
^^^^^^
I have confirmed this is a tab.
> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> - 1, phy_idx);
> + 0, phy_idx);
> /* SCO compensate FC setting */
> sco_comp = rtw8852a_sco_mapping(central_ch);
> rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] rtw89: fix error function parameter
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
2021-10-21 5:22 ` Pkshih
@ 2021-10-27 7:36 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2021-10-27 7:36 UTC (permalink / raw)
To: cgel.zte
Cc: pkshih, davem, kuba, linux-wireless, netdev, linux-kernel,
Lv Ruyi, Zeal Robot
cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
dea857700a75 rtw89: fix error function parameter
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211021042035.1042463-1-lv.ruyi@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-27 7:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 3:53 [PATCH] rtw89: fix error function parameter cgel.zte
2021-10-19 5:21 ` Pkshih
2021-10-20 8:50 ` Kalle Valo
2021-10-20 9:46 ` Pkshih
2021-10-20 10:03 ` Kalle Valo
2021-10-21 1:34 ` Pkshih
2021-10-21 3:10 ` CGEL
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
2021-10-21 5:22 ` Pkshih
2021-10-27 7:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).