linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
@ 2021-11-21 17:04 Dang Huynh
  2021-11-29 18:35 ` Alexey Minnekhanov
  2021-12-01 15:12 ` (subset) " Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Dang Huynh @ 2021-11-21 17:04 UTC (permalink / raw)
  To: Dang Huynh
  Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, Caleb Connolly

This enables the volume up key.

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
This patch is a continuation of this series [1]. The other patches in
the series have been applied and remains this. 

Changes in v5:
- Remove deprecated input-name property.

[1]: https://patchwork.kernel.org/cover/12630601/

 arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
index 9a6684922804..6586b8e47483 100644
--- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
+++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
@@ -9,6 +9,8 @@
 #include "sdm660.dtsi"
 #include "pm660.dtsi"
 #include "pm660l.dtsi"
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/input/gpio-keys.h>
 
 / {
 	model = "Xiaomi Redmi Note 7";
@@ -33,6 +35,17 @@ vph_pwr: vph-pwr-regulator {
 		regulator-boot-on;
 	};
 
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		volup {
+			label = "Volume Up";
+			gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+			debounce-interval = <15>;
+		};
+	};
+
 	reserved-memory {
 		#address-cells = <2>;
 		#size-cells = <2>;
-- 
2.34.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
  2021-11-21 17:04 [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button Dang Huynh
@ 2021-11-29 18:35 ` Alexey Minnekhanov
  2021-12-01 15:12 ` (subset) " Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Alexey Minnekhanov @ 2021-11-29 18:35 UTC (permalink / raw)
  To: Dang Huynh
  Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, Caleb Connolly

On 11/21/21 8:04 PM, Dang Huynh wrote:
> This enables the volume up key.
> 
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> This patch is a continuation of this series [1]. The other patches in
> the series have been applied and remains this.
> 
> Changes in v5:
> - Remove deprecated input-name property.
> 
> [1]: https://patchwork.kernel.org/cover/12630601/
> 
>   arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> index 9a6684922804..6586b8e47483 100644
> --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> @@ -9,6 +9,8 @@
>   #include "sdm660.dtsi"
>   #include "pm660.dtsi"
>   #include "pm660l.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/input/gpio-keys.h>
>   
>   / {
>   	model = "Xiaomi Redmi Note 7";
> @@ -33,6 +35,17 @@ vph_pwr: vph-pwr-regulator {
>   		regulator-boot-on;
>   	};
>   
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		volup {
> +			label = "Volume Up";
> +			gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			debounce-interval = <15>;
> +		};
> +	};
> +
>   	reserved-memory {
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> 

Nice, works on my Redmi Note 7.

Tested-by: Alexey Minnekhanov <alexeymin@postmarketos.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (subset) [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
  2021-11-21 17:04 [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button Dang Huynh
  2021-11-29 18:35 ` Alexey Minnekhanov
@ 2021-12-01 15:12 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-12-01 15:12 UTC (permalink / raw)
  To: Dang Huynh
  Cc: linux-arm-msm, Rob Herring, linux-kernel, devicetree, Andy Gross,
	Caleb Connolly

On Mon, 22 Nov 2021 00:04:49 +0700, Dang Huynh wrote:
> This enables the volume up key.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
      commit: 6867430332655cfb0880e0e7576ea4eb786d50fc

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-01 15:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-21 17:04 [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button Dang Huynh
2021-11-29 18:35 ` Alexey Minnekhanov
2021-12-01 15:12 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).