* [PATCH v2 0/1] memcg: enable accounting for pids in nested pid namespaces [not found] <7b777e22-5b0d-7444-343d-92cbfae5f8b4@virtuozzo.com> @ 2021-04-24 11:54 ` Vasily Averin 2021-04-24 11:54 ` [PATCH v2 1/1] " Vasily Averin 1 sibling, 0 replies; 4+ messages in thread From: Vasily Averin @ 2021-04-24 11:54 UTC (permalink / raw) To: Michal Hocko, cgroups Cc: linux-kernel, Roman Gushchin, Christian Brauner, Michal Koutný, Serge Hallyn Pid was one the first kernel objects enabled for memcg accounting, see 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") init_pid_ns.pid_cachep marked by SLAB_ACCOUNT and we can expect that any new pids in the system are memcg-accounted. Though recently I've noticed that it is wrong. nested pid namespaces creates own slab caches for pid objects, nested pids have increased size because contain id both for all parent and for own pid namespaces. The problem is that these slab caches are _NOT_ marked by SLAB_ACCOUNT,as a result any pids allocated in nested pid namespaces are not memcg-accounted. Pid struct in nested pid namespace consumes up to 500 bytes memory, 100000 such objects gives us up to ~50Mb unaccounted memory. This allow container to exceed assigned memcg limits. For me this issue lookslike bug and I would like to ask to push this fix both to upstream and to stable Vasily Averin (1): memcg: enable accounting for pids in nested pid namespaces kernel/pid_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.3.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] memcg: enable accounting for pids in nested pid namespaces [not found] <7b777e22-5b0d-7444-343d-92cbfae5f8b4@virtuozzo.com> 2021-04-24 11:54 ` [PATCH v2 0/1] memcg: enable accounting for pids in nested pid namespaces Vasily Averin @ 2021-04-24 11:54 ` Vasily Averin 2021-04-26 19:39 ` Shakeel Butt 2021-07-14 6:31 ` Vasily Averin 1 sibling, 2 replies; 4+ messages in thread From: Vasily Averin @ 2021-04-24 11:54 UTC (permalink / raw) To: Michal Hocko, cgroups Cc: linux-kernel, Roman Gushchin, Christian Brauner, Michal Koutný, Serge Hallyn Commit 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") enabled memcg accounting for pids allocated from init_pid_ns.pid_cachep, but forgot to adjust the setting for nested pid namespaces. As a result, pid memory is not accounted exactly where it is really needed, inside memcg-limited containers with their own pid namespaces. Pid was one the first kernel objects enabled for memcg accounting. init_pid_ns.pid_cachep marked by SLAB_ACCOUNT and we can expect that any new pids in the system are memcg-accounted. Though recently I've noticed that it is wrong. nested pid namespaces creates own slab caches for pid objects, nested pids have increased size because contain id both for all parent and for own pid namespaces. The problem is that these slab caches are _NOT_ marked by SLAB_ACCOUNT, as a result any pids allocated in nested pid namespaces are not memcg-accounted. Pid struct in nested pid namespace consumes up to 500 bytes memory, 100000 such objects gives us up to ~50Mb unaccounted memory, this allow container to exceed assigned memcg limits. Fixes: 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") Cc: stable@vger.kernel.org Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Reviewed-by: Michal Koutný <mkoutny@suse.com> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Acked-by: Roman Gushchin <guro@fb.com> --- kernel/pid_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index 6cd6715..a46a372 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -51,7 +51,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level) mutex_lock(&pid_caches_mutex); /* Name collision forces to do allocation under mutex. */ if (!*pkc) - *pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0); + *pkc = kmem_cache_create(name, len, 0, + SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT, 0); mutex_unlock(&pid_caches_mutex); /* current can fail, but someone else can succeed. */ return READ_ONCE(*pkc); -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] memcg: enable accounting for pids in nested pid namespaces 2021-04-24 11:54 ` [PATCH v2 1/1] " Vasily Averin @ 2021-04-26 19:39 ` Shakeel Butt 2021-07-14 6:31 ` Vasily Averin 1 sibling, 0 replies; 4+ messages in thread From: Shakeel Butt @ 2021-04-26 19:39 UTC (permalink / raw) To: Vasily Averin Cc: Michal Hocko, Cgroups, LKML, Roman Gushchin, Christian Brauner, Michal Koutný, Serge Hallyn On Sat, Apr 24, 2021 at 4:54 AM Vasily Averin <vvs@virtuozzo.com> wrote: > > Commit 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") > enabled memcg accounting for pids allocated from init_pid_ns.pid_cachep, > but forgot to adjust the setting for nested pid namespaces. > As a result, pid memory is not accounted exactly where it is really needed, > inside memcg-limited containers with their own pid namespaces. > > Pid was one the first kernel objects enabled for memcg accounting. > init_pid_ns.pid_cachep marked by SLAB_ACCOUNT and we can expect that > any new pids in the system are memcg-accounted. > > Though recently I've noticed that it is wrong. nested pid namespaces creates > own slab caches for pid objects, nested pids have increased size because contain > id both for all parent and for own pid namespaces. The problem is that these slab > caches are _NOT_ marked by SLAB_ACCOUNT, as a result any pids allocated in > nested pid namespaces are not memcg-accounted. > > Pid struct in nested pid namespace consumes up to 500 bytes memory, > 100000 such objects gives us up to ~50Mb unaccounted memory, > this allow container to exceed assigned memcg limits. > > Fixes: 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") > Cc: stable@vger.kernel.org > Signed-off-by: Vasily Averin <vvs@virtuozzo.com> > Reviewed-by: Michal Koutný <mkoutny@suse.com> > Acked-by: Christian Brauner <christian.brauner@ubuntu.com> > Acked-by: Roman Gushchin <guro@fb.com> Reviewed-by: Shakeel Butt <shakeelb@google.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] memcg: enable accounting for pids in nested pid namespaces 2021-04-24 11:54 ` [PATCH v2 1/1] " Vasily Averin 2021-04-26 19:39 ` Shakeel Butt @ 2021-07-14 6:31 ` Vasily Averin 1 sibling, 0 replies; 4+ messages in thread From: Vasily Averin @ 2021-07-14 6:31 UTC (permalink / raw) To: Andrew Morton Cc: linux-kernel, Roman Gushchin, Christian Brauner, Michal Koutný, Serge Hallyn, cgroups, Michal Hocko Dear Andrew, could you please pick up this patch and add Reviewed-by: Shakeel Butt <shakeelb@google.com> Thank you, Vasily Averin On 4/24/21 2:54 PM, Vasily Averin wrote: > Commit 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") > enabled memcg accounting for pids allocated from init_pid_ns.pid_cachep, > but forgot to adjust the setting for nested pid namespaces. > As a result, pid memory is not accounted exactly where it is really needed, > inside memcg-limited containers with their own pid namespaces. > > Pid was one the first kernel objects enabled for memcg accounting. > init_pid_ns.pid_cachep marked by SLAB_ACCOUNT and we can expect that > any new pids in the system are memcg-accounted. > > Though recently I've noticed that it is wrong. nested pid namespaces creates > own slab caches for pid objects, nested pids have increased size because contain > id both for all parent and for own pid namespaces. The problem is that these slab > caches are _NOT_ marked by SLAB_ACCOUNT, as a result any pids allocated in > nested pid namespaces are not memcg-accounted. > > Pid struct in nested pid namespace consumes up to 500 bytes memory, > 100000 such objects gives us up to ~50Mb unaccounted memory, > this allow container to exceed assigned memcg limits. > > Fixes: 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg") > Cc: stable@vger.kernel.org > Signed-off-by: Vasily Averin <vvs@virtuozzo.com> > Reviewed-by: Michal Koutný <mkoutny@suse.com> > Acked-by: Christian Brauner <christian.brauner@ubuntu.com> > Acked-by: Roman Gushchin <guro@fb.com> > --- > kernel/pid_namespace.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c > index 6cd6715..a46a372 100644 > --- a/kernel/pid_namespace.c > +++ b/kernel/pid_namespace.c > @@ -51,7 +51,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level) > mutex_lock(&pid_caches_mutex); > /* Name collision forces to do allocation under mutex. */ > if (!*pkc) > - *pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0); > + *pkc = kmem_cache_create(name, len, 0, > + SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT, 0); > mutex_unlock(&pid_caches_mutex); > /* current can fail, but someone else can succeed. */ > return READ_ONCE(*pkc); > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-14 6:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <7b777e22-5b0d-7444-343d-92cbfae5f8b4@virtuozzo.com> 2021-04-24 11:54 ` [PATCH v2 0/1] memcg: enable accounting for pids in nested pid namespaces Vasily Averin 2021-04-24 11:54 ` [PATCH v2 1/1] " Vasily Averin 2021-04-26 19:39 ` Shakeel Butt 2021-07-14 6:31 ` Vasily Averin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).