[PATCH] don't offer GEN_RTC on ia64

[PATCH] don't offer GEN_RTC on ia64

[Bjorn Helgaas]

gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters),
so don't offer it there.

===== drivers/char/Kconfig 1.32 vs edited =====
--- 1.32/drivers/char/Kconfig	Tue Mar 16 03:10:34 2004
+++ edited/drivers/char/Kconfig	Tue Apr  6 15:58:28 2004
@@ -768,7 +768,7 @@
 
 config GEN_RTC
 	tristate "Generic /dev/rtc emulation"
-	depends on RTC!=y
+	depends on RTC!=y && !IA64
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you

Re: [PATCH] don't offer GEN_RTC on ia64

[Tom Rini]

On Tue, Apr 06, 2004 at 04:22:49PM -0600, Bjorn Helgaas wrote:

> gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters),
> so don't offer it there.

Why not provide asm/rtc.h and kill off drivers/char/efirtc.c instead? :)

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH] don't offer GEN_RTC on ia64

[Bjorn Helgaas]

On Tuesday 06 April 2004 4:34 pm, Tom Rini wrote:
> On Tue, Apr 06, 2004 at 04:22:49PM -0600, Bjorn Helgaas wrote:
> 
> > gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters),
> > so don't offer it there.
> 
> Why not provide asm/rtc.h and kill off drivers/char/efirtc.c instead? :)

Yeah, I was afraid someone would suggest that :-)

I'd actually like to do that, but that's a longer-term project.  And I
don't know the history behind efi_rtc, so maybe there's a good reason
for it being separate.

(Actually, it looks to me like gen_rtc.c ought to be killed off as well,
with both being folded into rtc.c.)

Re: [PATCH] don't offer GEN_RTC on ia64

[Tom Rini]

On Tue, Apr 06, 2004 at 04:37:48PM -0600, Bjorn Helgaas wrote:
> On Tuesday 06 April 2004 4:34 pm, Tom Rini wrote:
> > On Tue, Apr 06, 2004 at 04:22:49PM -0600, Bjorn Helgaas wrote:
> > 
> > > gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters),
> > > so don't offer it there.
> > 
> > Why not provide asm/rtc.h and kill off drivers/char/efirtc.c instead? :)
> 
> Yeah, I was afraid someone would suggest that :-)
> 
> I'd actually like to do that, but that's a longer-term project.  And I
> don't know the history behind efi_rtc, so maybe there's a good reason
> for it being separate.
> 
> (Actually, it looks to me like gen_rtc.c ought to be killed off as well,
> with both being folded into rtc.c.)

efi_rtc.c just predates genrtc getting into kernel.org, but as it does
come from the m68k folks, it came first :)  WRT gen_rtc.c being killed
off, yes, that sounds vaugly like the MIPS varriant of a generic RTC
driver, which is being killed off (which reminds me of some cleanups
suggested by Jun Sun, *sigh*, so much to do, so little time).

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH] don't offer GEN_RTC on ia64

[David Mosberger]

>>>>> On Tue, 6 Apr 2004 16:37:48 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:

  Bjorn> I'd actually like to do that, but that's a longer-term
  Bjorn> project.  And I don't know the history behind efi_rtc, so
  Bjorn> maybe there's a good reason for it being separate.

AFAIR, when efirtc was being written, the normal RTC driver was
specific to the PC clock chips (mc14whatever) and it wasn't clear
whether it should even try to be generic.  I don't think anybody is
particularly attached to the bits.

	--david