* [PATCH] don't offer GEN_RTC on ia64
@ 2004-04-06 22:22 Bjorn Helgaas
2004-04-06 22:34 ` Tom Rini
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2004-04-06 22:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: p_gortmaker, linux-kernel, linux-ia64
gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters),
so don't offer it there.
===== drivers/char/Kconfig 1.32 vs edited =====
--- 1.32/drivers/char/Kconfig Tue Mar 16 03:10:34 2004
+++ edited/drivers/char/Kconfig Tue Apr 6 15:58:28 2004
@@ -768,7 +768,7 @@
config GEN_RTC
tristate "Generic /dev/rtc emulation"
- depends on RTC!=y
+ depends on RTC!=y && !IA64
---help---
If you say Y here and create a character special file /dev/rtc with
major number 10 and minor number 135 using mknod ("man mknod"), you
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] don't offer GEN_RTC on ia64 2004-04-06 22:22 [PATCH] don't offer GEN_RTC on ia64 Bjorn Helgaas @ 2004-04-06 22:34 ` Tom Rini 2004-04-06 22:37 ` Bjorn Helgaas 0 siblings, 1 reply; 5+ messages in thread From: Tom Rini @ 2004-04-06 22:34 UTC (permalink / raw) To: Bjorn Helgaas; +Cc: Andrew Morton, p_gortmaker, linux-kernel, linux-ia64 On Tue, Apr 06, 2004 at 04:22:49PM -0600, Bjorn Helgaas wrote: > gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters), > so don't offer it there. Why not provide asm/rtc.h and kill off drivers/char/efirtc.c instead? :) -- Tom Rini http://gate.crashing.org/~trini/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] don't offer GEN_RTC on ia64 2004-04-06 22:34 ` Tom Rini @ 2004-04-06 22:37 ` Bjorn Helgaas 2004-04-06 22:44 ` Tom Rini 2004-04-06 23:15 ` David Mosberger 0 siblings, 2 replies; 5+ messages in thread From: Bjorn Helgaas @ 2004-04-06 22:37 UTC (permalink / raw) To: Tom Rini; +Cc: Andrew Morton, p_gortmaker, linux-kernel, linux-ia64 On Tuesday 06 April 2004 4:34 pm, Tom Rini wrote: > On Tue, Apr 06, 2004 at 04:22:49PM -0600, Bjorn Helgaas wrote: > > > gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters), > > so don't offer it there. > > Why not provide asm/rtc.h and kill off drivers/char/efirtc.c instead? :) Yeah, I was afraid someone would suggest that :-) I'd actually like to do that, but that's a longer-term project. And I don't know the history behind efi_rtc, so maybe there's a good reason for it being separate. (Actually, it looks to me like gen_rtc.c ought to be killed off as well, with both being folded into rtc.c.) ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] don't offer GEN_RTC on ia64 2004-04-06 22:37 ` Bjorn Helgaas @ 2004-04-06 22:44 ` Tom Rini 2004-04-06 23:15 ` David Mosberger 1 sibling, 0 replies; 5+ messages in thread From: Tom Rini @ 2004-04-06 22:44 UTC (permalink / raw) To: Bjorn Helgaas; +Cc: Andrew Morton, p_gortmaker, linux-kernel, linux-ia64 On Tue, Apr 06, 2004 at 04:37:48PM -0600, Bjorn Helgaas wrote: > On Tuesday 06 April 2004 4:34 pm, Tom Rini wrote: > > On Tue, Apr 06, 2004 at 04:22:49PM -0600, Bjorn Helgaas wrote: > > > > > gen_rtc.c doesn't work on ia64 (we don't have asm/rtc.h, for starters), > > > so don't offer it there. > > > > Why not provide asm/rtc.h and kill off drivers/char/efirtc.c instead? :) > > Yeah, I was afraid someone would suggest that :-) > > I'd actually like to do that, but that's a longer-term project. And I > don't know the history behind efi_rtc, so maybe there's a good reason > for it being separate. > > (Actually, it looks to me like gen_rtc.c ought to be killed off as well, > with both being folded into rtc.c.) efi_rtc.c just predates genrtc getting into kernel.org, but as it does come from the m68k folks, it came first :) WRT gen_rtc.c being killed off, yes, that sounds vaugly like the MIPS varriant of a generic RTC driver, which is being killed off (which reminds me of some cleanups suggested by Jun Sun, *sigh*, so much to do, so little time). -- Tom Rini http://gate.crashing.org/~trini/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] don't offer GEN_RTC on ia64 2004-04-06 22:37 ` Bjorn Helgaas 2004-04-06 22:44 ` Tom Rini @ 2004-04-06 23:15 ` David Mosberger 1 sibling, 0 replies; 5+ messages in thread From: David Mosberger @ 2004-04-06 23:15 UTC (permalink / raw) To: Bjorn Helgaas Cc: Tom Rini, Andrew Morton, p_gortmaker, linux-kernel, linux-ia64 >>>>> On Tue, 6 Apr 2004 16:37:48 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said: Bjorn> I'd actually like to do that, but that's a longer-term Bjorn> project. And I don't know the history behind efi_rtc, so Bjorn> maybe there's a good reason for it being separate. AFAIR, when efirtc was being written, the normal RTC driver was specific to the PC clock chips (mc14whatever) and it wasn't clear whether it should even try to be generic. I don't think anybody is particularly attached to the bits. --david ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-04-06 23:15 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2004-04-06 22:22 [PATCH] don't offer GEN_RTC on ia64 Bjorn Helgaas 2004-04-06 22:34 ` Tom Rini 2004-04-06 22:37 ` Bjorn Helgaas 2004-04-06 22:44 ` Tom Rini 2004-04-06 23:15 ` David Mosberger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).