* [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()
@ 2023-01-28 0:37 Srivatsa S. Bhat
2023-02-14 17:09 ` Srivatsa S. Bhat
2023-02-14 22:56 ` [tip: x86/cleanups] " tip-bot2 for Srivatsa S. Bhat (VMware)
0 siblings, 2 replies; 3+ messages in thread
From: Srivatsa S. Bhat @ 2023-01-28 0:37 UTC (permalink / raw)
To: tglx, mingo, x86, peterz, hpa
Cc: bp, dave.hansen, rafael.j.wysocki, paulmck, jgross, seanjc,
thomas.lendacky, linux-kernel, imammedo, amakhalov, ganb,
ankitja, bordoloih, keerthanak, blamoreaux, namit, wyes.karny,
lewis.carroll, pv-drivers, virtualization, kvm, xen-devel,
srivatsa
From: "Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>
The comment that says mwait_play_dead() returns only on failure is a
bit misleading because mwait_play_dead() could actually return for
valid reasons (such as mwait not being supported by the platform) that
do not indicate a failure of the CPU offline operation. So, remove the
comment.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
---
arch/x86/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 55cad72715d9..9013bb28255a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1833,7 +1833,7 @@ void native_play_dead(void)
play_dead_common();
tboot_shutdown(TB_SHUTDOWN_WFS);
- mwait_play_dead(); /* Only returns on failure */
+ mwait_play_dead();
if (cpuidle_play_dead())
hlt_play_dead();
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()
2023-01-28 0:37 [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() Srivatsa S. Bhat
@ 2023-02-14 17:09 ` Srivatsa S. Bhat
2023-02-14 22:56 ` [tip: x86/cleanups] " tip-bot2 for Srivatsa S. Bhat (VMware)
1 sibling, 0 replies; 3+ messages in thread
From: Srivatsa S. Bhat @ 2023-02-14 17:09 UTC (permalink / raw)
To: tglx, mingo, x86, peterz, hpa
Cc: bp, dave.hansen, rafael.j.wysocki, paulmck, jgross, seanjc,
thomas.lendacky, linux-kernel, imammedo, amakhalov, ganb,
ankitja, bordoloih, keerthanak, blamoreaux, namit, wyes.karny,
lewis.carroll, pv-drivers, virtualization, kvm, xen-devel
Hi,
On 1/27/23 4:37 PM, Srivatsa S. Bhat wrote:
> From: "Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>
>
> The comment that says mwait_play_dead() returns only on failure is a
> bit misleading because mwait_play_dead() could actually return for
> valid reasons (such as mwait not being supported by the platform) that
> do not indicate a failure of the CPU offline operation. So, remove the
> comment.
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
Gentle ping for review. Thank you!
Regards,
Srivatsa
> ---
> arch/x86/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 55cad72715d9..9013bb28255a 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1833,7 +1833,7 @@ void native_play_dead(void)
> play_dead_common();
> tboot_shutdown(TB_SHUTDOWN_WFS);
>
> - mwait_play_dead(); /* Only returns on failure */
> + mwait_play_dead();
> if (cpuidle_play_dead())
> hlt_play_dead();
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/cleanups] x86/hotplug: Remove incorrect comment about mwait_play_dead()
2023-01-28 0:37 [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() Srivatsa S. Bhat
2023-02-14 17:09 ` Srivatsa S. Bhat
@ 2023-02-14 22:56 ` tip-bot2 for Srivatsa S. Bhat (VMware)
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Srivatsa S. Bhat (VMware) @ 2023-02-14 22:56 UTC (permalink / raw)
To: linux-tip-commits
Cc: Thomas Gleixner, Srivatsa S. Bhat (VMware), x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: fcb3a81d221750d2a54b4e3a82b3efbbeab8780c
Gitweb: https://git.kernel.org/tip/fcb3a81d221750d2a54b4e3a82b3efbbeab8780c
Author: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
AuthorDate: Fri, 27 Jan 2023 16:37:51 -08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 14 Feb 2023 23:44:34 +01:00
x86/hotplug: Remove incorrect comment about mwait_play_dead()
The comment that says mwait_play_dead() returns only on failure is a bit
misleading because mwait_play_dead() could actually return for valid
reasons (such as mwait not being supported by the platform) that do not
indicate a failure of the CPU offline operation. So, remove the comment.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230128003751.141317-1-srivatsa@csail.mit.edu
---
arch/x86/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 55cad72..9013bb2 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1833,7 +1833,7 @@ void native_play_dead(void)
play_dead_common();
tboot_shutdown(TB_SHUTDOWN_WFS);
- mwait_play_dead(); /* Only returns on failure */
+ mwait_play_dead();
if (cpuidle_play_dead())
hlt_play_dead();
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-14 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 0:37 [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() Srivatsa S. Bhat
2023-02-14 17:09 ` Srivatsa S. Bhat
2023-02-14 22:56 ` [tip: x86/cleanups] " tip-bot2 for Srivatsa S. Bhat (VMware)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).