From: Juergen Gross <jgross@suse.com>
To: "Valentin Vidic" <Valentin.Vidic@CARNet.hr>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] xen-blkback: Switch to closed state after releasing the backing device
Date: Wed, 29 Aug 2018 10:16:09 +0200 [thread overview]
Message-ID: <1701ccef-3ebb-973b-de32-059a8816d31c@suse.com> (raw)
In-Reply-To: <20180829065214.23546-1-Valentin.Vidic@CARNet.hr>
On 29/08/18 08:52, Valentin Vidic wrote:
> Switching to closed state earlier can cause the block-drbd
> script to fail with 'Device is held open by someone':
>
> root: /etc/xen/scripts/block-drbd: remove XENBUS_PATH=backend/vbd/6/51712
> kernel: [ 2222.278235] block drbd6: State change failed: Device is held open by someone
> kernel: [ 2222.278304] block drbd6: state = { cs:Connected ro:Primary/Secondary ds:UpToDate/UpToDate r----- }
> kernel: [ 2222.278340] block drbd6: wanted = { cs:Connected ro:Secondary/Secondary ds:UpToDate/UpToDate r----- }
> root: /etc/xen/scripts/block-drbd: Writing backend/vbd/6/51712/hotplug-error /etc/xen/scripts/block-drbd failed; error detected. backend/vbd/6/51712/hotplug-status error to xenstore.
> root: /etc/xen/scripts/block-drbd: /etc/xen/scripts/block-drbd failed; error detected.
>
> Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
> Cc: stable@vger.kernel.org
> ---
> drivers/block/xen-blkback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index a4bc74e72c39..43bddc996709 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -323,6 +323,7 @@ static void xen_blkif_free(struct xen_blkif *blkif)
> {
> WARN_ON(xen_blkif_disconnect(blkif));
> xen_vbd_free(&blkif->vbd);
> + xenbus_switch_state(blkif->be->dev, XenbusStateClosed);
> kfree(blkif->be->mode);
> kfree(blkif->be);
>
> @@ -814,7 +815,6 @@ static void frontend_changed(struct xenbus_device *dev,
>
> case XenbusStateClosed:
> xen_blkif_disconnect(be->blkif);
> - xenbus_switch_state(dev, XenbusStateClosed);
> if (xenbus_dev_is_online(dev))
> break;
> /* fall through */
Did you test whether it is okay to not change state in case the device
is still online?
Juergen
next prev parent reply other threads:[~2018-08-29 8:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 6:52 [PATCH] xen-blkback: Switch to closed state after releasing the backing device Valentin Vidic
2018-08-29 8:16 ` Juergen Gross [this message]
2018-08-29 8:27 ` Valentin Vidic
2018-08-29 8:43 ` Juergen Gross
2018-08-29 9:23 ` Valentin Vidic
2018-08-29 9:29 ` Juergen Gross
2018-09-05 10:36 ` Roger Pau Monné
2018-09-05 16:27 ` Valentin Vidic
2018-09-06 16:14 ` Roger Pau Monné
2018-09-06 22:03 ` Valentin Vidic
2018-09-07 12:03 ` [DRBD-user] " Lars Ellenberg
2018-09-07 12:13 ` Valentin Vidic
2018-09-07 13:28 ` Lars Ellenberg
2018-09-07 16:45 ` Valentin Vidic
2018-09-07 17:14 ` Valentin Vidic
2018-09-08 7:34 ` Valentin Vidic
2018-09-10 12:45 ` Lars Ellenberg
2018-09-10 13:22 ` Valentin Vidic
2018-09-10 15:00 ` Roger Pau Monné
2018-09-10 16:18 ` Valentin Vidic
2018-09-13 15:08 ` Roger Pau Monné
2018-09-14 11:49 ` Valentin Vidic
2018-09-14 16:18 ` Roger Pau Monné
[not found] ` <20180905113515.GU26705@gavran.carpriv.carnet.hr>
2018-09-05 16:28 ` Valentin Vidic
2018-09-06 16:29 ` Roger Pau Monné
2018-09-06 22:19 ` Valentin Vidic
2018-09-07 7:15 ` Roger Pau Monné
2018-09-07 7:23 ` Valentin Vidic
2018-09-07 7:54 ` Roger Pau Monné
2018-09-07 10:20 ` Valentin Vidic
2018-09-07 10:43 ` Roger Pau Monné
2018-09-07 11:15 ` Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1701ccef-3ebb-973b-de32-059a8816d31c@suse.com \
--to=jgross@suse.com \
--cc=Valentin.Vidic@CARNet.hr \
--cc=axboe@kernel.dk \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).