From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jens Axboe <axboe@kernel.dk>, <xen-devel@lists.xenproject.org>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>, <drbd-user@lists.linbit.com>
Subject: Re: [PATCH] xen-blkback: Switch to closed state after releasing the backing device
Date: Fri, 7 Sep 2018 09:54:55 +0200 [thread overview]
Message-ID: <20180907075455.szxahgevvlmfjvwy@mac.bytemobile.com> (raw)
In-Reply-To: <20180907072319.GA26705@gavran.carpriv.carnet.hr>
On Fri, Sep 07, 2018 at 09:23:19AM +0200, Valentin Vidic wrote:
> On Fri, Sep 07, 2018 at 09:15:30AM +0200, Roger Pau Monné wrote:
> > I'm not sure that's a good idea, there are a lot of backends (apart
> > from blkback), and the tools won't know whether a specific backend
> > supports such state or not. Also the current protocol and states are
> > shared between all the Xen PV devices, so new additions should be
> > considered very carefully.
>
> Sure, I understand.
>
> > IMO the best options are either calling vbd_free/vbd_create at proper
> > stages in blkback or changing the hotplug script so it waits for the
> > device to have no open clients.
>
> Changing the block-drbd script would be ideal for me too, but I don't
> think that piece of DRBD state is exposed at the moment.
Then I'm afraid you will have to look into the vbd_free/create fix.
Thanks, Roger.
next prev parent reply other threads:[~2018-09-07 7:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 6:52 [PATCH] xen-blkback: Switch to closed state after releasing the backing device Valentin Vidic
2018-08-29 8:16 ` Juergen Gross
2018-08-29 8:27 ` Valentin Vidic
2018-08-29 8:43 ` Juergen Gross
2018-08-29 9:23 ` Valentin Vidic
2018-08-29 9:29 ` Juergen Gross
2018-09-05 10:36 ` Roger Pau Monné
2018-09-05 16:27 ` Valentin Vidic
2018-09-06 16:14 ` Roger Pau Monné
2018-09-06 22:03 ` Valentin Vidic
2018-09-07 12:03 ` [DRBD-user] " Lars Ellenberg
2018-09-07 12:13 ` Valentin Vidic
2018-09-07 13:28 ` Lars Ellenberg
2018-09-07 16:45 ` Valentin Vidic
2018-09-07 17:14 ` Valentin Vidic
2018-09-08 7:34 ` Valentin Vidic
2018-09-10 12:45 ` Lars Ellenberg
2018-09-10 13:22 ` Valentin Vidic
2018-09-10 15:00 ` Roger Pau Monné
2018-09-10 16:18 ` Valentin Vidic
2018-09-13 15:08 ` Roger Pau Monné
2018-09-14 11:49 ` Valentin Vidic
2018-09-14 16:18 ` Roger Pau Monné
[not found] ` <20180905113515.GU26705@gavran.carpriv.carnet.hr>
2018-09-05 16:28 ` Valentin Vidic
2018-09-06 16:29 ` Roger Pau Monné
2018-09-06 22:19 ` Valentin Vidic
2018-09-07 7:15 ` Roger Pau Monné
2018-09-07 7:23 ` Valentin Vidic
2018-09-07 7:54 ` Roger Pau Monné [this message]
2018-09-07 10:20 ` Valentin Vidic
2018-09-07 10:43 ` Roger Pau Monné
2018-09-07 11:15 ` Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907075455.szxahgevvlmfjvwy@mac.bytemobile.com \
--to=roger.pau@citrix.com \
--cc=Valentin.Vidic@CARNet.hr \
--cc=axboe@kernel.dk \
--cc=drbd-user@lists.linbit.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).