From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: shruthi.sanil@intel.com, tglx@linutronix.de, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, mgross@linux.intel.com,
srikanth.thokala@intel.com,
lakshmi.bai.raja.subramanian@intel.com,
mallikarjunappa.sangannavar@intel.com
Subject: Re: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support
Date: Mon, 7 Mar 2022 18:21:18 +0100 [thread overview]
Message-ID: <174e42ce-13c7-e7ba-0ce8-227979383db1@linaro.org> (raw)
In-Reply-To: <20220307113147.19496-3-shruthi.sanil@intel.com>
On 07/03/2022 12:31, shruthi.sanil@intel.com wrote:
> From: Shruthi Sanil <shruthi.sanil@intel.com>
[ ... ]
> + /* Prescaler bit must be enabled for the timer to function */
> + if (!(val & TIM_CONFIG_PRESCALER_ENABLE)) {
> + pr_err("%pOF: FW_BUG: Prescaler is not enabled\n", np);
> + ret = -ENODEV;
return -ENODEV;
> + }
[ ... ]
FW_BUG macro comment was already spotted
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2022-03-07 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 11:31 [PATCH v9 0/2] Add the driver for Intel Keem Bay SoC timer block shruthi.sanil
2022-03-07 11:31 ` [PATCH v9 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer shruthi.sanil
2022-03-07 11:31 ` [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support shruthi.sanil
2022-03-07 13:45 ` Andy Shevchenko
2022-03-07 16:33 ` Sanil, Shruthi
2022-03-07 17:21 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174e42ce-13c7-e7ba-0ce8-227979383db1@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shruthi.sanil@intel.com \
--cc=srikanth.thokala@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).