* [PATCH] of: base: improve error message in of_phandle_iterator_next()
@ 2021-02-08 16:58 Enrico Weigelt, metux IT consult
2021-02-11 20:13 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2021-02-08 16:58 UTC (permalink / raw)
To: linux-kernel; +Cc: robh+dt, frowand.list, devicetree
Also print out the phandle ID on error message, as a debug aid.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 161a23631472..8a348f0d3c5e 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1297,8 +1297,8 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
if (it->cells_name) {
if (!it->node) {
- pr_err("%pOF: could not find phandle\n",
- it->parent);
+ pr_err("%pOF: could not find phandle %d\n",
+ it->parent, it->phandle);
goto err;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: base: improve error message in of_phandle_iterator_next()
2021-02-08 16:58 [PATCH] of: base: improve error message in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
@ 2021-02-11 20:13 ` Rob Herring
2021-02-12 10:19 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-02-11 20:13 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult; +Cc: linux-kernel, Frank Rowand, devicetree
On Mon, Feb 8, 2021 at 10:58 AM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Also print out the phandle ID on error message, as a debug aid.
I already have this patch applied in my tree. Why do you keep sending it?
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: base: improve error message in of_phandle_iterator_next()
2021-02-11 20:13 ` Rob Herring
@ 2021-02-12 10:19 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2021-02-12 10:19 UTC (permalink / raw)
To: Rob Herring, Enrico Weigelt, metux IT consult
Cc: linux-kernel, Frank Rowand, devicetree
On 11.02.21 21:13, Rob Herring wrote:
> On Mon, Feb 8, 2021 at 10:58 AM Enrico Weigelt, metux IT consult
> <info@metux.net> wrote:
>>
>> Also print out the phandle ID on error message, as a debug aid.
>
> I already have this patch applied in my tree. Why do you keep sending it?
Sorry, didn't know that when sending it the 2nd time, missed your last
mail in the mail flood :o
Seems my mail sorting rules are still quite imperfect. I suspect I'm not
the only one with those problems - how do you folks handle that ?
--mtx
--
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-12 10:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 16:58 [PATCH] of: base: improve error message in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
2021-02-11 20:13 ` Rob Herring
2021-02-12 10:19 ` Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).