[PATCH] of: base: improve error message in of_phandle_iterator_next()

[PATCH] of: base: improve error message in of_phandle_iterator_next()

[Enrico Weigelt, metux IT consult]

Also print out the phandle ID on error message, as a debug aid.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/of/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 161a23631472..8a348f0d3c5e 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1297,8 +1297,8 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
 
 		if (it->cells_name) {
 			if (!it->node) {
-				pr_err("%pOF: could not find phandle\n",
-				       it->parent);
+				pr_err("%pOF: could not find phandle %d\n",
+				       it->parent, it->phandle);
 				goto err;
 			}
 
-- 
2.11.0

Re: [PATCH] of: base: improve error message in of_phandle_iterator_next()

[Rob Herring]

On Mon, Feb 8, 2021 at 10:58 AM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Also print out the phandle ID on error message, as a debug aid.

I already have this patch applied in my tree. Why do you keep sending it?

Rob

Re: [PATCH] of: base: improve error message in of_phandle_iterator_next()

[Enrico Weigelt, metux IT consult]

On 11.02.21 21:13, Rob Herring wrote:
> On Mon, Feb 8, 2021 at 10:58 AM Enrico Weigelt, metux IT consult
> <info@metux.net> wrote:
>>
>> Also print out the phandle ID on error message, as a debug aid.
> 
> I already have this patch applied in my tree. Why do you keep sending it?

Sorry, didn't know that when sending it the 2nd time, missed your last
mail in the mail flood :o

Seems my mail sorting rules are still quite imperfect. I suspect I'm not
the only one with those problems - how do you folks handle that ?


--mtx

-- 
-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287