* [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP
@ 2022-11-25 22:34 Matti Lehtimäki
2022-11-28 14:41 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Matti Lehtimäki @ 2022-11-25 22:34 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, devicetree, linux-kernel
Configure the reserved memory for ADSP and enable it.
Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
index 1c52337af560..859e91c16c61 100644
--- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
@@ -133,7 +133,8 @@ wcnss@d200000 {
no-map;
};
- adsp@d900000 {
+ /delete-node/ adsp@dc00000;
+ adsp_region: adsp@d900000 {
reg = <0x0d900000 0x1800000>;
no-map;
};
@@ -169,6 +170,10 @@ rmtfs@fd80000 {
};
};
+&adsp {
+ status = "okay";
+};
+
&blsp1_i2c2 {
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP
2022-11-25 22:34 [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP Matti Lehtimäki
@ 2022-11-28 14:41 ` Konrad Dybcio
2022-11-28 17:01 ` Matti Lehtimäki
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2022-11-28 14:41 UTC (permalink / raw)
To: Matti Lehtimäki, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 25.11.2022 23:34, Matti Lehtimäki wrote:
> Configure the reserved memory for ADSP and enable it.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
> arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> index 1c52337af560..859e91c16c61 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -133,7 +133,8 @@ wcnss@d200000 {
> no-map;
> };
>
> - adsp@d900000 {
> + /delete-node/ adsp@dc00000;
Please delete nodes by referencing the label like so:
/delete-node/ &adsp_region;
Konrad
> + adsp_region: adsp@d900000 {
> reg = <0x0d900000 0x1800000>;
> no-map;
> };
> @@ -169,6 +170,10 @@ rmtfs@fd80000 {
> };
> };
>
> +&adsp {
> + status = "okay";
> +};
> +
> &blsp1_i2c2 {
> status = "okay";
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP
2022-11-28 14:41 ` Konrad Dybcio
@ 2022-11-28 17:01 ` Matti Lehtimäki
2022-11-28 20:59 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Matti Lehtimäki @ 2022-11-28 17:01 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 28.11.2022 16.41, Konrad Dybcio wrote:
>
> On 25.11.2022 23:34, Matti Lehtimäki wrote:
>> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>> index 1c52337af560..859e91c16c61 100644
>> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>> @@ -133,7 +133,8 @@ wcnss@d200000 {
>> no-map;
>> };
>>
>> - adsp@d900000 {
>> + /delete-node/ adsp@dc00000;
> Please delete nodes by referencing the label like so:
>
> /delete-node/ &adsp_region;
When I created the devicetree I was asked to do the opposite for the
smem_region [1] which I had originally deleted using the label near top
of the
file but then moved next to the relevant node, where I cannot use label
when deleting it. Should the smem_region also be moved to the top of the
file if I move this delete-node there so the file would be consistent?
[1]
https://lore.kernel.org/linux-arm-msm/CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D36aCnBr38bo5HoJw@mail.gmail.com/
--
Matti
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP
2022-11-28 17:01 ` Matti Lehtimäki
@ 2022-11-28 20:59 ` Konrad Dybcio
2022-11-28 21:06 ` Luca Weiss
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2022-11-28 20:59 UTC (permalink / raw)
To: Matti Lehtimäki, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 28.11.2022 18:01, Matti Lehtimäki wrote:
> On 28.11.2022 16.41, Konrad Dybcio wrote:
>>
>> On 25.11.2022 23:34, Matti Lehtimäki wrote:
>>> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>>> index 1c52337af560..859e91c16c61 100644
>>> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>>> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>>> @@ -133,7 +133,8 @@ wcnss@d200000 {
>>> no-map;
>>> };
>>> - adsp@d900000 {
>>> + /delete-node/ adsp@dc00000;
>> Please delete nodes by referencing the label like so:
>>
>> /delete-node/ &adsp_region;
>
> When I created the devicetree I was asked to do the opposite for the
> smem_region [1] which I had originally deleted using the label near top of the
> file but then moved next to the relevant node, where I cannot use label
> when deleting it. Should the smem_region also be moved to the top of the
> file if I move this delete-node there so the file would be consistent?
In [1] you were asked to move the delete-node statement, not to alter
the argument. Referencing nodes by label is allowed globally in the DTS.
The removal should stay inside reserved-memory.
Konrad
>
> [1] https://lore.kernel.org/linux-arm-msm/CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D36aCnBr38bo5HoJw@mail.gmail.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP
2022-11-28 20:59 ` Konrad Dybcio
@ 2022-11-28 21:06 ` Luca Weiss
2022-11-28 21:12 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Luca Weiss @ 2022-11-28 21:06 UTC (permalink / raw)
To: Matti Lehtimäki, linux-arm-msm, ~postmarketos/upstreaming
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel, Konrad Dybcio
On Montag, 28. November 2022 21:59:06 CET Konrad Dybcio wrote:
> On 28.11.2022 18:01, Matti Lehtimäki wrote:
> > On 28.11.2022 16.41, Konrad Dybcio wrote:
> >> On 25.11.2022 23:34, Matti Lehtimäki wrote:
> >>> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> >>> b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts index
> >>> 1c52337af560..859e91c16c61 100644
> >>> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> >>> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> >>> @@ -133,7 +133,8 @@ wcnss@d200000 {
> >>> no-map;
> >>> };
> >>> - adsp@d900000 {
> >>> + /delete-node/ adsp@dc00000;
> >>
> >> Please delete nodes by referencing the label like so:
> >>
> >> /delete-node/ &adsp_region;
> >
> > When I created the devicetree I was asked to do the opposite for the
> > smem_region [1] which I had originally deleted using the label near top of
> > the file but then moved next to the relevant node, where I cannot use
> > label when deleting it. Should the smem_region also be moved to the top
> > of the file if I move this delete-node there so the file would be
> > consistent?
> In [1] you were asked to move the delete-node statement, not to alter
> the argument. Referencing nodes by label is allowed globally in the DTS.
> The removal should stay inside reserved-memory.
Having e.g. this doesn't build, you get "syntax error" error
reserved-memory {
/delete-node/ &venus_region;
};
Not sure exactly why, but that's the reason everything's outside of the root
node if you use labels (don't ask me why labels lead to syntax error but
specifying the name manually works)
>
> Konrad
>
> > [1]
> > https://lore.kernel.org/linux-arm-msm/CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D
> > 36aCnBr38bo5HoJw@mail.gmail.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP
2022-11-28 21:06 ` Luca Weiss
@ 2022-11-28 21:12 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2022-11-28 21:12 UTC (permalink / raw)
To: Luca Weiss, Matti Lehtimäki, linux-arm-msm,
~postmarketos/upstreaming
Cc: phone-devel, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, devicetree, linux-kernel
On 28.11.2022 22:06, Luca Weiss wrote:
> On Montag, 28. November 2022 21:59:06 CET Konrad Dybcio wrote:
>> On 28.11.2022 18:01, Matti Lehtimäki wrote:
>>> On 28.11.2022 16.41, Konrad Dybcio wrote:
>>>> On 25.11.2022 23:34, Matti Lehtimäki wrote:
>>>>> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>>>>> b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts index
>>>>> 1c52337af560..859e91c16c61 100644
>>>>> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>>>>> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>>>>> @@ -133,7 +133,8 @@ wcnss@d200000 {
>>>>> no-map;
>>>>> };
>>>>> - adsp@d900000 {
>>>>> + /delete-node/ adsp@dc00000;
>>>>
>>>> Please delete nodes by referencing the label like so:
>>>>
>>>> /delete-node/ &adsp_region;
>>>
>>> When I created the devicetree I was asked to do the opposite for the
>>> smem_region [1] which I had originally deleted using the label near top of
>>> the file but then moved next to the relevant node, where I cannot use
>>> label when deleting it. Should the smem_region also be moved to the top
>>> of the file if I move this delete-node there so the file would be
>>> consistent?
>> In [1] you were asked to move the delete-node statement, not to alter
>> the argument. Referencing nodes by label is allowed globally in the DTS.
>> The removal should stay inside reserved-memory.
>
> Having e.g. this doesn't build, you get "syntax error" error
>
> reserved-memory {
> /delete-node/ &venus_region;
> };
>
> Not sure exactly why, but that's the reason everything's outside of the root
> node if you use labels (don't ask me why labels lead to syntax error but
> specifying the name manually works)
>
Hm.. The DT spec does not seem to limit where this syntax should work..
Perhaps it's a bug in DTC then.
Unless it does and I simply don't see it.
Konrad
>>
>> Konrad
>>
>>> [1]
>>> https://lore.kernel.org/linux-arm-msm/CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D
>>> 36aCnBr38bo5HoJw@mail.gmail.com/
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-28 21:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 22:34 [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP Matti Lehtimäki
2022-11-28 14:41 ` Konrad Dybcio
2022-11-28 17:01 ` Matti Lehtimäki
2022-11-28 20:59 ` Konrad Dybcio
2022-11-28 21:06 ` Luca Weiss
2022-11-28 21:12 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).