* [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" @ 2018-06-29 13:42 Mike Rapoport 2018-06-29 16:34 ` Randy Dunlap ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Mike Rapoport @ 2018-06-29 13:42 UTC (permalink / raw) To: Vineet Gupta; +Cc: lkml, Mike Rapoport Otherwise mm configuration options show up in the top level menu. Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> --- arch/arc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index e81bcd271be7..92cf06b354a8 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -554,8 +554,6 @@ menu "Executable file formats" source "fs/Kconfig.binfmt" endmenu -endmenu # "ARC Architecture Configuration" - source "mm/Kconfig" config FORCE_MAX_ZONEORDER @@ -563,6 +561,8 @@ config FORCE_MAX_ZONEORDER default "12" if ARC_HUGEPAGE_16M default "11" +endmenu # "ARC Architecture Configuration" + source "net/Kconfig" source "drivers/Kconfig" -- 2.7.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 13:42 [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" Mike Rapoport @ 2018-06-29 16:34 ` Randy Dunlap 2018-06-29 19:28 ` Mike Rapoport 2018-06-29 20:16 ` Vineet Gupta 2018-07-02 13:20 ` Christoph Hellwig 2 siblings, 1 reply; 11+ messages in thread From: Randy Dunlap @ 2018-06-29 16:34 UTC (permalink / raw) To: Mike Rapoport, Vineet Gupta; +Cc: lkml On 06/29/2018 06:42 AM, Mike Rapoport wrote: > Otherwise mm configuration options show up in the top level menu. > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> Hi Mike, In which config tool does this matter? For xconfig, it seems to me that this patch hides the MM menu, whereas before this patch, the MM menu is easy to find (although it could use some kind of heading). > --- > arch/arc/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig > index e81bcd271be7..92cf06b354a8 100644 > --- a/arch/arc/Kconfig > +++ b/arch/arc/Kconfig > @@ -554,8 +554,6 @@ menu "Executable file formats" > source "fs/Kconfig.binfmt" > endmenu > > -endmenu # "ARC Architecture Configuration" > - > source "mm/Kconfig" > > config FORCE_MAX_ZONEORDER > @@ -563,6 +561,8 @@ config FORCE_MAX_ZONEORDER > default "12" if ARC_HUGEPAGE_16M > default "11" > > +endmenu # "ARC Architecture Configuration" > + > source "net/Kconfig" > source "drivers/Kconfig" > > -- ~Randy ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 16:34 ` Randy Dunlap @ 2018-06-29 19:28 ` Mike Rapoport 2018-06-29 20:28 ` Randy Dunlap 0 siblings, 1 reply; 11+ messages in thread From: Mike Rapoport @ 2018-06-29 19:28 UTC (permalink / raw) To: Randy Dunlap; +Cc: Vineet Gupta, lkml Hi Randy, On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote: > On 06/29/2018 06:42 AM, Mike Rapoport wrote: > > Otherwise mm configuration options show up in the top level menu. > > > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > > Hi Mike, > > In which config tool does this matter? > > For xconfig, it seems to me that this patch hides the MM menu, whereas > before this patch, the MM menu is easy to find (although it could > use some kind of heading). With xconfig the menu gets into the top right pane when you click on "ARC architecture configuration", similar to what one gets on x86 with "Processor type and features" or "Kernel features" on ARM. With menuconfig it looks a bit more prominent, note that mm options are between "ARC Architecture Configuration" and "Networking support": .config - Linux/arc 4.18.0-rc2 Kernel Configuration ────────────────────────────────────────────────────────────────────────────── ┌─────────────── Linux/arc 4.18.0-rc2 Kernel Configuration ───────────────┐ │ Arrow keys navigate the menu. <Enter> selects submenus ---> (or empty │ │ submenus ----). Highlighted letters are hotkeys. Pressing <Y> │ │ includes, <N> excludes, <M> modularizes features. Press <Esc><Esc> to │ │ exit, <?> for Help, </> for Search. Legend: [*] built-in [ ] │ │ ┌─────────────────────────────────────────────────────────────────────┐ │ │ │ *** Compiler: arc-elf-gcc (GCC) 7.3.0 *** │ │ │ │ General setup ---> │ │ │ │ [*] Enable loadable module support ---> │ │ │ │ [*] Enable the block layer ---> │ │ │ │ ARC Architecture Configuration ---> │ │ │ │ [ ] Allow for memory compaction │ │ │ │ [*] Enable bounce buffers │ │ │ │ [ ] Enable KSM for page merging │ │ │ │ (4096) Low address space to protect from user allocation │ │ │ │ [ ] Enable cleancache driver to cache clean pages if tmem is pres│ │ │ │ [ ] Contiguous Memory Allocator │ │ │ │ < > Common API for compressed memory storage │ │ │ │ < > Low (Up to 2x) density storage for compressed pages │ │ │ │ < > Memory allocator for compressed pages │ │ │ │ [ ] Enable idle page tracking │ │ │ │ [ ] Collect percpu memory statistics │ │ │ │ [ ] Enable infrastructure for get_user_pages_fast() benchmarking │ │ │ │ (11) Maximum zone order │ │ │ │ [*] Networking support ---> │ │ │ │ Device Drivers ---> │ │ │ │ Bus Support ---> │ │ │ │ File systems ---> │ │ │ │ Kernel hacking ---> │ │ │ │ Security options ---> │ │ │ │ -*- Cryptographic API ---> │ │ │ │ Library routines ---> │ │ │ │ [ ] Device power management core functionality │ │ │ │ │ │ │ └─────────────────────────────────────────────────────────────────────┘ │ ├─────────────────────────────────────────────────────────────────────────┤ │ <Select> < Exit > < Help > < Save > < Load > │ └─────────────────────────────────────────────────────────────────────────┘ > > default "12" if ARC_HUGEPAGE_16M > > default "11" > > > > +endmenu # "ARC Architecture Configuration" > > + > > source "net/Kconfig" > > source "drivers/Kconfig" > > > > > > > -- > ~Randy > -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 19:28 ` Mike Rapoport @ 2018-06-29 20:28 ` Randy Dunlap 2018-06-29 20:37 ` Vineet Gupta 2018-06-29 20:57 ` Mike Rapoport 0 siblings, 2 replies; 11+ messages in thread From: Randy Dunlap @ 2018-06-29 20:28 UTC (permalink / raw) To: Mike Rapoport; +Cc: Vineet Gupta, lkml On 06/29/2018 12:28 PM, Mike Rapoport wrote: > Hi Randy, > > On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote: >> On 06/29/2018 06:42 AM, Mike Rapoport wrote: >>> Otherwise mm configuration options show up in the top level menu. >>> >>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> >> >> Hi Mike, >> >> In which config tool does this matter? >> >> For xconfig, it seems to me that this patch hides the MM menu, whereas >> before this patch, the MM menu is easy to find (although it could >> use some kind of heading). > > With xconfig the menu gets into the top right pane when you click on "ARC > architecture configuration", similar to what one gets on x86 with > "Processor type and features" or "Kernel features" on ARM. > > With menuconfig it looks a bit more prominent, note that mm options are > between "ARC Architecture Configuration" and "Networking support": I know. I ran all 4 of menuconfig, nconfig, xconfig, and gconfig. I would prefer to see Memory Management options have its own top-level menu, but that's a different patch. Then menuconfig would look like this: │ │ *** Compiler: arc-linux-gcc (GCC) 8.1.0 *** │ │ │ │ General setup ---> │ │ │ │ [*] Enable loadable module support ---> │ │ │ │ [*] Enable the block layer ---> │ │ │ │ ARC Architecture Configuration ---> │ │ │ │ Memory Management options ---> │ │ │ │ (11) Maximum zone order │ │ │ │ [*] Networking support ---> │ │ │ │ Device Drivers ---> │ │ │ │ Bus Support ---> but that "Maximum zone order" needs to be moved or taken care of somehow. [snip] > > > >>> default "12" if ARC_HUGEPAGE_16M >>> default "11" >>> >>> +endmenu # "ARC Architecture Configuration" >>> + >>> source "net/Kconfig" >>> source "drivers/Kconfig" thanks, -- ~Randy ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 20:28 ` Randy Dunlap @ 2018-06-29 20:37 ` Vineet Gupta 2018-06-29 20:57 ` Mike Rapoport 1 sibling, 0 replies; 11+ messages in thread From: Vineet Gupta @ 2018-06-29 20:37 UTC (permalink / raw) To: Randy Dunlap, Mike Rapoport; +Cc: lkml On 06/29/2018 01:29 PM, Randy Dunlap wrote: > On 06/29/2018 12:28 PM, Mike Rapoport wrote: >> Hi Randy, >> >> On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote: >>> On 06/29/2018 06:42 AM, Mike Rapoport wrote: >>>> Otherwise mm configuration options show up in the top level menu. >>>> >>>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> >>> Hi Mike, >>> >>> In which config tool does this matter? >>> >>> For xconfig, it seems to me that this patch hides the MM menu, whereas >>> before this patch, the MM menu is easy to find (although it could >>> use some kind of heading). >> With xconfig the menu gets into the top right pane when you click on "ARC >> architecture configuration", similar to what one gets on x86 with >> "Processor type and features" or "Kernel features" on ARM. >> >> With menuconfig it looks a bit more prominent, note that mm options are >> between "ARC Architecture Configuration" and "Networking support": > I know. I ran all 4 of menuconfig, nconfig, xconfig, and gconfig. > > I would prefer to see Memory Management options have its own top-level > menu, but that's a different patch. Then menuconfig would look like this: > > > > │ │ *** Compiler: arc-linux-gcc (GCC) 8.1.0 *** │ │ > │ │ General setup ---> │ │ > │ │ [*] Enable loadable module support ---> │ │ > │ │ [*] Enable the block layer ---> │ │ > │ │ ARC Architecture Configuration ---> │ │ > │ │ Memory Management options ---> │ │ > │ │ (11) Maximum zone order │ │ > │ │ [*] Networking support ---> │ │ > │ │ Device Drivers ---> │ │ > │ │ Bus Support ---> Indeed I realized after applying that we are cluttering the mm stuff inside ARC. So I don't see real net improvement with this patch/ > but that "Maximum zone order" needs to be moved or taken care of somehow. Right this is mm specific option which is provided for by arch. And even a redirector like ARCH_HAS_FORCE_MAX and moving this to generic mm won't cut it since the option values are arch specific ! -Vineet ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 20:28 ` Randy Dunlap 2018-06-29 20:37 ` Vineet Gupta @ 2018-06-29 20:57 ` Mike Rapoport 2018-06-29 21:12 ` Vineet Gupta 1 sibling, 1 reply; 11+ messages in thread From: Mike Rapoport @ 2018-06-29 20:57 UTC (permalink / raw) To: Randy Dunlap; +Cc: Vineet Gupta, lkml On Fri, Jun 29, 2018 at 01:28:59PM -0700, Randy Dunlap wrote: > On 06/29/2018 12:28 PM, Mike Rapoport wrote: > > Hi Randy, > > > > On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote: > >> On 06/29/2018 06:42 AM, Mike Rapoport wrote: > >>> Otherwise mm configuration options show up in the top level menu. > >>> > >>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > >> > >> Hi Mike, > >> > >> In which config tool does this matter? > >> > >> For xconfig, it seems to me that this patch hides the MM menu, whereas > >> before this patch, the MM menu is easy to find (although it could > >> use some kind of heading). > > > > With xconfig the menu gets into the top right pane when you click on "ARC > > architecture configuration", similar to what one gets on x86 with > > "Processor type and features" or "Kernel features" on ARM. > > > > With menuconfig it looks a bit more prominent, note that mm options are > > between "ARC Architecture Configuration" and "Networking support": > > I know. I ran all 4 of menuconfig, nconfig, xconfig, and gconfig. > > I would prefer to see Memory Management options have its own top-level > menu, but that's a different patch. Then menuconfig would look like this: > > > > │ │ *** Compiler: arc-linux-gcc (GCC) 8.1.0 *** │ │ > │ │ General setup ---> │ │ > │ │ [*] Enable loadable module support ---> │ │ > │ │ [*] Enable the block layer ---> │ │ > │ │ ARC Architecture Configuration ---> │ │ > │ │ Memory Management options ---> │ │ > │ │ (11) Maximum zone order │ │ > │ │ [*] Networking support ---> │ │ > │ │ Device Drivers ---> │ │ > │ │ Bus Support ---> > > > but that "Maximum zone order" needs to be moved or taken care of somehow. I think that would be something like this: diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index e81bcd271be7..44a20141639a 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -556,12 +556,14 @@ endmenu endmenu # "ARC Architecture Configuration" +menu "Memory Management" source "mm/Kconfig" config FORCE_MAX_ZONEORDER int "Maximum zone order" default "12" if ARC_HUGEPAGE_16M default "11" +endmenu # "Memory Management" source "net/Kconfig" source "drivers/Kconfig" > > [snip] > > > > > > > > >>> default "12" if ARC_HUGEPAGE_16M > >>> default "11" > >>> > >>> +endmenu # "ARC Architecture Configuration" > >>> + > >>> source "net/Kconfig" > >>> source "drivers/Kconfig" > > > thanks, > -- > ~Randy > -- Sincerely yours, Mike. ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 20:57 ` Mike Rapoport @ 2018-06-29 21:12 ` Vineet Gupta 2018-06-30 6:08 ` Randy Dunlap 0 siblings, 1 reply; 11+ messages in thread From: Vineet Gupta @ 2018-06-29 21:12 UTC (permalink / raw) To: Mike Rapoport, Randy Dunlap; +Cc: arcml, lkml On 06/29/2018 01:57 PM, Mike Rapoport wrote: > I think that would be something like this: > diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig > index e81bcd271be7..44a20141639a 100644 > --- a/arch/arc/Kconfig > +++ b/arch/arc/Kconfig > @@ -556,12 +556,14 @@ endmenu > > endmenu # "ARC Architecture Configuration" > > +menu "Memory Management" > source "mm/Kconfig" > > config FORCE_MAX_ZONEORDER > int "Maximum zone order" > default "12" if ARC_HUGEPAGE_16M > default "11" > +endmenu # "Memory Management" > > source "net/Kconfig" > source "drivers/Kconfig" > Awesome, this is exactly we want - care to send a formal patch ? -Vineet ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 21:12 ` Vineet Gupta @ 2018-06-30 6:08 ` Randy Dunlap 0 siblings, 0 replies; 11+ messages in thread From: Randy Dunlap @ 2018-06-30 6:08 UTC (permalink / raw) To: Vineet Gupta, Mike Rapoport; +Cc: arcml, lkml On 06/29/2018 02:12 PM, Vineet Gupta wrote: > On 06/29/2018 01:57 PM, Mike Rapoport wrote: >> I think that would be something like this: >> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig >> index e81bcd271be7..44a20141639a 100644 >> --- a/arch/arc/Kconfig >> +++ b/arch/arc/Kconfig >> @@ -556,12 +556,14 @@ endmenu >> >> endmenu # "ARC Architecture Configuration" >> >> +menu "Memory Management" >> source "mm/Kconfig" >> >> config FORCE_MAX_ZONEORDER >> int "Maximum zone order" >> default "12" if ARC_HUGEPAGE_16M >> default "11" >> +endmenu # "Memory Management" >> >> source "net/Kconfig" >> source "drivers/Kconfig" >> > > Awesome, this is exactly we want - care to send a formal patch ? > > -Vineet Mike, I interpret this as a reply to you. And you can add: Tested-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> and possibly: Suggested-by: Randy Dunlap <rdunlap@infradead.org> thanks, -- ~Randy ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 13:42 [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" Mike Rapoport 2018-06-29 16:34 ` Randy Dunlap @ 2018-06-29 20:16 ` Vineet Gupta 2018-07-02 13:20 ` Christoph Hellwig 2 siblings, 0 replies; 11+ messages in thread From: Vineet Gupta @ 2018-06-29 20:16 UTC (permalink / raw) To: Mike Rapoport, arcml; +Cc: lkml On 06/29/2018 06:42 AM, Mike Rapoport wrote: > Otherwise mm configuration options show up in the top level menu. > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > LGTM ! Added to for-curr Thx, -Vineet ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-06-29 13:42 [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" Mike Rapoport 2018-06-29 16:34 ` Randy Dunlap 2018-06-29 20:16 ` Vineet Gupta @ 2018-07-02 13:20 ` Christoph Hellwig 2018-07-02 14:29 ` Mike Rapoport 2 siblings, 1 reply; 11+ messages in thread From: Christoph Hellwig @ 2018-07-02 13:20 UTC (permalink / raw) To: Mike Rapoport; +Cc: Vineet Gupta, lkml On Fri, Jun 29, 2018 at 04:42:27PM +0300, Mike Rapoport wrote: > Otherwise mm configuration options show up in the top level menu. > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> Is this urgent? If not I'm about to post a series that moves the includes of all common kernel Kconfigs into the top-level Kconfig.. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" 2018-07-02 13:20 ` Christoph Hellwig @ 2018-07-02 14:29 ` Mike Rapoport 0 siblings, 0 replies; 11+ messages in thread From: Mike Rapoport @ 2018-07-02 14:29 UTC (permalink / raw) To: Christoph Hellwig; +Cc: Vineet Gupta, lkml On Mon, Jul 02, 2018 at 06:20:56AM -0700, Christoph Hellwig wrote: > On Fri, Jun 29, 2018 at 04:42:27PM +0300, Mike Rapoport wrote: > > Otherwise mm configuration options show up in the top level menu. > > > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > > Is this urgent? If not I'm about to post a series that moves the > includes of all common kernel Kconfigs into the top-level Kconfig.. I believe it's not. The arch/arc/Kconfig had it for couple of years :) -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-07-02 14:29 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-06-29 13:42 [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" Mike Rapoport 2018-06-29 16:34 ` Randy Dunlap 2018-06-29 19:28 ` Mike Rapoport 2018-06-29 20:28 ` Randy Dunlap 2018-06-29 20:37 ` Vineet Gupta 2018-06-29 20:57 ` Mike Rapoport 2018-06-29 21:12 ` Vineet Gupta 2018-06-30 6:08 ` Randy Dunlap 2018-06-29 20:16 ` Vineet Gupta 2018-07-02 13:20 ` Christoph Hellwig 2018-07-02 14:29 ` Mike Rapoport
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).