* [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe().
@ 2020-05-24 3:46 wu000273
2020-05-24 19:03 ` Sylwester Nawrocki
0 siblings, 1 reply; 4+ messages in thread
From: wu000273 @ 2020-05-24 3:46 UTC (permalink / raw)
To: sylvester.nawrocki
Cc: mchehab, linux-media, linux-samsung-soc, linux-kernel, kjlu, wu000273
From: Qiushi Wu <wu000273@umn.edu>
"pm_runtime_enable()" was not handled by "pm_runtime_disable()"
after a call of the function “pm_runtime_get_sync()” failed.
Thus move the jump target “err_pm” before calling function
"calling pm_runtime_disable()".
Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
V2: improving commit messages.
---
drivers/media/platform/s3c-camif/camif-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
index c6fbcd7036d6..12ee49638f44 100644
--- a/drivers/media/platform/s3c-camif/camif-core.c
+++ b/drivers/media/platform/s3c-camif/camif-core.c
@@ -500,8 +500,8 @@ static int s3c_camif_probe(struct platform_device *pdev)
camif_unregister_media_entities(camif);
err_alloc:
pm_runtime_put(dev);
- pm_runtime_disable(dev);
err_pm:
+ pm_runtime_disable(dev);
camif_clk_put(camif);
err_clk:
s3c_camif_unregister_subdev(camif);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe().
2020-05-24 3:46 [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe() wu000273
@ 2020-05-24 19:03 ` Sylwester Nawrocki
2020-05-24 19:27 ` Sylwester Nawrocki
0 siblings, 1 reply; 4+ messages in thread
From: Sylwester Nawrocki @ 2020-05-24 19:03 UTC (permalink / raw)
To: wu000273; +Cc: mchehab, linux-media, linux-samsung-soc, linux-kernel, kjlu
Hi,
On 5/24/20 05:46, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
> after a call of the function “pm_runtime_get_sync()” failed.
> Thus move the jump target “err_pm” before calling function
> "calling pm_runtime_disable()".
>
> Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> ---
>
> V2: improving commit messages.
Thanks for the patch. It seems you have got typo in the subject line.
With tegra_adma_probe changed to s3c_camif_probe feel free to add:
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe().
2020-05-24 19:03 ` Sylwester Nawrocki
@ 2020-05-24 19:27 ` Sylwester Nawrocki
0 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2020-05-24 19:27 UTC (permalink / raw)
To: wu000273; +Cc: mchehab, linux-media, linux-samsung-soc, linux-kernel, kjlu
On 5/24/20 21:03, Sylwester Nawrocki wrote:
> On 5/24/20 05:46, wu000273@umn.edu wrote:
>> From: Qiushi Wu <wu000273@umn.edu>
>>
>> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
>> after a call of the function “pm_runtime_get_sync()” failed.
>> Thus move the jump target “err_pm” before calling function
>> "calling pm_runtime_disable()".
>>
>> Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC
>> series camera interface")
>> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
>> ---
>>
>> V2: improving commit messages.
>
> Thanks for the patch. It seems you have got typo in the subject line.
> With tegra_adma_probe changed to s3c_camif_probe feel free to add:
>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
I just noticed this patch https://patchwork.linuxtv.org/patch/63976
which includes your fix and handles one more issue. Thus it might be
better to apply the patch from Dinghao Liu instead.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: s3c-camif: Fix missing disable in tegra_adma_probe()
@ 2020-05-24 9:03 Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2020-05-24 9:03 UTC (permalink / raw)
To: Qiushi Wu, linux-media, linux-samsung-soc
Cc: linux-kernel, Kangjie Lu, Mauro Carvalho Chehab, Sylwester Nawrocki
> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
> after a call of the function “pm_runtime_get_sync()” failed.
> Thus move the jump target “err_pm” before calling function
> "calling pm_runtime_disable()".
I find such a change description still improvable (also according to
the shown combination of quotation characters).
> ---
>
> V2: improving commit messages.
You proposed a slightly different wording variant.
> ---
> drivers/media/platform/s3c-camif/camif-core.c | 2 +-
I suggest to delete the triple dashes before this diffstat.
I would find it nicer if you would put mail addresses from patch reviewers (like me)
also directly into the message field “Cc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n515
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-24 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 3:46 [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe() wu000273
2020-05-24 19:03 ` Sylwester Nawrocki
2020-05-24 19:27 ` Sylwester Nawrocki
2020-05-24 9:03 [PATCH v2] media: s3c-camif: Fix " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).