linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: John Fremlin <chief@bandits.org>
Cc: johnsom@orst.edu, linux-kernel@vger.kernel.org
Subject: Re: Changes to ide-cd for 2.4.1 are broken?
Date: Sun, 18 Feb 2001 20:19:54 +0100	[thread overview]
Message-ID: <20010218201954.B6593@suse.de> (raw)
In-Reply-To: <m2k86pnfch.fsf@boreas.yi.org.>
In-Reply-To: <m2k86pnfch.fsf@boreas.yi.org.>; from chief@bandits.org on Sat, Feb 17, 2001 at 09:56:30PM +0000

On Sat, Feb 17 2001, John Fremlin wrote:
> Specifically, this part:
> 
> @@ -2324,11 +2309,17 @@
>                     sense.ascq == 0x04)
>                         return CDS_DISC_OK;
>  
> +
> +               /*
> +                * If not using Mt Fuji extended media tray reports,
> +                * just return TRAY_OPEN since ATAPI doesn't provide
> +                * any other way to detect this...
> +                */
>                 if (sense.sense_key == NOT_READY) {
> -                       /* ATAPI doesn't have anything that can help
> -                          us decide whether the drive is really
> -                          emtpy or the tray is just open. irk. */
> -                       return CDS_TRAY_OPEN;
> +                       if (sense.asc == 0x3a && (!sense.ascq||sense.ascq == 1))
> +                               return CDS_NO_DISC;
> +                       else
> +                               return CDS_TRAY_OPEN;
>                 }
> 
> My tray is open as I type, and it is misreported as CDS_NO_DISC. In
> 2.4.0 it worked fine.

Your drive is broken, the only other valid combination is 0x3a/0x02 which means
no media and tray open. You could try and dump the asc and ascq to see what
your drive reports for the different states.

-- 
Jens Axboe


  reply	other threads:[~2001-02-18 19:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-17 21:56 Changes to ide-cd for 2.4.1 are broken? John Fremlin
2001-02-18 19:19 ` Jens Axboe [this message]
2001-02-18 20:32 Andries.Brouwer
2001-02-18 20:57 ` Jens Axboe
2001-02-22 16:46   ` John Fremlin
     [not found] <001801c09e3a$4a189270$653b090a@sulaco>
2001-03-01 18:52 ` John Fremlin
2001-06-10 17:37   ` John Fremlin
2001-06-11  0:41     ` Michael Johnson
2001-06-11 10:01       ` John Fremlin
2001-10-10 21:03       ` Enrico Scholz
2001-10-10 21:16         ` Enrico Scholz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010218201954.B6593@suse.de \
    --to=axboe@suse.de \
    --cc=chief@bandits.org \
    --cc=johnsom@orst.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).