From: Jens Axboe <axboe@suse.de>
To: Andries.Brouwer@cwi.nl
Cc: chief@bandits.org, johnsom@orst.edu, linux-kernel@vger.kernel.org
Subject: Re: Changes to ide-cd for 2.4.1 are broken?
Date: Sun, 18 Feb 2001 21:57:27 +0100 [thread overview]
Message-ID: <20010218215727.D6593@suse.de> (raw)
In-Reply-To: <UTC200102182032.VAA132602.aeb@vlet.cwi.nl>
In-Reply-To: <UTC200102182032.VAA132602.aeb@vlet.cwi.nl>; from Andries.Brouwer@cwi.nl on Sun, Feb 18, 2001 at 09:32:32PM +0100
On Sun, Feb 18 2001, Andries.Brouwer@cwi.nl wrote:
> > + /*
> > + * If not using Mt Fuji extended media tray reports,
> > + * just return TRAY_OPEN since ATAPI doesn't provide
> > + * any other way to detect this...
> > + */
> > if (sense.sense_key == NOT_READY) {
> > - /* ATAPI doesn't have anything that can help
> > - us decide whether the drive is really
> > - emtpy or the tray is just open. irk. */
> > - return CDS_TRAY_OPEN;
> > + if (sense.asc == 0x3a && (!sense.ascq||sense.ascq == 1))
> > + return CDS_NO_DISC;
> > + else
> > + return CDS_TRAY_OPEN;
> > }
> >
> > My tray is open as I type, and it is misreported as CDS_NO_DISC. In
> > 2.4.0 it worked fine.
>
> Your drive is broken, the only other valid combination is 0x3a/0x02
> which means no media and tray open. You could try and dump the asc
> and ascq to see what your drive reports for the different states.
>
> Ha Jens - must we disagree twice on one evening?
:-)
> You know all about this stuff, so probably I am mistaken.
> However, my copy of SFF8020-r2.6 everywhere has
> "Sense 02 ASC 3A: Medium not present" without giving
> subcodes to distinguish Tray Open from No Disc.
> So, it seems to me that drives built to this spec will not have
> nonzero ASCQ.
Right, old ATAPI has 3a/02 as the only possible condition, so we
can't really tell between no disc and tray open. I guess the safest
is to just keep the old behaviour for !ascq and report open.
--
Jens Axboe
next prev parent reply other threads:[~2001-02-18 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-18 20:32 Changes to ide-cd for 2.4.1 are broken? Andries.Brouwer
2001-02-18 20:57 ` Jens Axboe [this message]
2001-02-22 16:46 ` John Fremlin
[not found] <001801c09e3a$4a189270$653b090a@sulaco>
2001-03-01 18:52 ` John Fremlin
2001-06-10 17:37 ` John Fremlin
2001-06-11 0:41 ` Michael Johnson
2001-06-11 10:01 ` John Fremlin
2001-10-10 21:03 ` Enrico Scholz
2001-10-10 21:16 ` Enrico Scholz
-- strict thread matches above, loose matches on Subject: below --
2001-02-17 21:56 John Fremlin
2001-02-18 19:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010218215727.D6593@suse.de \
--to=axboe@suse.de \
--cc=Andries.Brouwer@cwi.nl \
--cc=chief@bandits.org \
--cc=johnsom@orst.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).