From: John Fremlin <vii@users.sourceforge.net>
To: Michael Johnson <johnsom@home.com>
Cc: John Fremlin <vii@users.sourceforge.net>,
Jens Axboe <axboe@suse.de>, <Andries.Brouwer@cwi.nl>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
<linux-kernel@vger.kernel.org>
Subject: Re: Changes to ide-cd for 2.4.1 are broken?
Date: 11 Jun 2001 11:01:17 +0100 [thread overview]
Message-ID: <m2iti3l4ia.fsf@boreas.yi.org.> (raw)
In-Reply-To: <001801c09e3a$4a189270$653b090a@sulaco> <m27l29tj87.fsf@boreas.yi.org.> <m28zj05j7y.fsf@boreas.yi.org.> <008401c0f20f$4458dec0$643b090a@sulaco>
In-Reply-To: <008401c0f20f$4458dec0$643b090a@sulaco> ("Michael Johnson"'s message of "Sun, 10 Jun 2001 17:41:34 -0700")
"Michael Johnson" <johnsom@home.com> writes:
> So, the patch you are proposing will always consider the tray open, even if
> it is closed. Why do you need this behavior?
>
> Why is checking CDS_TRAY_OPEN, to see if the tray is open, broken?
You broke it (I think it was you).
> The code in cdrom.c looks fine to me.
Yes but you changed ide-cd.c to report CDS_NO_DISC if the tray might
be open or there is no disc. I complained about this at the time, you
may recall.
> ----- Original Message -----
> From: "John Fremlin" <vii@users.sourceforge.net>
> To: "Michael Johnson" <johnsom@home.com>
> Cc: "Jens Axboe" <axboe@suse.de>; <Andries.Brouwer@cwi.nl>; "Alan Cox"
> <alan@lxorguk.ukuu.org.uk>; <linux-kernel@vger.kernel.org>
> Sent: Sunday, June 10, 2001 10:37 AM
> Subject: Re: Changes to ide-cd for 2.4.1 are broken?
>
>
> >
> > Hi all, this is an old thread. It was started because the return value
> > from cd info was changed in 2.4.1 in the case when the tray might be
> > open or there simply be no disc in the drive for an IDE
> > CD-ROM.
> >
> > John Fremlin <chief@bandits.org> writes:
> >
> > > "Michael Johnson" <johnsom@home.com> writes:
> >
> > [...]
> >
> > > > >Right, old ATAPI has 3a/02 as the only possible condition, so we
> > > > >can't really tell between no disc and tray open. I guess the safest
> > > > >is to just keep the old behaviour for !ascq and report open.
> > >
> > > > I don't understand why the current(2.4.1) behavior is a problem...
> >
> > Unfortunately changing the return code means that the generic cdrom.c
> > code is broekn, in particular wrt to having the cdrom drive open
> > automatically when umounted, and to close when attempted to be
> > mounted.
> >
> > (You can set this mode with "cdd auto" if you have my asm-toys installed
> > http://ape.n3.net/programs/linux/asm-toys
> > )
> >
> > The following patch fixes that. I also attempted to fix up similar
> > problems (where checking CDS_TRAY_OPEN is used to see if the tray is
> > open, which is obviously broekn).
> >
> >
>
>
> ----------------------------------------------------------------------------
> ----
>
>
> >
> > --
> >
> > http://ape.n3.net
> >
>
--
http://ape.n3.net
next prev parent reply other threads:[~2001-06-11 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001801c09e3a$4a189270$653b090a@sulaco>
2001-03-01 18:52 ` Changes to ide-cd for 2.4.1 are broken? John Fremlin
2001-06-10 17:37 ` John Fremlin
2001-06-11 0:41 ` Michael Johnson
2001-06-11 10:01 ` John Fremlin [this message]
2001-10-10 21:03 ` Enrico Scholz
2001-10-10 21:16 ` Enrico Scholz
2001-02-18 20:32 Andries.Brouwer
2001-02-18 20:57 ` Jens Axboe
2001-02-22 16:46 ` John Fremlin
-- strict thread matches above, loose matches on Subject: below --
2001-02-17 21:56 John Fremlin
2001-02-18 19:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2iti3l4ia.fsf@boreas.yi.org. \
--to=vii@users.sourceforge.net \
--cc=Andries.Brouwer@cwi.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=johnsom@home.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).