From: Andrea Arcangeli <andrea@suse.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.1-ac15
Date: Sat, 24 Feb 2001 05:04:02 +0100 [thread overview]
Message-ID: <20010224050402.A32367@athlon.random> (raw)
In-Reply-To: <20010223214057.A22808@athlon.random> <Pine.LNX.4.10.10102231306140.21515-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.10.10102231306140.21515-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Fri, Feb 23, 2001 at 01:09:02PM -0800
On Fri, Feb 23, 2001 at 01:09:02PM -0800, Linus Torvalds wrote:
>
>
> On Fri, 23 Feb 2001, Andrea Arcangeli wrote:
> >
> > I think that can't happen. Infact I think the whole section:
> >
> > pmd = pmd_offset(pgd, address);
> > pmd_k = pmd_offset(pgd_k, address);
> >
> > if (pmd_present(*pmd) || !pmd_present(*pmd_k))
> > goto bad_area_nosemaphore;
> > set_pmd(pmd, *pmd_k);
> > return;
> >
> > is superflows.
>
> No. Think about the differences in PAE and non-PAE mode.
>
> > The middle pagetable is shared and the pmd_t entry is set by vmalloc itself (it
> > just points to the as well shared pte), it's only the pgd that is setup lazily
>
> In non-PAE mode, the pgd entry doesn't exist. pgd_present() returns a
> unconditional 1. Its' the pmd functions that kick in then.
Woops, I see, I was thinking only PAE mode indeed 8), sorry. Thanks for the
correction.
All the rest still applies (and the patch still looks fine for PAE mode). I
think I only need to rediff my patch after resurrecting the pmd thing inside
the cli critical section in a #ifndef CONFIG_X86_PAE region.
Andrea
next prev parent reply other threads:[~2001-02-24 4:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-15 23:15 Linux 2.4.1-ac15 Alan Cox
2001-02-19 9:47 ` Philipp Rumpf
2001-02-19 11:35 ` Alan Cox
2001-02-19 11:54 ` Philipp Rumpf
2001-02-19 16:03 ` Alan Cox
2001-02-19 16:21 ` Philipp Rumpf
2001-02-19 16:27 ` Alan Cox
2001-02-19 16:34 ` Philipp Rumpf
2001-02-19 16:41 ` Alan Cox
2001-02-19 16:48 ` Philipp Rumpf
2001-02-19 17:03 ` Alan Cox
2001-02-21 3:02 ` Rusty Russell
2001-02-21 12:01 ` Alan Cox
2001-02-22 2:05 ` Rusty Russell
2001-02-22 10:22 ` Alan Cox
2001-02-23 0:01 ` Philipp Rumpf
2001-02-22 2:27 ` Linus Torvalds
2001-02-22 10:29 ` Alan Cox
2001-02-23 20:40 ` Andrea Arcangeli
2001-02-23 21:09 ` Linus Torvalds
2001-02-24 4:04 ` Andrea Arcangeli [this message]
2001-02-24 4:54 ` Andrea Arcangeli
2001-02-19 11:54 ` Keith Owens
2001-02-19 12:15 ` Philipp Rumpf
2001-02-19 13:15 ` Keith Owens
2001-02-19 13:25 ` Christoph Hellwig
2001-02-19 21:32 ` Keith Owens
2001-02-19 13:36 ` Philipp Rumpf
2001-02-19 15:23 ` Manfred Spraul
2001-02-19 16:04 ` Alan Cox
2001-02-19 21:52 ` Keith Owens
2001-02-20 12:29 ` Philipp Rumpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010224050402.A32367@athlon.random \
--to=andrea@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).