linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: prumpf@mandrakesoft.com (Philipp Rumpf)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
	linux-kernel@vger.kernel.org,
	prumpf@parcelfarce.linux.theplanet.co.uk
Subject: Re: Linux 2.4.1-ac15
Date: Mon, 19 Feb 2001 11:35:08 +0000 (GMT)	[thread overview]
Message-ID: <E14Uob0-0003Cs-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.3.96.1010219034311.16489B-100000@mandrakesoft.mandrakesoft.com> from "Philipp Rumpf" at Feb 19, 2001 03:47:42 AM

> The module list is modified atomically, so either we search the new table
> or we don't, but we never see intermediate states.  Not searching the new
> table shouldn't be a problem as we shouldn't run module code until
> sys_init_module time.

The problem isnt running module code. What happens in this case

        mod->next = module_list;
        module_list = mod;      /* link it in */

Note no write barrier.

Delete is even worse

We unlink the module
We free the memory

At the same time another cpu may be walking the exception table that we free.




  reply	other threads:[~2001-02-19 11:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-15 23:15 Linux 2.4.1-ac15 Alan Cox
2001-02-19  9:47 ` Philipp Rumpf
2001-02-19 11:35   ` Alan Cox [this message]
2001-02-19 11:54     ` Philipp Rumpf
2001-02-19 16:03       ` Alan Cox
2001-02-19 16:21         ` Philipp Rumpf
2001-02-19 16:27           ` Alan Cox
2001-02-19 16:34             ` Philipp Rumpf
2001-02-19 16:41               ` Alan Cox
2001-02-19 16:48                 ` Philipp Rumpf
2001-02-19 17:03                   ` Alan Cox
2001-02-21  3:02       ` Rusty Russell
2001-02-21 12:01         ` Alan Cox
2001-02-22  2:05           ` Rusty Russell
2001-02-22 10:22             ` Alan Cox
2001-02-23  0:01               ` Philipp Rumpf
2001-02-22  2:27           ` Linus Torvalds
2001-02-22 10:29             ` Alan Cox
2001-02-23 20:40               ` Andrea Arcangeli
2001-02-23 21:09                 ` Linus Torvalds
2001-02-24  4:04                   ` Andrea Arcangeli
2001-02-24  4:54                     ` Andrea Arcangeli
2001-02-19 11:54     ` Keith Owens
2001-02-19 12:15       ` Philipp Rumpf
2001-02-19 13:15         ` Keith Owens
2001-02-19 13:25           ` Christoph Hellwig
2001-02-19 21:32             ` Keith Owens
2001-02-19 13:36           ` Philipp Rumpf
2001-02-19 15:23           ` Manfred Spraul
2001-02-19 16:04       ` Alan Cox
2001-02-19 21:52         ` Keith Owens
2001-02-20 12:29           ` Philipp Rumpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E14Uob0-0003Cs-00@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prumpf@mandrakesoft.com \
    --cc=prumpf@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).