* [PATCH] eth16i.c: don't reference skb after passing it to netif_rx
@ 2001-02-26 23:44 Arnaldo Carvalho de Melo
0 siblings, 0 replies; only message in thread
From: Arnaldo Carvalho de Melo @ 2001-02-26 23:44 UTC (permalink / raw)
To: Alan Cox, Mika Kuoppala, linux-kernel
yet another one. 8)
Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu:
Hi,
I've just read davem's post at netdev about the brokeness of
referencing skbs after passing it to netif_rx, so please consider applying
this patch. Ah, this was just added to the Janitor's TODO list at
http://bazar.conectiva.com.br/~acme/TODO and I'm doing a quick audit in the
net drivers searching for this, maybe some more patches will follow.
- Arnaldo
--- linux-2.4.2/drivers/net/eth16i.c Tue Feb 13 19:15:05 2001
+++ linux-2.4.2.acme/drivers/net/eth16i.c Mon Feb 26 22:16:19 2001
@@ -1195,10 +1195,6 @@
}
skb->protocol=eth_type_trans(skb, dev);
- netif_rx(skb);
- dev->last_rx = jiffies;
- lp->stats.rx_packets++;
- lp->stats.rx_bytes += pkt_len;
if( eth16i_debug > 5 ) {
int i;
@@ -1208,6 +1204,10 @@
printk(KERN_DEBUG " %02x", skb->data[i]);
printk(KERN_DEBUG ".\n");
}
+ netif_rx(skb);
+ dev->last_rx = jiffies;
+ lp->stats.rx_packets++;
+ lp->stats.rx_bytes += pkt_len;
} /* else */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-02-27 1:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-02-26 23:44 [PATCH] eth16i.c: don't reference skb after passing it to netif_rx Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).