* [PATCH] fix warning in tdfxfb.c @ 2001-06-16 18:12 Steven Walter [not found] ` <E15BKmL-0008Q7-00@the-village.bc.nu> 0 siblings, 1 reply; 3+ messages in thread From: Steven Walter @ 2001-06-16 18:12 UTC (permalink / raw) To: linux-kernel This patch is obviously correct. It doesn't appear that tdfxfb has a maintainer, so I'm sending this patch to the list. Nothing earth-shattering, it just removes a warning during build. -- -Steven In a time of universal deceit, telling the truth is a revolutionary act. -- George Orwell --- tdfxfb.c~ Sat Jun 16 13:09:08 2001 +++ tdfxfb.c Sat Jun 16 13:09:21 2001 @@ -1892,7 +1892,7 @@ ((pdev->device == PCI_DEVICE_ID_3DFX_BANSHEE) || (pdev->device == PCI_DEVICE_ID_3DFX_VOODOO3) || (pdev->device == PCI_DEVICE_ID_3DFX_VOODOO5))) { - char *name; + char *name = NULL; fb_info.dev = pdev->device; switch (pdev->device) { ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <E15BKmL-0008Q7-00@the-village.bc.nu>]
* Re: [PATCH] fix warning in tdfxfb.c [not found] ` <E15BKmL-0008Q7-00@the-village.bc.nu> @ 2001-06-16 18:32 ` Steven Walter [not found] ` <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com> 0 siblings, 1 reply; 3+ messages in thread From: Steven Walter @ 2001-06-16 18:32 UTC (permalink / raw) To: Alan Cox; +Cc: linux-kernel I'm using 2.95.2; perhaps its fixed in 2.96/CVS? On Sat, Jun 16, 2001 at 07:26:37PM +0100, Alan Cox wrote: > > This patch is obviously correct. It doesn't appear that tdfxfb has a > > maintainer, so I'm sending this patch to the list. Nothing > > > earth-shattering, it just removes a warning during build. > > Yep.. Im actually suprised gcc couldnt work that one out itself. -- -Steven In a time of universal deceit, telling the truth is a revolutionary act. -- George Orwell ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com>]
* Re: [PATCH] fix warning in tdfxfb.c [not found] ` <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com> @ 2001-06-16 20:10 ` Steven Walter 0 siblings, 0 replies; 3+ messages in thread From: Steven Walter @ 2001-06-16 20:10 UTC (permalink / raw) To: Josh Myer; +Cc: linux-kernel On Sat, Jun 16, 2001 at 02:59:34PM -0500, Josh Myer wrote: > It might be better to add a default case to the switch statement below, so > this symbol doesn't just eat up another 4(8 on some platforms, and i'm > sure others) bytes of memory unneccesarily. I'm not quite sure I follow you. The default case should never be reached, because only the three cases currently present are allowed by the encapsulating 'if' statement. Even so, how would adding a default case get rid of the variable or save space some other way? > anyway, it doesn't really matter. i'd test my hypothesis, but i've got > people coming over this afternoon =) the driver looks like it might use > some scrubbing anyway (s!//(.*)$!/\* $1 \*/!...) Good point. Perhaps I'll prepare a larger patch with this and other cleanups. -- -Steven In a time of universal deceit, telling the truth is a revolutionary act. -- George Orwell ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-06-16 20:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2001-06-16 18:12 [PATCH] fix warning in tdfxfb.c Steven Walter [not found] ` <E15BKmL-0008Q7-00@the-village.bc.nu> 2001-06-16 18:32 ` Steven Walter [not found] ` <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com> 2001-06-16 20:10 ` Steven Walter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).