From: Jens Axboe <axboe@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org, andrea@suse.de
Subject: Re: [patch] zero-bounce highmem I/O
Date: Thu, 16 Aug 2001 13:51:50 +0200 [thread overview]
Message-ID: <20010816135150.X4352@suse.de> (raw)
In-Reply-To: <20010815.053524.48804759.davem@redhat.com> <20010815151052.C4352@suse.de> <20010815.070204.39155321.davem@redhat.com> <20010815.072548.48531893.davem@redhat.com>
In-Reply-To: <20010815.072548.48531893.davem@redhat.com>
On Wed, Aug 15 2001, David S. Miller wrote:
> From: "David S. Miller" <davem@redhat.com>
> Date: Wed, 15 Aug 2001 07:02:04 -0700 (PDT)
>
> > Yep. Want me to add in the x86 parts of your patch?
> >
> > Please let me finish up my prototype with sparc64 building and
> > working, then I'll send you what I have ok?
>
> Fine
>
> This is forthcoming.
>
> As promised. I actually got bored during the build and tried to
Looks good! And works here too, even... ->
> quickly cook up the ix86 bits myself :-)
the boring x86 parts :-)
The only difference between your and my tree now is the PCI_MAX_DMA32
flag. Would you consider this? I already use this flag in the block
stuff, I just updated the two references you had. Maybe
PCI_MAX_DMA32_MASK is a better name.
I'll update the block-highmem patch later today -- and with this in
place, there's nothing stopping zero-bounce from going beyond 4GB on the
right hw. Yippi.
--- linux/include/linux/pci.h~ Thu Aug 16 13:40:32 2001
+++ linux/include/linux/pci.h Thu Aug 16 13:41:11 2001
@@ -314,6 +314,8 @@
#define PCI_DMA_FROMDEVICE 2
#define PCI_DMA_NONE 3
+#define PCI_MAX_DMA32 0xffffffff
+
/* These are the boolean attributes stored in pci_dev->dma_flags. */
#define PCI_DMA_FLAG_HUGE_MAPS 0x00000001 /* Device may hold an enormous number
* of mappings at once?
--- linux/drivers/scsi/sym53c8xx.c~ Thu Aug 16 13:42:27 2001
+++ linux/drivers/scsi/sym53c8xx.c Thu Aug 16 13:42:50 2001
@@ -13101,7 +13101,7 @@
(int) (PciDeviceFn(pdev) & 7));
#ifdef SCSI_NCR_DYNAMIC_DMA_MAPPING
- if (pci_set_dma_mask(pdev, 0xffffffff)) {
+ if (pci_set_dma_mask(pdev, PCI_MAX_DMA32)) {
printk(KERN_WARNING NAME53C8XX
"32 BIT PCI BUS DMA ADDRESSING NOT SUPPORTED\n");
return -1;
--- linux/drivers/scsi/sym53c8xx_comm.h~ Thu Aug 16 13:43:09 2001
+++ linux/drivers/scsi/sym53c8xx_comm.h Thu Aug 16 13:43:32 2001
@@ -2186,7 +2186,7 @@
(int) (PciDeviceFn(pdev) & 7));
#ifdef SCSI_NCR_DYNAMIC_DMA_MAPPING
- if (!pci_dma_supported(pdev, 0xffffffff)) {
+ if (!pci_dma_supported(pdev, PCI_MAX_DMA32)) {
printk(KERN_WARNING NAME53C8XX
"32 BIT PCI BUS DMA ADDRESSING NOT SUPPORTED\n");
return -1;
--
Jens Axboe
next prev parent reply other threads:[~2001-08-16 11:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-15 7:50 [patch] zero-bounce highmem I/O Jens Axboe
2001-08-15 9:11 ` David S. Miller
2001-08-15 9:17 ` Jens Axboe
2001-08-15 9:26 ` Jens Axboe
2001-08-15 10:22 ` David S. Miller
2001-08-15 11:13 ` Jens Axboe
2001-08-15 11:47 ` David S. Miller
2001-08-15 12:07 ` Jens Axboe
2001-08-15 12:35 ` David S. Miller
2001-08-15 13:10 ` Jens Axboe
2001-08-15 14:25 ` David S. Miller
2001-08-16 11:51 ` Jens Axboe [this message]
2001-08-16 11:56 ` David S. Miller
2001-08-16 12:03 ` Jens Axboe
2001-08-16 12:14 ` Gerd Knorr
2001-08-16 12:27 ` David S. Miller
2001-08-16 12:48 ` Jens Axboe
2001-08-16 12:56 ` Jens Axboe
2001-08-16 13:08 ` David S. Miller
2001-08-16 12:34 ` David S. Miller
2001-08-16 13:35 ` Gerd Knorr
2001-08-16 14:15 ` David S. Miller
2001-08-16 12:28 ` kill alt_address (Re: [patch] zero-bounce highmem I/O) David S. Miller
2001-08-15 14:02 ` [patch] zero-bounce highmem I/O David S. Miller
2001-08-16 5:52 ` Jens Axboe
2001-08-15 19:20 ` Gérard Roudier
2001-08-16 8:12 ` David S. Miller
[not found] <no.id>
2001-08-16 14:56 ` Alan Cox
2001-08-17 10:18 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010816135150.X4352@suse.de \
--to=axboe@suse.de \
--cc=andrea@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).