From: Jens Axboe <axboe@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org, andrea@suse.de
Subject: Re: [patch] zero-bounce highmem I/O
Date: Thu, 16 Aug 2001 14:03:17 +0200 [thread overview]
Message-ID: <20010816140317.Y4352@suse.de> (raw)
In-Reply-To: <20010815.070204.39155321.davem@redhat.com> <20010815.072548.48531893.davem@redhat.com> <20010816135150.X4352@suse.de> <20010816.045642.116348743.davem@redhat.com>
In-Reply-To: <20010816.045642.116348743.davem@redhat.com>
On Thu, Aug 16 2001, David S. Miller wrote:
> From: Jens Axboe <axboe@suse.de>
> Date: Thu, 16 Aug 2001 13:51:50 +0200
>
> [ Hopefully this mail won't be encoded in Chinese-BIG5 :-) sorry
> about that ]
Looks good :)
> The only difference between your and my tree now is the PCI_MAX_DMA32
> flag. Would you consider this? I already use this flag in the block
> stuff, I just updated the two references you had. Maybe
> PCI_MAX_DMA32_MASK is a better name.
>
> I didn't put it into my patch becuase there is no way you can
> use such a value in generic code.
>
> What if my scsi controller's pci DMA mask is 0x7fffffff or something
> like this? You don't know at the generic layer, and you must provide
> some way for the block device to indicate stuff like this to you.
Then your SCSI controller will not use PCI_MAX_DMA32 but rather that
particular mask? For block drivers, using 0x7fffffff for
blk_queue_bounce_limit is perfectly fine too.
> That is why PCI_MAX_DMA32, or whatever you would like to name it, does
> not make any sense. It can be a shorthand for drivers themselves, but
> that is it and personally I'd rather they just put the bits there
> explicitly.
Drivers, right. THe block stuff used it in _one_ place -- the
BLK_BOUNCE_4G define, to indicated the need to bounce anything above 4G.
But no problem, I can just define that to 0xffffffff myself.
> I am just finishing up the "death of alt_address" patch right now.
Excellent.
--
Jens Axboe
next prev parent reply other threads:[~2001-08-16 12:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-15 7:50 [patch] zero-bounce highmem I/O Jens Axboe
2001-08-15 9:11 ` David S. Miller
2001-08-15 9:17 ` Jens Axboe
2001-08-15 9:26 ` Jens Axboe
2001-08-15 10:22 ` David S. Miller
2001-08-15 11:13 ` Jens Axboe
2001-08-15 11:47 ` David S. Miller
2001-08-15 12:07 ` Jens Axboe
2001-08-15 12:35 ` David S. Miller
2001-08-15 13:10 ` Jens Axboe
2001-08-15 14:25 ` David S. Miller
2001-08-16 11:51 ` Jens Axboe
2001-08-16 11:56 ` David S. Miller
2001-08-16 12:03 ` Jens Axboe [this message]
2001-08-16 12:14 ` Gerd Knorr
2001-08-16 12:27 ` David S. Miller
2001-08-16 12:48 ` Jens Axboe
2001-08-16 12:56 ` Jens Axboe
2001-08-16 13:08 ` David S. Miller
2001-08-16 12:34 ` David S. Miller
2001-08-16 13:35 ` Gerd Knorr
2001-08-16 14:15 ` David S. Miller
2001-08-16 12:28 ` kill alt_address (Re: [patch] zero-bounce highmem I/O) David S. Miller
2001-08-15 14:02 ` [patch] zero-bounce highmem I/O David S. Miller
2001-08-16 5:52 ` Jens Axboe
2001-08-15 19:20 ` Gérard Roudier
2001-08-16 8:12 ` David S. Miller
[not found] <no.id>
2001-08-16 14:56 ` Alan Cox
2001-08-17 10:18 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010816140317.Y4352@suse.de \
--to=axboe@suse.de \
--cc=andrea@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).